Re: [PATCH] Doc:kvm: Fix typo in Doc/virtual/kvm

2015-10-11 Thread Jonathan Corbet
On Sun, 4 Oct 2015 00:46:21 +0900 Masanari Iida wrote: > This patch fix spelling typos in Documentation/virtual/kvm. Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 3/4] add ksm kernel shared memory driver.

2008-12-02 Thread Jonathan Corbet
On Tue, 2 Dec 2008 13:24:11 -0800 Chris Wright <[EMAIL PROTECTED]> wrote: > > Using current known techniques. A random collision is just as bad > > news. > > And, just to clarify, your concern would extend to any digest based > comparison? Or are you specifically concerned about sha1? Wouldn'

Re: [PATCH 3/4] add ksm kernel shared memory driver

2008-11-11 Thread Jonathan Corbet
[Let's see if I can get through the rest without premature sends...] On Wed, 12 Nov 2008 00:17:39 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > > Actually, it occurs to me that there's no sanity checks on any of > > the values passed in by ioctl(). What happens if the user tells > > KSM to scan

Re: [PATCH 3/4] add ksm kernel shared memory driver

2008-11-11 Thread Jonathan Corbet
On Wed, 12 Nov 2008 00:17:39 +0200 Izik Eidus <[EMAIL PROTECTED]> wrote: > >> +static int ksm_dev_open(struct inode *inode, struct file *filp) > >> +{ > >> + try_module_get(THIS_MODULE); > >> + return 0; > >> +} > >> + > >> +static int ksm_dev_release(struct inode *inode, struct file *filp) > >>

Re: [PATCH 3/4] add ksm kernel shared memory driver

2008-11-11 Thread Jonathan Corbet
I don't claim to begin to really understand the deep VM side of this patch, but I can certainly pick nits as I work through it...sorry for the lack of anything more substantive. > +static struct list_head slots; Some of these file-static variable names seem a little..terse... > +#define PAGECMP_