Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-31 Thread Kenji Kaneshige
(2011/10/28 21:48), Jun Koi wrote: 2011/10/28 Kenji Kaneshige: Avi, Jan, Could you comment on these patches? Inject-NMI doesn't work on Windows guest without these patches. sorry but i am really curious here: why Windows still works well even if it desnt see the inject-NMI? or ther

Re: [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Kenji Kaneshige
tches were already reviewed by seabios people, but need ack from qemu/kvm side. Regards, Kenji Kaneshige (2011/10/10 15:06), Lai Jiangshan wrote: > From: Kenji Kaneshige > > ACPI NMI Structure describes LINT pin (LINT0 or LINT1) information to > which NMI is connected, and it i

Re: [PATCH 1/1 V2] kernel/kvm: fix improper nmi emulation

2011-10-12 Thread Kenji Kaneshige
(2011/10/12 2:00), Lai Jiangshan wrote: > From: Kenji Kaneshige > > Currently, NMI interrupt is blindly sent to all the vCPUs when NMI > button event happens. This doesn't properly emulate real hardware on > which NMI button event triggers LINT1. Because of this, NMI is sen

Re: [PATCH] kernel/kvm: fix improper nmi emulation

2011-10-12 Thread Kenji Kaneshige
(2011/10/10 19:26), Avi Kivity wrote: > On 10/10/2011 08:06 AM, Lai Jiangshan wrote: >> From: Kenji Kaneshige >> >> Currently, NMI interrupt is blindly sent to all the vCPUs when NMI >> button event happens. This doesn't properly emulate real hardware on >>

Re: [PATCH] pci: clean all funcs when hot-removing multifunc device

2011-09-15 Thread Kenji Kaneshige
No objection about fixing Linux. Why do we need pci_scan_single_device()? The device should have been scanned already when it was added, and I would think that should have set pdev->multifunction. It should be pci_get_slot() instead. Note that it needs corresponding pci_dev_put(). Re