Re: [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-05 Thread Marcelo Tosatti
On Mon, May 05, 2014 at 08:23:43PM -0300, Marcelo Tosatti wrote: Hi Alexander, On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote: When we migrate we ask the kernel about its current belief on what the guest time would be. KVM_GET_CLOCK which returns the time in struct

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-05 Thread Marcelo Tosatti
Marcin, Can you provide detailed instructions on how to reproduce the problem? Thanks On Mon, May 05, 2014 at 08:27:10PM -0300, Marcelo Tosatti wrote: On Mon, May 05, 2014 at 08:26:04PM +0200, Marcin Gibuła wrote: is it possible to have kvmclock jumping forward? Because I've

[PATCH] savevm: check vmsd for migratability status (v2)

2014-04-29 Thread Marcelo Tosatti
Check vmsd for unmigratable field, allowing migratibility status to be modified after vmstate_register. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/savevm.c b/savevm.c index da8aa24..c578e42 100644 --- a/savevm.c +++ b/savevm.c @@ -232,7 +232,6 @@ typedef struct

KVM: x86: expose invariant tsc cpuid bit (v2)

2014-04-28 Thread Marcelo Tosatti
Invariant TSC is a property of TSC, no additional support code necessary. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index f47a104..333b88d 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -495,6 +495,13 @@ static

Re: target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-25 Thread Marcelo Tosatti
On Thu, Apr 24, 2014 at 04:21:59PM -0300, Eduardo Habkost wrote: On Wed, Apr 23, 2014 at 06:04:45PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration

KVM: x86: expose invariant tsc cpuid bit

2014-04-25 Thread Marcelo Tosatti
Invariant TSC is a property of TSC, no additional support code necessary. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index f47a104..4f076d7 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -495,6 +495,11 @@ static

[PATCH] savevm: check vmsd for migratability status

2014-04-25 Thread Marcelo Tosatti
Check vmsd for unmigratable field, allowing migratibility status to be modified after vmstate_register. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/savevm.c b/savevm.c index 22123be..61a25c0 100644 --- a/savevm.c +++ b/savevm.c @@ -452,7 +452,7 @@ bool

Re: target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-25 Thread Marcelo Tosatti
On Fri, Apr 25, 2014 at 05:38:08PM -0300, Eduardo Habkost wrote: Have you tested if your patch actually blocks savevm? Yes, with -smp 2. Can you please include the savevm.c patch in your queue? TIA. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH v5 0/5] KVM: x86: flush tlb out of mmu-lock after write protection

2014-04-24 Thread Marcelo Tosatti
On Thu, Apr 17, 2014 at 05:06:11PM +0800, Xiao Guangrong wrote: Since Marcelo has agreed the comments improving in the off-line mail, i consider this is his Ack. :) Please let me know If i misunderstood it. This patchset is splited from my previous patchset: [PATCH v3 00/15] KVM: MMU:

[patch 0/2] expose invariant tsc flag for kvm guests (v2)

2014-04-23 Thread Marcelo Tosatti
v2: - filter for TCG at cpu realizefn. - allow invariant tsc by default with -cpu host. - fix initialization with multiple vcpus. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

[patch 1/2] target-i386: support invariant tsc flag

2014-04-23 Thread Marcelo Tosatti
the overhead associated with a ring transition or access to a platform resource. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-invariant-tsc/target-i386/cpu.c === --- qemu-invariant-tsc.orig/target-i386/cpu.c +++ qemu-invariant

[patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-23 Thread Marcelo Tosatti
by default. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-invariant-tsc/target-i386/kvm.c === --- qemu-invariant-tsc.orig/target-i386/kvm.c +++ qemu-invariant-tsc/target-i386/kvm.c @@ -33,6 +33,8 @@ #include exec

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-23 Thread Marcelo Tosatti
On Wed, Apr 23, 2014 at 08:52:03AM +0300, Michael S. Tsirkin wrote: HV-APIC-ASSIST MSR is in the list of saved MSRs ... Restoration of MSR_KVM_PV_EOI_EN is required for migration under when PVEOI enabled ? That's what I don't get. Since after this patch, set of

Re: [PATCH 4/5] KVM: x86: RSI/RDI/RCX are zero-extended when affected by string ops

2014-04-23 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 09:04:45AM +0300, Nadav Amit wrote: Gleb, On 4/20/14, 12:26 PM, Gleb Natapov wrote: On Fri, Apr 18, 2014 at 07:11:33AM +0300, Nadav Amit wrote: When using address-size override prefix with string instructions in long-mode, ESI/EDI/ECX are zero extended if they are

Re: [PATCH 4/5] KVM: x86: RSI/RDI/RCX are zero-extended when affected by string ops

2014-04-23 Thread Marcelo Tosatti
On Wed, Apr 23, 2014 at 04:58:32PM -0300, Marcelo Tosatti wrote: On Tue, Apr 22, 2014 at 09:04:45AM +0300, Nadav Amit wrote: Gleb, On 4/20/14, 12:26 PM, Gleb Natapov wrote: On Fri, Apr 18, 2014 at 07:11:33AM +0300, Nadav Amit wrote: When using address-size override prefix with string

Re: [PATCH 0/5] KVM: x86: Fix KVM behavior that does not follow spec

2014-04-23 Thread Marcelo Tosatti
On Fri, Apr 18, 2014 at 02:33:06AM +0300, Nadav Amit wrote: This series of patches fix various scenarios in which KVM behavior does not follow x86 specifications. Each patch actually deals with a separate bug. These bugs can cause the guest to get stuck (i.e., make no progress), encounter

target-i386: block migration and savevm if invariant tsc is exposed (v3)

2014-04-23 Thread Marcelo Tosatti
Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block migration/savevm. Signed-off-by: Marcelo Tosatti mtosa

[patch 0/2] expose invariant tsc flag for kvm guests

2014-04-22 Thread Marcelo Tosatti
see patches for details. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Marcelo Tosatti
by default. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-invariant-tsc/target-i386/kvm.c === --- qemu-invariant-tsc.orig/target-i386/kvm.c +++ qemu-invariant-tsc/target-i386/kvm.c @@ -33,6 +33,8 @@ #include exec

[patch 1/2] target-i386: support invariant tsc flag

2014-04-22 Thread Marcelo Tosatti
the overhead associated with a ring transition or access to a platform resource. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-invariant-tsc/target-i386/cpu.c === --- qemu-invariant-tsc.orig/target-i386/cpu.c +++ qemu-invariant

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: On Mon, Apr 21, 2014 at 06:40:17PM -0300, Marcelo Tosatti wrote: On Sun, Apr 13, 2014 at 04:10:22PM +0300, Michael S. Tsirkin wrote: It seems that it's easy to implement the EOI assist on top of the PV EOI feature: simply

Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration to a host with different TSC frequency is allowed, or if savevm

Re: [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-22 Thread Marcelo Tosatti
On Tue, Apr 22, 2014 at 05:38:07PM -0300, Eduardo Habkost wrote: On Tue, Apr 22, 2014 at 04:10:44PM -0300, Marcelo Tosatti wrote: Invariant TSC documentation mentions that invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states. This is not the case if migration

Re: [PATCH v3 0/3] nVMX: Fixes to run Xen as L1

2014-04-22 Thread Marcelo Tosatti
On Sat, Apr 19, 2014 at 06:17:43PM -0400, Bandan Das wrote: Minor changes to enable Xen as a L1 hypervisor. Tested with a Haswell host, Xen-4.3 L1 and debian6 L2 Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-22 Thread Marcelo Tosatti
On Wed, Apr 23, 2014 at 01:12:49AM +0300, Michael S. Tsirkin wrote: On Tue, Apr 22, 2014 at 04:26:48PM -0300, Marcelo Tosatti wrote: On Tue, Apr 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: On Mon, Apr 21, 2014 at 06:40:17PM -0300, Marcelo Tosatti wrote: On Sun, Apr 13, 2014

Re: [RFC PATCH 1/5] KVM: vmx: speed up emulation of invalid guest state

2014-04-21 Thread Marcelo Tosatti
On Fri, Apr 18, 2014 at 12:19:28AM -0400, Paolo Bonzini wrote: Il 16/04/2014 18:52, Marcelo Tosatti ha scritto: How about handling VM-entry error due to invalid state with vmx-emulation_required = true; continue to main vcpu loop; What would reset it to false though? None of the places

Re: Raw Disk Not Appearing in Guests

2014-04-21 Thread Marcelo Tosatti
On Sat, Apr 05, 2014 at 11:33:39AM -0400, Ryan Lichtenwalter wrote: Dear reader, Please let me know if I need to file a bug report. It does not seem like this could be a bug, because it seems like a very natural thing to want to do that many would have tried before. Host OS is CentOS 6.5,

Re: [PATCH 3/3] kvm: s390: Exploiting generic userspace interface for cmma\

2014-04-21 Thread Marcelo Tosatti
On Wed, Apr 16, 2014 at 09:47:52PM +0200, Alexander Graf wrote: On 16.04.14 20:49, Marcelo Tosatti wrote: On Thu, Apr 10, 2014 at 01:16:44PM +0200, Christian Borntraeger wrote: From: Dominik Dingel din...@linux.vnet.ibm.com To enable CMMA and to reset its state we use the vm kvm_device

Re: [RFC PATCH 0/6] KVM: x86: speedups for emulator memory accesses

2014-04-21 Thread Marcelo Tosatti
+++ include/linux/kvm_host.h | 6 +++ virt/kvm/kvm_main.c| 17 ++ 5 files changed, 185 insertions(+), 40 deletions(-) -- 1.8.3.1 Reviewed-by: Marcelo Tosatti mtosa...@redhat.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH RFC untested] kvm/x86: implement hv EOI assist

2014-04-21 Thread Marcelo Tosatti
On Sun, Apr 13, 2014 at 04:10:22PM +0300, Michael S. Tsirkin wrote: It seems that it's easy to implement the EOI assist on top of the PV EOI feature: simply convert the page address to the format expected by PV EOI. Signed-off-by: Michael S. Tsirkin m...@redhat.com Looks alright except: -

Re: NX/DEP from host to guest

2014-04-21 Thread Marcelo Tosatti
On Sat, Apr 05, 2014 at 11:18:04AM -0700, Simon Matthews wrote: I experiencing problems on a Windows guest, in which a process repeatedly shows Killed in the shell after running for a short time (it is running in the SUA/Interix environment). The process is part of a tool that was open-source,

Re:

2014-04-21 Thread Marcelo Tosatti
On Thu, Apr 17, 2014 at 02:33:41PM -0700, Marcus White wrote: Hello, I had some basic questions regarding KVM, and would appreciate any help:) I have been reading about the KVM architecture, and as I understand it, the guest shows up as a regular process in the host itself.. I

Re: [PATCH 2/2] vmx: speed up wildcard MMIO EVENTFD

2014-04-17 Thread Marcelo Tosatti
On Thu, Apr 17, 2014 at 03:33:55PM +0300, Michael S. Tsirkin wrote: On Mon, Mar 31, 2014 at 09:50:44PM +0300, Michael S. Tsirkin wrote: With KVM, MMIO is much slower than PIO, due to the need to do page walk and emulation. But with EPT, it does not have to be: we know the address from the

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread Marcelo Tosatti
On Fri, Apr 04, 2014 at 06:31:04AM +0300, Nadav Amit wrote: KVM does not handle the reserved bits of x86 page tables correctly: In PAE, bits 5:8 are reserved in the PDPTE. In IA-32e, bit 8 is not reserved. Signed-off-by: Nadav Amit na...@cs.technion.ac.il --- arch/x86/kvm/mmu.c |6

Re: [PATCH] KVM: x86: Fix CR3 and LDT sel should not be saved in TSS

2014-04-16 Thread Marcelo Tosatti
On Mon, Apr 07, 2014 at 06:37:47PM +0300, Nadav Amit wrote: According to Intel specifications, only general purpose registers and segment selectors should are saved in the old TSS during 32-bit task-switch. should be Signed-off-by: Nadav Amit na...@cs.technion.ac.il ---

Re: [PATCH 3/3] kvm: s390: Exploiting generic userspace interface for cmma\

2014-04-16 Thread Marcelo Tosatti
On Thu, Apr 10, 2014 at 01:16:44PM +0200, Christian Borntraeger wrote: From: Dominik Dingel din...@linux.vnet.ibm.com To enable CMMA and to reset its state we use the vm kvm_device ioctls, encapsulating attributes within the KVM_S390_VM_MEM_CTRL group. Signed-off-by: Dominik Dingel

Re:

2014-04-16 Thread Marcelo Tosatti
On Mon, Apr 14, 2014 at 05:59:05PM -0700, Marcus White wrote: Hello, A friendly bump to see if anyone has any ideas:-) Cheers! On Sun, Apr 13, 2014 at 2:01 PM, Marcus White roastedseawee...@gmail.com wrote: Hello, I had some basic questions regarding KVM, and would appreciate any

Re: [PATCH] KVM: x86: Fix page-tables reserved bits

2014-04-16 Thread Marcelo Tosatti
On Wed, Apr 16, 2014 at 02:17:08PM -0700, H. Peter Anvin wrote: On 04/16/2014 12:03 PM, Marcelo Tosatti wrote: @@ -3550,9 +3550,9 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, break; case PT64_ROOT_LEVEL: context-rsvd_bits_mask[0][3

Re: [RFC PATCH 1/5] KVM: vmx: speed up emulation of invalid guest state

2014-04-16 Thread Marcelo Tosatti
On Thu, Mar 27, 2014 at 12:30:34PM +0100, Paolo Bonzini wrote: About 25% of the time spent in emulation of invalid guest state is wasted in checking whether emulation is required for the next instruction. However, this almost never changes except when a segment register (or TR or LDTR)

[GIT PULL] KVM fixes for 3.15-rc1

2014-04-14 Thread Marcelo Tosatti
CR4_RESERVED_BITS KVM: Add SMAP support when setting CR4 KVM: Disable SMAP for guests in EPT realmode and EPT unpaging mode KVM: expose SMAP feature to guest KVM: Rename variable smep to cr4_smep Marcelo Tosatti (1): KVM: x86: remove WARN_ON from get_kernel_ns() Paolo Bonzini (2

Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

2014-04-13 Thread Marcelo Tosatti
On Fri, Apr 11, 2014 at 08:16:28PM -0400, Paolo Bonzini wrote: Il 10/04/2014 16:01, Marcelo Tosatti ha scritto: On Tue, Apr 08, 2014 at 04:38:08PM -0400, Paolo Bonzini wrote: Il 07/04/2014 21:06, Wu, Feng ha scritto: Even though the tests do not cover the CPL=3/implicit access case, the logic

Re: [PATCH v2 2/3] KVM: nVMX: Ack and write vector info to intr_info if L1 asks us to

2014-04-11 Thread Marcelo Tosatti
On Mon, Mar 31, 2014 at 05:00:24PM -0400, Bandan Das wrote: This feature emulates the Acknowledge interrupt on exit behavior. We can safely emulate it for L1 to run L2 even if L0 itself has it disabled (to run L1). Signed-off-by: Bandan Das b...@redhat.com --- arch/x86/kvm/irq.c | 1 +

Re: [PATCH v2 1/3] KVM: nVMX: Don't advertise single context invalidation for invept

2014-04-11 Thread Marcelo Tosatti
On Fri, Apr 11, 2014 at 08:22:13AM +0200, Jan Kiszka wrote: But rethinking this again, I agree with you. If there's a hypervisor with a single context invept implmentation that does not fallback, this will unfortunately not work. Jan, do you agree with this ? A hypervisor that doesn't

Re: [PATCH v2 1/3] KVM: nVMX: Don't advertise single context invalidation for invept

2014-04-11 Thread Marcelo Tosatti
On Fri, Apr 11, 2014 at 08:22:13AM +0200, Jan Kiszka wrote: On 2014-04-11 02:27, Bandan Das wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Mon, Mar 31, 2014 at 05:00:23PM -0400, Bandan Das wrote: For single context invalidation, we fall through to global invalidation

Re: [PATCH v2 2/3] KVM: nVMX: Ack and write vector info to intr_info if L1 asks us to

2014-04-11 Thread Marcelo Tosatti
On Fri, Apr 11, 2014 at 03:17:47PM -0400, Bandan Das wrote: Marcelo Tosatti mtosa...@redhat.com writes: On Mon, Mar 31, 2014 at 05:00:24PM -0400, Bandan Das wrote: This feature emulates the Acknowledge interrupt on exit behavior. We can safely emulate it for L1 to run L2 even if L0 itself

Re: [PATCH v2 1/3] KVM: nVMX: Don't advertise single context invalidation for invept

2014-04-11 Thread Marcelo Tosatti
On Fri, Apr 11, 2014 at 08:53:09PM +0200, Jan Kiszka wrote: On 2014-04-11 20:35, Bandan Das wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2014-04-11 19:26, Bandan Das wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2014-04-11 02:27, Bandan Das wrote: Marcelo Tosatti mtosa

Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

2014-04-10 Thread Marcelo Tosatti
On Tue, Apr 08, 2014 at 04:38:08PM -0400, Paolo Bonzini wrote: Il 07/04/2014 21:06, Wu, Feng ha scritto: Even though the tests do not cover the CPL=3/implicit access case, the logic to compute PFERR_RSVD_MASK dynamically is already covered by AC=1. So I'm quite happy with the coverage.

Re: [PATCH v4 2/4] KVM: Add SMAP support when setting CR4

2014-04-10 Thread Marcelo Tosatti
On Tue, Apr 01, 2014 at 05:46:34PM +0800, Feng Wu wrote: This patch adds SMAP handling logic when setting CR4 for guests Thanks a lot to Paolo Bonzini for his suggestion to use the branchless way to detect SMAP violation. Signed-off-by: Feng Wu feng...@intel.com @@ -110,10 +118,30 @@

Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

2014-04-10 Thread Marcelo Tosatti
, 92 insertions(+), 20 deletions(-) Reviewed-by: Marcelo Tosatti mtosa...@redhat.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] KVM: nVMX: Don't advertise single context invalidation for invept

2014-04-10 Thread Marcelo Tosatti
On Mon, Mar 31, 2014 at 05:00:23PM -0400, Bandan Das wrote: For single context invalidation, we fall through to global invalidation in handle_invept() except for one case - when the operand supplied by L1 is different from what we have in vmcs12. However, typically hypervisors will only call

KVM: x86: remove WARN_ON from get_kernel_ns()

2014-04-10 Thread Marcelo Tosatti
Function and callers can be preempted. https://bugzilla.kernel.org/show_bug.cgi?id=73721 Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 2b85784..ee0c3b5 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1109,7 +1109,6

Re: [PATCH 5/5] KVM: MMU: flush tlb out of mmu lock when write-protect the sptes

2014-04-09 Thread Marcelo Tosatti
On Mon, Mar 10, 2014 at 10:01:49PM +0800, Xiao Guangrong wrote: Now we can flush all the TLBs out of the mmu lock without TLB corruption when write-proect the sptes, it is because: - we have marked large sptes readonly instead of dropping them that means we just change the spte from writable

Re: VDSO pvclock may increase host cpu consumption, is this a problem?

2014-04-02 Thread Marcelo Tosatti
On Tue, Apr 01, 2014 at 05:46:34PM -0700, Andy Lutomirski wrote: On Tue, Apr 1, 2014 at 5:29 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Apr 01, 2014 at 12:17:16PM -0700, Andy Lutomirski wrote: On Tue, Apr 1, 2014 at 11:01 AM, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon

Re: VDSO pvclock may increase host cpu consumption, is this a problem?

2014-04-01 Thread Marcelo Tosatti
On Mon, Mar 31, 2014 at 10:33:41PM -0700, Andy Lutomirski wrote: On Mar 31, 2014 8:45 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Mar 31, 2014 at 10:52:25AM -0700, Andy Lutomirski wrote: On 03/29/2014 01:47 AM, Zhanghailiang wrote: Hi, I found when Guest is idle, VDSO

Re: VDSO pvclock may increase host cpu consumption, is this a problem?

2014-04-01 Thread Marcelo Tosatti
On Tue, Apr 01, 2014 at 12:17:16PM -0700, Andy Lutomirski wrote: On Tue, Apr 1, 2014 at 11:01 AM, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Mar 31, 2014 at 10:33:41PM -0700, Andy Lutomirski wrote: On Mar 31, 2014 8:45 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Mar

Re: VDSO pvclock may increase host cpu consumption, is this a problem?

2014-03-31 Thread Marcelo Tosatti
On Mon, Mar 31, 2014 at 10:52:25AM -0700, Andy Lutomirski wrote: On 03/29/2014 01:47 AM, Zhanghailiang wrote: Hi, I found when Guest is idle, VDSO pvclock may increase host consumption. We can calcutate as follow, Correct me if I am wrong. (Host)250 * update_pvclock_gtod = 1500 *

Re: VDSO pvclock may increase host cpu consumption, is this a problem?

2014-03-29 Thread Marcelo Tosatti
On Sat, Mar 29, 2014 at 08:47:27AM +, Zhanghailiang wrote: Hi, I found when Guest is idle, VDSO pvclock may increase host consumption. We can calcutate as follow, Correct me if I am wrong. (Host)250 * update_pvclock_gtod = 1500 * gettimeofday(Guest) In Host, VDSO pvclock introduce a

Re: [PATCH] KVM: SVM: fix cr8 intercept window

2014-03-12 Thread Marcelo Tosatti
On Wed, Mar 12, 2014 at 11:40:48AM +0100, Radim Krčmář wrote: 2014-03-11 22:05-0300, Marcelo Tosatti: On Tue, Mar 11, 2014 at 07:11:18PM +0100, Radim Krčmář wrote: We always disable cr8 intercept in its handler, but only re-enable it if handling KVM_REQ_EVENT, so there can be a window

Re: [PATCH] KVM: SVM: fix cr8 intercept window

2014-03-11 Thread Marcelo Tosatti
On Tue, Mar 11, 2014 at 07:11:18PM +0100, Radim Krčmář wrote: We always disable cr8 intercept in its handler, but only re-enable it if handling KVM_REQ_EVENT, so there can be a window where we do not intercept cr8 writes, which allows an interrupt to disrupt a higher priority task. Fix this

Re: [PATCH v3 2/3] KVM: nVMX: Fully emulate preemption timer

2014-03-07 Thread Marcelo Tosatti
On Thu, Mar 06, 2014 at 06:33:58PM +0100, Jan Kiszka wrote: We cannot rely on the hardware-provided preemption timer support because we are holding L2 in HLT outside non-root mode. Furthermore, emulating the preemption will resolve tick rate errata on older Intel CPUs. Can you describe this

Re: Enhancement for PLE handler in KVM

2014-03-07 Thread Marcelo Tosatti
On Fri, Mar 07, 2014 at 02:26:19PM +, Li, Bin (Bin) wrote: Can we have per-VM PLE values? My understanding is that the ple values are kvm module setting which applying to all VMs in the system. And all vms must be stopped first, then unload kvm-intel, reload kvm-intel with new ple

Re: Enhancement for PLE handler in KVM

2014-03-07 Thread Marcelo Tosatti
On Fri, Mar 07, 2014 at 10:08:52PM +, Li, Bin (Bin) wrote: Fully agree. It will be a very helpful feature to make ple setting per VM. This feature will provide more flexible control to the VM user. All KVM user will love to have it. The enhancement we proposed is neither overlapping

Re: Enhancement for PLE handler in KVM

2014-03-06 Thread Marcelo Tosatti
On Wed, Mar 05, 2014 at 09:16:45PM +, Li, Bin (Bin) wrote: Did you also find out here why this is the case? Binl: Yes. The application running in our customized embedded OS is also real time application which is timing sensitive. The timing sensitive level varies among the

Re: file_ram_alloc: unify mem-path,mem-prealloc error handling

2014-02-28 Thread Marcelo Tosatti
On Thu, Feb 27, 2014 at 07:30:26PM +0100, Paolo Bonzini wrote: Il 04/02/2014 19:41, Marcelo Tosatti ha scritto: -mem-prealloc asks to preallocate memory residing on -mem-path path. Currently QEMU exits in case: - Memory file has been created but allocation via explicit write fails

Re: [PATCH 0/2 v2] x86: kvm: global clock updates

2014-02-28 Thread Marcelo Tosatti
On Fri, Feb 28, 2014 at 12:52:53PM +0100, Andrew Jones wrote: This patch series addresses two issues with global clock updates. The first fixes a bug found on hosts that have a tsc marked as unstable. As global clock updates get triggered on every vcpu load in these cases, guests with a large

Re: [PATCH 1/2] x86: kvm: rate-limit global clock updates

2014-02-26 Thread Marcelo Tosatti
On Wed, Feb 26, 2014 at 07:15:11PM +0100, Andrew Jones wrote: When we update a vcpu's local clock it may pick up an NTP correction. We can't wait an indeterminate amount of time for other vcpus to pick up that correction, so commit 0061d53daf26f introduced a global clock update. However, we

Re: [PATCH 2/2] x86: kvm: introduce periodic global clock updates

2014-02-26 Thread Marcelo Tosatti
On Wed, Feb 26, 2014 at 07:15:12PM +0100, Andrew Jones wrote: commit 0061d53daf26f introduced a mechanism to execute a global clock update for a vm. We can apply this periodically in order to propagate host NTP corrections. Also, if all vcpus of a vm are pinned, then without an additional

Re: KVM: MMU: drop read-only large sptes when creating lower level sptes

2014-02-25 Thread Marcelo Tosatti
On Tue, Feb 25, 2014 at 11:30:37AM +0800, Xiao Guangrong wrote: On 02/25/2014 12:59 AM, Marcelo Tosatti wrote: Read-only large sptes can be created due to read-only faults as follows: - QEMU pagetable entry that maps guest memory is read-only due to COW. - Guest read faults

Re: KVM: MMU: drop read-only large sptes when creating lower level sptes

2014-02-25 Thread Marcelo Tosatti
On Tue, Feb 25, 2014 at 11:11:19PM +0800, Xiao Guangrong wrote: On Feb 25, 2014, at 9:13 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Feb 25, 2014 at 11:30:37AM +0800, Xiao Guangrong wrote: On 02/25/2014 12:59 AM, Marcelo Tosatti wrote: Read-only large sptes can be created

KVM: x86: emulator_cmpxchg_emulated should mark_page_dirty

2014-02-25 Thread Marcelo Tosatti
emulator_cmpxchg_emulated writes to guest memory, therefore it should updated the dirty bitmap accordingly. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 39c28f09..29db96d 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c

Re: KVM: x86: emulator_cmpxchg_emulated should mark_page_dirty

2014-02-25 Thread Marcelo Tosatti
On Tue, Feb 25, 2014 at 10:44:54PM -0300, Marcelo Tosatti wrote: emulator_cmpxchg_emulated writes to guest memory, therefore it should updated the dirty bitmap accordingly. s/updated/update/ Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/x86.c b/arch/x86

[uq/master PATCH] kvm-all: exit in case max vcpus exceeded

2014-02-25 Thread Marcelo Tosatti
Rather than fall back to TCG (so the user has to discover whats happening, in case of no access to qemu stdout/stderr). Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/kvm-all.c b/kvm-all.c index 3937754..3f6841d 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1432,11 +1432,10

KVM: MMU: drop read-only large sptes when creating lower level sptes

2014-02-24 Thread Marcelo Tosatti
-only. - Write-fault on such memory causes guest to loop endlessly (which must go down to level 1 because dirty logging is enabled). Fix by dropping large spte when necessary. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index e50425d

Re: [PATCH] x86: kvm: fix unstable_tsc boot

2014-02-24 Thread Marcelo Tosatti
On Mon, Feb 24, 2014 at 04:42:29PM +0100, Andrew Jones wrote: When the tsc is marked unstable on the host it causes global clock updates to be requested each time a vcpu is loaded, nearly halting all progress on guests with a large number of vcpus. Fix this by only requesting a local clock

Re: kvm cpu usage allocation

2014-02-20 Thread Marcelo Tosatti
On Wed, Feb 19, 2014 at 06:42:56PM -0300, Alejandro Comisario wrote: Hi everyone. We are having a private cloud with more than 1000 phy servers. Each server has 128GB of RAM and 24 cores (2 heaxacores with HT enabled), but the amount of vms running on those servers versus the flavor (amount

file_ram_alloc: unify mem-path,mem-prealloc error handling

2014-02-04 Thread Marcelo Tosatti
fails. Have the same behaviour for all cases: fail in case -mem-path and -mem-prealloc are specified for regions where the requested size is suitable for hugepages. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/exec.c b/exec.c index 9ad0a4b..1da1ba7 100644 --- a/exec.c +++ b/exec.c

Re: file_ram_alloc: unify mem-path,mem-prealloc error handling

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 01:41:53PM -0500, Marcelo Tosatti wrote: -mem-prealloc asks to preallocate memory residing on -mem-path path. Currently QEMU exits in case: - Memory file has been created but allocation via explicit write fails. And it fallbacks to malloc in case: - Querying

KVM: x86: remove unused last_kernel_ns variable

2014-01-29 Thread Marcelo Tosatti
Remove unused last_kernel_ns variable. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index fdf83af..0ffe714 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -444,7 +444,6

Re: [PATCH 1/5] KVM: fix coexistence of KVM and Hyper-V leaves

2014-01-24 Thread Marcelo Tosatti
On Fri, Jan 24, 2014 at 05:17:52PM +0100, Paolo Bonzini wrote: kvm_arch_init_vcpu's initialization of the KVM leaves at 0x4100 is broken, because KVM_CPUID_FEATURES is left at 0x4001. Move it to 0x4101 if Hyper-V is enabled. Signed-off-by: Paolo Bonzini pbonz...@redhat.com

Re: [PATCH 0/2] Mark Hyper-V hypercall and vapic assist pages as dirty

2014-01-23 Thread Marcelo Tosatti
On Thu, Jan 23, 2014 at 06:12:51PM +1100, Vadim Rozenfeld wrote: Vadim Rozenfeld (2): mark hyper-v hypercall page as dirty mark hyper-v vapic assist page as dirty arch/x86/kvm/x86.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 1.8.1.4 Reviewed-by: Marcelo

Re: [PATCH uq/master] kvm: always update the MPX model specific register

2014-01-22 Thread Marcelo Tosatti
On Mon, Jan 20, 2014 at 02:25:36PM +0100, Paolo Bonzini wrote: The original patch from Liu Jinsong restricted them to reset or full state updates, but that's unnecessary (and wrong) since the BNDCFGS MSR has no side effects. Why is it necessary to save/restore BNDCFGS MSR on states other than

Re: Monotonic clock with KVM pv-clock

2014-01-22 Thread Marcelo Tosatti
On Tue, Jan 21, 2014 at 11:23:37PM +0900, Fernando Luis Vazquez Cao wrote: (2014/01/21 9:19), Marcelo Tosatti wrote: On Mon, Jan 20, 2014 at 11:59:39PM +0900, Fernando Luis Vazquez Cao wrote: (2014/01/20 22:33), Marcelo Tosatti wrote: On Mon, Jan 20, 2014 at 11:56:56AM +0200, Nadav Har'El

Re: Monotonic clock with KVM pv-clock

2014-01-21 Thread Marcelo Tosatti
On Mon, Jan 20, 2014 at 11:59:39PM +0900, Fernando Luis Vazquez Cao wrote: (2014/01/20 22:33), Marcelo Tosatti wrote: On Mon, Jan 20, 2014 at 11:56:56AM +0200, Nadav Har'El wrote: If KVM_SYSTEM_TIME is not a correct way to get a monotonic paravirtual clock from KVM, is there a correct way

Re: Monotonic clock with KVM pv-clock

2014-01-21 Thread Marcelo Tosatti
On Tue, Jan 21, 2014 at 03:24:43PM +0200, Nadav Har'El wrote: On Mon, Jan 20, 2014, Marcelo Tosatti wrote about Re: Monotonic clock with KVM pv-clock: On Mon, Jan 20, 2014 at 11:56:56AM +0200, Nadav Har'El wrote: Hi, I'm trying to figure out how a guest OS can get a monotonic clock

Re: Monotonic clock with KVM pv-clock

2014-01-20 Thread Marcelo Tosatti
On Mon, Jan 20, 2014 at 11:56:56AM +0200, Nadav Har'El wrote: Hi, I'm trying to figure out how a guest OS can get a monotonic clock using KVM's paravirtual clock. At first, I thought that the clock I get using KVM_SYSTEM_TIME is a monotonic clock, based on the host's monotonic clock. It

Re: [RFC PATCH v5] add support for Hyper-V reference time counter

2014-01-17 Thread Marcelo Tosatti
On Fri, Jan 17, 2014 at 10:06:00PM +1100, Vadim Rozenfeld wrote: On Thu, 2014-01-16 at 20:23 -0200, Marcelo Tosatti wrote: On Thu, Jan 16, 2014 at 08:18:37PM +1100, Vadim Rozenfeld wrote: Signed-off: Peter Lieven p...@kamp.de Signed-off: Gleb Natapov Signed-off: Vadim Rozenfeld vroze

Re: KVM: MMU: handle invalid root_hpa at __direct_map

2014-01-17 Thread Marcelo Tosatti
On Fri, Jan 17, 2014 at 01:17:21AM +0200, Rom Freiman wrote: Hi everybody, Marcelo, your suggestion above should work together with the same patch to __direct_mapping. After running some test on different kernels, the !VALID_PAGE happens as following: Linux localhost.localdomain

Re: [RFC PATCH v5] add support for Hyper-V reference time counter

2014-01-16 Thread Marcelo Tosatti
On Thu, Jan 16, 2014 at 08:18:37PM +1100, Vadim Rozenfeld wrote: Signed-off: Peter Lieven p...@kamp.de Signed-off: Gleb Natapov Signed-off: Vadim Rozenfeld vroze...@redhat.com After some consideration I decided to submit only Hyper-V reference counters support this time. I will submit iTSC

Re: KVM: x86: fix tsc catchup issue with tsc scaling

2014-01-15 Thread Marcelo Tosatti
On Wed, Jan 15, 2014 at 12:43:02PM +0100, Paolo Bonzini wrote: Il 06/01/2014 15:18, Marcelo Tosatti ha scritto: To fix a problem related to different resolution of TSC and system clock, the offset in TSC units is approximated by delta = vcpu-hv_clock.tsc_timestamp- vcpu

Re: KVM: x86: fix tsc catchup issue with tsc scaling

2014-01-15 Thread Marcelo Tosatti
On Wed, Jan 15, 2014 at 12:43:02PM +0100, Paolo Bonzini wrote: Il 06/01/2014 15:18, Marcelo Tosatti ha scritto: To fix a problem related to different resolution of TSC and system clock, the offset in TSC units is approximated by delta = vcpu-hv_clock.tsc_timestamp- vcpu

Re: KVM: x86: fix tsc catchup issue with tsc scaling

2014-01-15 Thread Marcelo Tosatti
On Wed, Jan 15, 2014 at 01:55:50PM +0100, Paolo Bonzini wrote: Il 15/01/2014 13:34, Marcelo Tosatti ha scritto: On Wed, Jan 15, 2014 at 12:43:02PM +0100, Paolo Bonzini wrote: Il 06/01/2014 15:18, Marcelo Tosatti ha scritto: To fix a problem related to different resolution of TSC

Re: KVM: x86: fix tsc catchup issue with tsc scaling

2014-01-15 Thread Marcelo Tosatti
On Wed, Jan 15, 2014 at 05:53:22PM +0100, Paolo Bonzini wrote: Il 15/01/2014 17:37, Marcelo Tosatti ha scritto: Right. Another question, what about this comment: /* Reset of TSC must disable overshoot protection below */ vcpu-arch.hv_clock.tsc_timestamp = 0

Re: [PATCH] KVM: remove useless write to vcpu-hv_clock.tsc_timestamp

2014-01-15 Thread Marcelo Tosatti
-arch.virtual_tsc_khz; - /* Reset of TSC must disable overshoot protection below */ - vcpu-arch.hv_clock.tsc_timestamp = 0; vcpu-arch.last_guest_tsc = data; /* Keep track of which generation this VCPU has synchronized to */ -- 1.7.1 Reviewed-by: Marcelo Tosatti mtosa...@redhat.com

Re: [RFC PATCH v3 2/2] add support for Hyper-V partition reference time enlightenment

2014-01-14 Thread Marcelo Tosatti
On Mon, Jan 13, 2014 at 11:11:40PM -0500, Vadim Rozenfeld wrote: - Original Message - From: Marcelo Tosatti mtosa...@redhat.com To: Vadim Rozenfeld vroze...@redhat.com Cc: kvm@vger.kernel.org, p...@dlhnet.de, pbonz...@redhat.com Sent: Thursday, December 12, 2013 6:27:00 AM

Re: [RFC PATCH v4 2/2] add support for Hyper-V partition reference time enlightenment

2014-01-14 Thread Marcelo Tosatti
On Tue, Jan 14, 2014 at 08:22:17PM +1100, Vadim Rozenfeld wrote: The following patch allows to activate a partition reference time enlightenment that is based on the host platform's support for an Invariant Time Stamp Counter (iTSC). v2 - v3 Handle TSC sequence, scale, and offest

Re: [RFC PATCH v4 2/2] add support for Hyper-V partition reference time enlightenment

2014-01-14 Thread Marcelo Tosatti
On Tue, Jan 14, 2014 at 12:03:24PM +0100, Paolo Bonzini wrote: The cleanup between v3 and v4 is really nice; thanks. What happened to the glitch you reported in the v3 thread. Il 14/01/2014 10:22, Vadim Rozenfeld ha scritto: + tsc_ref.tsc_scale = ((1LL 32) / +

Re: [PATCH] kvm: x86: Fix debug typo error in lapic

2014-01-12 Thread Marcelo Tosatti
On Thu, Jan 09, 2014 at 03:08:25PM -0500, Hu Yaohui wrote: Hi Marcelo, Thanks for your replying! I hope you have a good day! I am sorry that it's not that obvious to me after I checked that function. If the remote vcpu is not in the same pcpu as the sender which calls kvm_vpcu_kick. Before

Re: [PATCH] kvm: x86: Fix debug typo error in lapic

2014-01-09 Thread Marcelo Tosatti
On Wed, Jan 08, 2014 at 06:35:00PM -0500, Hu Yaohui wrote: Thanks a lot Marcelo! On Wed, Jan 8, 2014 at 6:25 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Wed, Jan 08, 2014 at 06:14:15PM -0500, Hu Yaohui wrote: Hi guys, I think you should be pretty familiar with lapic. I would really

Re: [PATCH] Check use I/O bitmap first before unconditional I/O exit

2014-01-08 Thread Marcelo Tosatti
On Mon, Dec 30, 2013 at 03:56:29PM -0500, Zhihui Zhang wrote: According to Table C-1 of Intel SDM 3C, a VM exit happens on an I/O instruction when use I/O bitmaps VM-execution control was 0 _and_ the unconditional I/O exiting VM-execution control was 1. So we can't just check unconditional

Re: [PATCH kvm-next 1/2] kvm: make local functions static

2014-01-08 Thread Marcelo Tosatti
On Sun, Dec 29, 2013 at 12:12:29PM -0800, Stephen Hemminger wrote: Running 'make namespacecheck' found lots of functions that should be declared static, since only used in one file. Signed-off-by: Stephen Hemminger step...@networkplumber.org Applied both, thanks. -- To unsubscribe from this

<    1   2   3   4   5   6   7   8   9   10   >