Re: [PATCH 0/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net

2009-11-23 Thread Mark McLoughlin
On Mon, 2009-11-23 at 11:23 +1030, Rusty Russell wrote: I'd like to drop big packet support from our driver, but I don't know how many kvm hosts will not offer mergable rx bufs yet. Anthony? Mergeable rx bufs were first added in kvm-80 and qemu-0.10.0 So e.g., it's in Fedora since Fedora 11

Re: [PULL REQUEST] merge latest upstream qemu networking bits

2009-11-02 Thread Mark McLoughlin
On Mon, 2009-11-02 at 12:36 +0200, Avi Kivity wrote: On 10/28/2009 04:19 PM, Mark McLoughlin wrote: The most notable thing here is that all our networking changes are now upstream - i.e. there are no longer qemu-kvm specific changes to net.[ch], net-queue.[ch], savevm.c and hw/virtio-net.c

Re: [PATCH] whitelist host virtio networking features [was Re: qemu-kvm-0.11 regression, crashes on older ...]

2009-11-02 Thread Mark McLoughlin
On Fri, 2009-10-30 at 16:15 -0500, Dustin Kirkland wrote: On Thu, Oct 29, 2009 at 10:34 AM, Dustin Kirkland kirkl...@canonical.com wrote: whitelist host virtio networking features This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb, fixing crashes when guests with 2.6.25

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
Hi Dustin, On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: I believe that we have identified a regression in qemu-kvm-0.11.0. Regression versus which previous version of qemu-kvm? The kvm process crashes for older guests with virtio networking, when the guest's incoming network

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote: Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: Assuming this is something like the virtio-net in 2.6.26, there was no receivable buffers support so (as Scott points out) it must be that we've read a packet from

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script. virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote: On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote: In the mean time, Hardy's kernel is in git here: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary I'll save you a few clicks...

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote: On Thu, 2009-10-29 at 14:48 +, Mark McLoughlin wrote: Ah, it all makes sense now. I was getting confused between HOST_* and GUEST_* this should have been: features |= (1 VIRTIO_NET_F_MAC); features |= (1

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote: On Thu, 2009-10-29 at 15:01 +, Mark McLoughlin wrote: Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct Brilliant! Works like a champ. I'll send a patch in a subsequent email. Would you add a signed-off

[PULL REQUEST] merge latest upstream qemu networking bits

2009-10-28 Thread Mark McLoughlin
monitor: Convert do_migrate_cancel() to QObject monitor: Convert do_pci_device_hot_remove() to QObject monitor: Convert do_eject() to QObject monitor: Convert do_getfd() to QObject monitor: Convert do_closefd() to QObject Mark McLoughlin (59): net: remove unused

Re: [Qemu-devel] net packet storms with multiple NICs

2009-10-23 Thread Mark McLoughlin
On Fri, 2009-10-23 at 20:25 +0400, Michael Tokarev wrote: I've two questions: o what's the intended usage of all-vlan-equal case, when kvm (or qemu) reflects packets from one interface to another? It's what bridge in linux is for, I think. I don't think it's necessarily an intended

Re: Raw vs. tap (was: Re: [Qemu-devel] Re: Release plan for 0.12.0)

2009-10-15 Thread Mark McLoughlin
On Wed, 2009-10-14 at 17:53 -0500, Anthony Liguori wrote: So at this point, I think it's a mistake to include raw socket support. If the goal is to improve networking usability such that it just works as a root user, let's incorporate a default network script that creates a bridge or

Re: Add qemu_send_raw() to vlan.

2009-10-15 Thread Mark McLoughlin
Hi Gleb, On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: It gets packet without virtio header and adds it if needed. Allows to inject packets to vlan from outside. To send gracious arp for instance. ... diff --git a/net.h b/net.h index 931133b..3d0b6f2 100644 --- a/net.h +++ b/net.h

Re: Add qemu_send_raw() to vlan.

2009-10-15 Thread Mark McLoughlin
On Thu, 2009-10-15 at 09:33 +0200, Gleb Natapov wrote: On Thu, Oct 15, 2009 at 08:04:45AM +0100, Mark McLoughlin wrote: Hi Gleb, On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: It gets packet without virtio header and adds it if needed. Allows to inject packets to vlan from

Re: QemuOpts changes breaks multiple nic options

2009-10-13 Thread Mark McLoughlin
Hi Tom, On Mon, 2009-10-12 at 17:05 -0500, Tom Lendacky wrote: The recent change to QemuOpts for the -net nic option breaks specifying -net nic,... more than once. The net_init_nic function's return value in net.c is a table index, which is non-zero after the first time it is called. The

Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices

2009-10-09 Thread Mark McLoughlin
On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote: On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote: On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: linux 2.6.32 includes UDP fragmentation offload support in software. So we can enable UFO on the host tap

Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices

2009-10-08 Thread Mark McLoughlin
On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: linux 2.6.32 includes UDP fragmentation offload support in software. So we can enable UFO on the host tap device if supported and allow setting UFO on virtio-net in the guest. Hmm, we really need to detect whether the host has tuntap

Re: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Mark McLoughlin
On Wed, 2009-09-30 at 21:15 +0200, Gerd Hoffmann wrote: On 09/30/09 15:59, Mark McLoughlin wrote: I'm planning on adding -hostnet and -nic arguments, which would not use vlans by default but rather connect the nic directly to the host side. No new -nic argument please. We should just

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-10-01 Thread Mark McLoughlin
On Thu, 2009-10-01 at 18:49 +0200, Avi Kivity wrote: On 09/30/2009 03:59 PM, Mark McLoughlin wrote: I think we should keep the vlan stuff, just de-emphasise it. Maybe we should do what X.org does, break it silently and remove it some time later when no one complains. Well

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 08:24 -0300, Glauber Costa wrote: On Wed, Sep 30, 2009 at 08:24:18AM +0200, Avi Kivity wrote: On 09/29/2009 10:45 PM, Mark McLoughlin wrote: On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-30 Thread Mark McLoughlin
On Wed, 2009-09-30 at 15:55 +0200, Avi Kivity wrote: On 09/30/2009 03:51 PM, Christoph Hellwig wrote: I might sound like a broken record, but why isn't the full GSO support for virtio-net upstream in qemu? IIRC the current hacks are not upstream quality. The problem (again IIRC)

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-29 Thread Mark McLoughlin
On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream qemu.git, but it needs to be re-instated in qemu-kvm.git

Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-09-29 Thread Mark McLoughlin
On Tue, 2009-09-29 at 21:45 +0100, Mark McLoughlin wrote: On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote: This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream

Re: [PATCH] qemu-kvm: fix error handling in msix vector add

2009-09-07 Thread Mark McLoughlin
On Sat, 2009-07-25 at 12:30 -0300, Marcelo Tosatti wrote: On Thu, Jul 23, 2009 at 04:34:13PM +0300, Michael S. Tsirkin wrote: When adding a vector fails, the used counter should not be incremented, otherwise on vector change we will try to update the routing entry. Signed-off-by:

Re: [PATCH] qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back to non-accelerated mode

2009-09-04 Thread Mark McLoughlin
On Thu, 2009-09-03 at 19:18 -0300, Glauber Costa wrote: On Thu, Sep 3, 2009 at 6:48 PM, Dustin Kirklandkirkl...@canonical.com wrote: On Thu, Sep 3, 2009 at 3:01 PM, Mark McLoughlinmar...@redhat.com wrote: On Thu, 2009-09-03 at 12:31 -0500, Dustin Kirkland wrote: qemu-kvm: fix segfault when

Re: [PATCH] qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back to non-accelerated mode

2009-09-03 Thread Mark McLoughlin
On Thu, 2009-09-03 at 12:31 -0500, Dustin Kirkland wrote: qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back to non-accelerated mode We're seeing segfaults on systems without access to /dev/kvm. It looks like the global kvm_allowed is being set just a little too late in

Re: [PATCHv3 3/4] qemu-kvm: vhost-net implementation

2009-08-20 Thread Mark McLoughlin
Hi Michael, Some random high-level comments: - I had expected this to be available as: -net raw,ifname=eth2 -net nic,model=virtio I'd prefer it this way, because it means you can use this mode even without vhost and it's ties in better with the way all other qemu

Re: [PATCH]: Always use KVM_VERSION to build version number

2009-08-10 Thread Mark McLoughlin
On Sun, 2009-08-09 at 12:58 +0300, Avi Kivity wrote: On 08/07/2009 03:31 PM, Chris Lalancette wrote: Avi, Trying to use libvirt with development snapshots of qemu-kvm is a bit problematic. The trouble is that for all development snapshots, the value that gets placed into this

[PATCH] configure: make default KVM_VERSION qemu-kvm-devel

2009-08-10 Thread Mark McLoughlin
, 87 etc.) and just uses the 'qemu-kvm-' string to detect that this is the kvm fork of qemu. The actual kvm snapshot number is no longer important, it's the qemu version number which is important. Signed-off-by: Mark McLoughlin mar...@redhat.com --- configure |2 +- 1 files changed, 1

Re: [PATCH]: Always use KVM_VERSION to build version number

2009-08-10 Thread Mark McLoughlin
On Mon, 2009-08-10 at 12:46 +0300, Avi Kivity wrote: On 08/10/2009 12:19 PM, Mark McLoughlin wrote: Or we could drop this kvm snapshot numbering system and just use qemu VERSION numbering - i.e. qemu-kvm-devel-88 could have been published as qemu-kvm-0.10.50 Yeah. You still

[PATCH 1/1] net: fix vnet_hdr bustage with slirp

2009-08-07 Thread Mark McLoughlin
-0.11 too] Signed-off-by: Mark McLoughlin mar...@redhat.com --- net.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index c7702f8..2428f63 100644 --- a/net.c +++ b/net.c @@ -1521,6 +1521,9 @@ int tap_has_vnet_hdr(void *opaque) VLANClientState *vc

Re: [PATCH 1/1] net: fix vnet_hdr bustage with slirp

2009-08-07 Thread Mark McLoughlin
On Fri, 2009-08-07 at 13:51 +0200, Arnd Bergmann wrote: On Friday 07 August 2009, Mark McLoughlin wrote: slirp has started using VLANClientState::opaque and this has caused the kvm specific tap_has_vnet_hdr() hack to break because we blindly use this opaque pointer even if it is not a tap

Re: Fix migration issue when the destination is loaded

2009-07-16 Thread Mark McLoughlin
Hi Dor, On Wed, 2009-07-15 at 18:03 +0300, Dor Laor wrote: If the migration socket is full, we get EAGAIN for the write. The set_fd_handler2 defers the write for later on. The function tries to wake up the iothread by qemu_kvm_notify_work. Since this happens in a loop, multiple times, the

Re: Fix migration issue when the destination is loaded

2009-07-16 Thread Mark McLoughlin
On Thu, 2009-07-16 at 15:00 +0300, Dor Laor wrote: On 07/16/2009 12:39 PM, Mark McLoughlin wrote: Hi Dor, On Wed, 2009-07-15 at 18:03 +0300, Dor Laor wrote: If the migration socket is full, we get EAGAIN for the write. The set_fd_handler2 defers the write for later on. The function

Re: [Qemu-devel] Planning for the 0.11.0 release

2009-07-09 Thread Mark McLoughlin
Hi Anthony, On Mon, 2009-06-22 at 18:57 -0500, Anthony Liguori wrote: Hi, It's getting to be about the time to start thinking about the 0.11.0 release. 0.10.0 was released on March 2nd so following with the 6 month release cycle, that would put 0.11.0 at September 2nd. Based on the

[PATCH] net: re-instate some lost vnet_hdr code

2009-07-08 Thread Mark McLoughlin
/?func=detailatid=893831aid=2817367group_id=180599 Network doesn't work anymore switching from kvm-86 to kvm-87 Signed-off-by: Mark McLoughlin mar...@redhat.com --- net.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index ac06ea1..19e00e0

Re: slow guest performance with build load, looking for ideas

2009-07-03 Thread Mark McLoughlin
On Thu, 2009-07-02 at 12:41 +0300, Avi Kivity wrote: On 07/02/2009 08:48 AM, Avi Kivity wrote: HOST time (make -j12 make -j12 modules) with no guest running real6m50.936s user29m12.051s sys5m50.867s 35

[PATCH] Fix pcspk build with kvm disabled

2009-06-29 Thread Mark McLoughlin
to function ‘kvm_get_pit_ch2’ hw/pcspk.c:185: error: too many arguments to function ‘kvm_set_pit_ch2’ hw/pcspk.c:171: warning: unused variable ‘inkernel_state’ Signed-off-by: Mark McLoughlin mar...@redhat.com Cc: Jan Kiszka jan.kis...@web.de --- hw/pcspk.c |6 +- 1 files changed, 5

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-17 Thread Mark McLoughlin
On Tue, 2009-06-16 at 19:44 +0100, Jamie Lokier wrote: Mark McLoughlin wrote: Worst case we hardcode those numbers (gasp, faint). Maybe we can just add the open slots to the -help output. That'd be nice and clean. I was being sarcastic - libvirt currently must parse qemu -help

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-17 Thread Mark McLoughlin
On Wed, 2009-06-17 at 12:03 +0300, Avi Kivity wrote: On 06/17/2009 11:33 AM, Mark McLoughlin wrote: I particularly don't like the idea of arcane machine-dependent slot allocation knowledge living in libvirt, because it needs to be in Qemu anyway for non-libvirt users. No point in having

Re: a few words about drive/pci add/remove

2009-06-17 Thread Mark McLoughlin
On Wed, 2009-06-17 at 17:44 +0400, Michael Tokarev wrote: WARNING: at drivers/base/core.c:122 device_release+0x5f/0x70() Device 'virtio8' does not have a release() function, it is broken and must be fixed. This should be fixed in 2.6.29 Cheers, Mark. -- To unsubscribe from this list: send

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-16 Thread Mark McLoughlin
On Mon, 2009-06-15 at 13:12 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: So long as the restrictions would be known to the management app via some what slots are available mechanism in qemu, that sounds fine. I'm not sure a what slots are available mechanism is as straight

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-16 Thread Mark McLoughlin
On Tue, 2009-06-16 at 15:28 +0300, Avi Kivity wrote: On 06/16/2009 03:14 PM, Mark McLoughlin wrote: On Mon, 2009-06-15 at 13:12 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: So long as the restrictions would be known to the management app via some what slots

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Sun, 2009-06-14 at 12:34 +0300, Michael S. Tsirkin wrote: On Fri, Jun 12, 2009 at 04:53:27PM +0100, Mark McLoughlin wrote: The other obvious piece to add to it would be PCI addresses, so that even if you remove a device, the addresses assigned to existing devices don't change. Could

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Sun, 2009-06-14 at 12:50 +0300, Michael S. Tsirkin wrote: On Fri, Jun 12, 2009 at 05:48:23PM +0100, Mark McLoughlin wrote: However, in order to retain compat for that SCSI device (e.g. ensuring the PCI address doesn't change as other devices are added an removed), we're back to the same

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Sun, 2009-06-14 at 10:58 +0300, Avi Kivity wrote: Mark McLoughlin wrote: I think the point is that you don't need version numbers if you have a proper device tree. How do you add a new attribute to the device tree and, when a supplied device tree lacking said

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Mon, 2009-06-15 at 07:48 -0500, Anthony Liguori wrote: Avi Kivity wrote: On 06/15/2009 12:09 PM, Mark McLoughlin wrote: I think the point is that you don't need version numbers if you have a proper device tree. How do you add a new attribute to the device tree

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Mon, 2009-06-15 at 18:12 +0300, Dor Laor wrote: It doesn't want to. As Mark said, libvirt just wants to be able to ensure a stable guest ABI, of which stable PCI addresses is one aspect. This does not imply libvirt wants to allocate the PCI addresses, just that it wants a way to keep

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-15 Thread Mark McLoughlin
On Mon, 2009-06-15 at 18:05 +0300, Avi Kivity wrote: On 06/15/2009 05:24 PM, Anthony Liguori wrote: Dor Laor wrote: Libvirt does not support r2d. I hope it won't start to support it. It supports mips, sparc, and ppc machines now. I don't see why it wouldn't support r2d. For ppcemb, I

Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: Michael S. Tsirkin wrote: I think the right long term answer to all this is a way to get QEMU to dump it's current machine configuration in glorious detail as a file which can be reloaded as a machine configuration. And then

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 16:59 +0300, Michael S. Tsirkin wrote: On Fri, Jun 12, 2009 at 09:43:29AM +0100, Mark McLoughlin wrote: = Solution - Separate configuration from compat hints = As I suggested before: - Allow the VM manager to dump compat hints; this would be an opaque

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 09:51 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: Michael S. Tsirkin wrote: I think the right long term answer to all this is a way to get QEMU to dump it's current machine configuration

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 09:55 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: = Solution - Separate configuration from compat hints = As I suggested before: - Allow the VM manager to dump compat hints; this would

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 11:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Fri, 2009-06-12 at 09:51 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: Michael S. Tsirkin wrote

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 11:12 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Fri, 2009-06-12 at 09:55 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: On Wed, 2009-06-10 at 20:27 +0100, Jamie Lokier wrote: = Solution - Separate configuration from compat hints

Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

2009-06-12 Thread Mark McLoughlin
On Fri, 2009-06-12 at 20:44 +0300, Blue Swirl wrote: If the device has different behavior or different properties from guest perspective compared to the old device, it should get a new device type so that you could specify in the device tree either the old device or the new one. Yes, that

[GIT PULL] Merge latest qemu.git

2009-06-11 Thread Mark McLoughlin
: Introduce get_command_name() Fix defined but not used warning Mark McLoughlin (22): Revert Fix output of uninitialized strings net: fix error reporting for some net parameter checks net: factor tap_read_packet() out of tap_send() net: move the tap buffer into TAPState

Re: Network throughput limits for local VM - VM communication

2009-06-09 Thread Mark McLoughlin
On Tue, 2009-06-09 at 11:06 +, Fischer, Anna wrote: I am testing network throughput between two guests residing on the same physical machine. I use a bridge to pass packets between those guests and the virtio NIC model. I am wondering why the throughput only goes up to about 970Mbps.

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-06-04 Thread Mark McLoughlin
Hi Greg, On Wed, 2009-06-03 at 18:04 -0400, Gregory Haskins wrote: Hi Mark, So with the v5 release of iosignalfd, we now have the notion of a trigger, the API of which is as follows: --- /*! * \brief Assign an eventfd to an IO port (PIO or MMIO) * * Assigns an

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-05-28 Thread Mark McLoughlin
On Wed, 2009-05-27 at 16:45 -0400, Gregory Haskins wrote: Mark McLoughlin wrote: The virtio ABI is fixed, so we couldn't e.g. have the guest use a cookie to identify a queue - it's just going to continue using a per-device queue number. Actually, I was originally thinking this would

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-05-27 Thread Mark McLoughlin
On Wed, 2009-05-27 at 15:11 +0300, Avi Kivity wrote: Multiple cookies on the same address are required by virtio. You can't mux since the data doesn't go anywhere. Virtio can survive by checking all rings on a notify, and we can later add a mechanism that has a distinct address for each

Re: [KVM PATCH v4 3/3] kvm: add iosignalfd support

2009-05-27 Thread Mark McLoughlin
On Wed, 2009-05-27 at 13:40 -0400, Gregory Haskins wrote: Mark McLoughlin wrote: On Wed, 2009-05-27 at 15:11 +0300, Avi Kivity wrote: Multiple cookies on the same address are required by virtio. You can't mux since the data doesn't go anywhere. Virtio can survive by checking

Re: Add qemu_send_raw() to vlan.

2009-05-26 Thread Mark McLoughlin
On Tue, 2009-05-26 at 13:11 +0300, Avi Kivity wrote: Gleb Natapov wrote: On Tue, May 26, 2009 at 01:05:35PM +0300, Avi Kivity wrote: Gleb Natapov wrote: It gets packet without virtio header and adds it if needed. Allows to inject packets to vlan from outside. To send gracious

Re: Add qemu_send_raw() to vlan.

2009-05-26 Thread Mark McLoughlin
On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: It gets packet without virtio header and adds it if needed. Allows to inject packets to vlan from outside. To send gracious arp for instance. Acked-by: Mark McLoughlin mar...@redhat.com This isn't ideal, but neither is the current

Re: 64bit guest thinks it is 32bit in kvm-86 - Intel only

2009-05-25 Thread Mark McLoughlin
On Sun, 2009-05-24 at 19:45 -0700, Josh Wilsdon wrote: the kernel refuses to boot with the error message: This kernel requires an x86-64 CPU, but only detected an i686 CPU. Unable to boot - please use a kernel appropriate for your CPU. This should fix it:

Re: Guest OS cannot detect keystrokes/mouse clicks after system_reset

2009-05-20 Thread Mark McLoughlin
On Wed, 2009-05-20 at 15:25 +0530, Sachin Sant wrote: I used system_reset command from QEMU prompt with a SLES 11 Guest. After a reset the guest came up fine with the exception that neither key strokes nor mouse click worked. Host OS Info : CPU Model : Intel(R) Xeon(R) CPU

Re: [PATCH 11/17] net: drop packet from tap device if all NICs are down

2009-05-19 Thread Mark McLoughlin
On Sun, 2009-05-17 at 10:43 -0500, Anthony Liguori wrote: From: Mark McLoughlin mar...@redhat.com If you do e.g. set_link virtio.0 down and there are packets pending on the tap interface, we currently buffer a packet and constantly try and send it until the link is up again. We actually

[PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

2009-05-13 Thread Mark McLoughlin
Currently we only include $(KERNELDIR)/include in CFLAGS, but we also have $(KERNELDIR)/arch/$(arch)/include or else we'll get mis-matched headers. Signed-off-by: Mark McLoughlin mar...@redhat.com --- kvm/user/config-i386.mak |1 - kvm/user/config-ia64.mak |1 + kvm/user

[PATCH] Work around supported cpuid ioctl() brokenness

2009-05-12 Thread Mark McLoughlin
KVM_GET_SUPPORTED_CPUID has been known to fail to return -E2BIG when it runs out of entries. Detect this by always trying again with a bigger table if the ioctl() fills the table. Signed-off-by: Mark McLoughlin mar...@redhat.com --- kvm/libkvm/libkvm-x86.c |2 ++ 1 files changed, 2

Re: [Qemu-devel] [PATCH 4/4] kvm: Trim cpu features not supported by kvm

2009-05-12 Thread Mark McLoughlin
On Sun, 2009-05-03 at 17:04 +0300, Avi Kivity wrote: Remove cpu features that are not supported by kvm from the cpuid features reported to the guest. Signed-off-by: Avi Kivity a...@redhat.com @@ -1699,5 +1714,20 @@ CPUX86State *cpu_x86_init(const char *cpu_model)

[PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream

2009-05-05 Thread Mark McLoughlin
This commit: commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01 Subject: Remove stray GSO code from virtio_net (Mark McLoughlin) Removed some GSO code from upstream qemu.git, but it needs to be re-instated in qemu-kvm.git. Reported-by: Sridhar Samudrala s...@us.ibm.com Signed-off-by: Mark

Re: [kvm] virtio-net not working with the latest qemu-kvm git

2009-05-05 Thread Mark McLoughlin
in promiscuos mode by running tcpdump in background on the guest. After browsing through the recent patches, i found that the following commit is causing the regression. Remove stray GSO code from virtio_net (Mark McLoughlin) http://git.kernel.org/?p=virt/kvm/qemu-kvm.git

[PATCH] kvm: qemu: net: unbreak tap networking

2009-04-28 Thread Mark McLoughlin
to have been queued up during the delivery of the original packet. Signed-off-by: Mark McLoughlin mar...@redhat.com --- net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net.c b/net.c index 16f6e48..b5ebcea 100644 --- a/net.c +++ b/net.c @@ -445,9 +445,9 @@ int

Re: [PATCH] kvm: qemu: net: unbreak tap networking

2009-04-28 Thread Mark McLoughlin
On Tue, 2009-04-28 at 11:58 +0300, Avi Kivity wrote: Mark McLoughlin wrote: A recent merge broke tap networking because qemu_send_packet() now always returns -EAGAIN causing tap to try and resend the same packet forever. Fix by having qemu_send_packet() return the status from

[PATCH] kvm: qemu: framebuffer: build fix for target-arm

2009-04-27 Thread Mark McLoughlin
: warning: implicit declaration of function 'kvm_physical_sync_dirty_bitmap' Signed-off-by: Mark McLoughlin mar...@redhat.com --- hw/framebuffer.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/framebuffer.c b/hw/framebuffer.c index 1086ba9..e2d7604 100644 --- a/hw

Re: [ANNOUNCE] kvm-85 release

2009-04-27 Thread Mark McLoughlin
Hi Avi, On Tue, 2009-04-21 at 12:32 +0300, Avi Kivity wrote: Again a long delayed release; I'll try to reduce the lag between releases. kvm-85 comes in two flavors: the traditional kernel+qemu package (kvm-85.tar.gz), as well as separate qemu (qemu-kvm-devel-85.tar.gz) I packaged this

Re: [ANNOUNCE] kvm-85 release

2009-04-27 Thread Mark McLoughlin
On Mon, 2009-04-27 at 10:50 -0400, Christoph Hellwig wrote: On Mon, Apr 27, 2009 at 04:45:23PM +0200, Alexander Graf wrote: - Disabled pwritev() support until glibc stops writing random junk. See https://bugzilla.redhat.com/497429 Wouldn't it be useful to have it disabled upstream

Re: virtio net regression

2009-04-20 Thread Mark McLoughlin
On Sun, 2009-04-19 at 14:48 +0300, Avi Kivity wrote: Antoine Martin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Wireshark was showing a huge amount of invalid packets (wrong checksum) - - that was the cause of the slowdown. Simply rebooting the host into 2.6.28.9 fixed

Re: kvm-84 + virtio Ubuntu Hardy guests

2009-04-06 Thread Mark McLoughlin
On Mon, 2009-04-06 at 09:55 -0700, Dustin Kirkland wrote: On Tue, Mar 31, 2009 at 5:28 PM, Dustin Kirkland kirkl...@canonical.com wrote: I'm receiving a heavy volume of Ubuntu Jaunty Beta users reporting that Jaunty hosts running kvm-84 (userspace and kernel) are not able to boot

[PATCH 0/4] fix header-sync using --with-patched-kernel

2009-03-27 Thread Mark McLoughlin
Hi Avi, Here are a few fairly trivial build patches - they fix building kvm.git using --with-patched-kernel alongside an unconfigured kvm.git tree. Cheers, Mark. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

[PATCH 4/4] kvm: configure: --with-patched-kernel doesn't need kernelversion

2009-03-27 Thread Mark McLoughlin
DEPMOD_VERSION is only used for kvm.ko, not for e.g. header-sync. Signed-off-by: Mark McLoughlin mar...@redhat.com --- kernel/configure |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/configure b/kernel/configure index 3fd0c94..7a222e4 100755 --- a/kernel

[PATCH 3/4] kvm: configure: pass --with-patched-kernel to kernel/configure

2009-03-27 Thread Mark McLoughlin
We need to know this so that we can avoid doing things that are specific to building kvm.ko - e.g. when we are only doing header-sync. Signed-off-by: Mark McLoughlin mar...@redhat.com --- configure|1 + kernel/configure |4 2 files changed, 5 insertions(+), 0 deletions

[PATCH 1/4] kvm: configure: remove unused depmod_version

2009-03-27 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin mar...@redhat.com --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index b9419c0..a2aad59 100755 --- a/configure +++ b/configure @@ -16,7 +16,6 @@ arch=`uname -m` target_exec= # don't use uname

[PATCH 2/4] kvm: configure: run kernel configure even with --with-patched-kernel

2009-03-27 Thread Mark McLoughlin
We still run header-sync in this case, which requires configure to have been run. Signed-off-by: Mark McLoughlin mar...@redhat.com --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index a2aad59..49c4419 100755 --- a/configure +++ b

Re: [PATCH 5/6] kvm: qemu: deassign device from guest

2009-02-13 Thread Mark McLoughlin
On Fri, 2009-02-13 at 14:58 +0800, Han, Weidong wrote: +static void deassign_device(AssignedDevInfo *adev) +{ +struct kvm_assigned_pci_dev assigned_dev_data; +AssignedDevice *dev = adev-assigned_dev; +int r; + +memset(assigned_dev_data, 0, sizeof(assigned_dev_data)); +

KVM PCI device assignment issues

2009-02-13 Thread Mark McLoughlin
Hi, KVM has support for PCI device assignment using VT-d and AMD IOMMU, but there are a number of inter-related issues that need some further discussion: - Unbinding devices from any existing device driver before assignment - Resetting devices before and after assignment - Helping users

Re: KVM PCI device assignment issues

2009-02-13 Thread Mark McLoughlin
On Fri, 2009-02-13 at 08:56 -0800, Greg KH wrote: On Fri, Feb 13, 2009 at 04:32:47PM +, Mark McLoughlin wrote: Driver Unbinding Before a device is assigned to a guest, we should make sure that no host device driver is currently bound to the device. We can do

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-12 Thread Mark McLoughlin
On Thu, 2009-02-12 at 12:02 +0200, Avi Kivity wrote: Marcelo Tosatti wrote: On Wed, Feb 11, 2009 at 08:08:23PM +, Mark McLoughlin wrote: On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: Marcelo Tosatti wrote: This is better. Currently, this code path

Re: [PATCH 1/4] kvm: define KVM_CAP_DEVICE_DEASSIGNMENT

2009-02-11 Thread Mark McLoughlin
, \ struct kvm_assigned_irq) #define KVM_REINJECT_CONTROL _IO(KVMIO, 0x71) +#define KVM_DEASSIGN_PCI_DEVICE _IOR(KVMIO, 0x72, \ + struct kvm_assigned_pci_dev) Looks good to me, but I wonder why we never used 0x6b-0x6f? Acked-by: Mark McLoughlin mar

Re: [PATCH 2/4] kvm: change a loglevel in kvm_vm_ioctl_deassign_device

2009-02-11 Thread Mark McLoughlin
On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote: change from KERN_INFO to KERN_WARNING to prompt users when deassign an unassigned device Signed-off-by: Weidong Han weidong@intel.com --- virt/kvm/kvm_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH 3/4] kvm: libkvm: add deassign ioctl

2009-02-11 Thread Mark McLoughlin
On Tue, 2009-02-10 at 20:40 +0800, Han, Weidong wrote: add this ioctl to deassign a device from guest Signed-off-by: Weidong Han weidong@intel.com Looks fine. Acked-by: Mark McLoughlin mar...@redhat.com Cheers, Mark. -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH 4/4] kvm: qemu: fix hot remove device

2009-02-11 Thread Mark McLoughlin
Hi Weidong, In general, this looks like a good cleanup. With deassign_device() fixed to only require assigned_dev_id, I would be happy to ACK this whole patch. However, it would be much, much easier to review the patch if you had split it into multiple patches e.g. 1) Make

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Mark McLoughlin
Hi Alex, Just had a quick looked over these and they seem pretty good, but some broad comments: - The logic around is this a NIC+TAP pair? would be good to have a better API around. We need this to merge virtio GSO support too. Anthony had some ideas here. - I think you could keep

Re: kvm process exit on virtio error

2009-02-11 Thread Mark McLoughlin
Hi, On Wed, 2009-02-11 at 12:41 +0100, Phil Ten wrote: Hello, My kvm processes are exiting on what I think are VIRTIO errors: Guest moved used index from 24543 to 24606 This is very strange. The code in question is: static int virtqueue_num_heads(VirtQueue *vq, unsigned int idx) {

Re: KVM: x86: disable kvmclock on non constant TSC hosts

2009-02-11 Thread Mark McLoughlin
On Wed, 2009-02-11 at 14:01 +0200, Avi Kivity wrote: Marcelo Tosatti wrote: This is better. Currently, this code path is posing us big troubles, and we won't have a decent patch in time. So, temporarily disable it. Applied to master and kvm-updates/2.6.29, thanks. Should we

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Mark McLoughlin
On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote: - What do we need rxfilter=on|off on the command line for? Primarily because the current tun driver in Linux has a bug that it can drop unicast packets requested to be included in the filter if it overflows the exact match table.

Re: [PATCH] Fix warnings in virtio-net

2009-02-09 Thread Mark McLoughlin
On Mon, 2009-02-09 at 10:17 +0100, Jan Kiszka wrote: Those void returns are bogus, but there is no need to check for allocation failures anyway. Looks good: Acked-by: Mark McLoughlin mar...@redhat.com but should be re-done as a patch against qemu and sent to qemu-devel. Thanks, Mark

Re: 2.6.29-rc3 oops with kvmclock

2009-02-09 Thread Mark McLoughlin
On Sun, 2009-02-08 at 04:02 -0200, Marcelo Tosatti wrote: invalid opcode: [#1] SMP DEBUG_PAGEALLOC The FC11 kernel has pvmmu on. It _could_ be a weird side effect of the pvmmu slab bug (which only happens with DEBUG_PAGEALLOC). What were you doing when this happened? Reproducible? I

Re: [PATCH 1/3] [RESEND] kvm: qemu: remove the useless parameter

2009-02-06 Thread Mark McLoughlin
weidong@intel.com Acked-by: Mark McLoughlin mar...@redhat.com Cheers, Mark. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   3   4   >