Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-07 Thread Michael Wolf
On Thu, 2013-03-07 at 14:11 +1100, Paul Mackerras wrote: On Wed, Mar 06, 2013 at 09:52:16PM -0300, Marcelo Tosatti wrote: On Wed, Mar 06, 2013 at 10:29:12AM -0600, Michael Wolf wrote: I looked at doing that once but was told that I was changing the interface in an unacceptable way

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-07 Thread Michael Wolf
On Wed, 2013-03-06 at 23:30 -0300, Marcelo Tosatti wrote: On Wed, Mar 06, 2013 at 10:27:13AM -0600, Michael Wolf wrote: On Tue, 2013-03-05 at 22:41 -0300, Marcelo Tosatti wrote: On Tue, Mar 05, 2013 at 02:22:08PM -0600, Michael Wolf wrote: Sorry for the delay in the response. I did

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-07 Thread Michael Wolf
On Wed, 2013-03-06 at 23:30 -0300, Marcelo Tosatti wrote: On Wed, Mar 06, 2013 at 10:27:13AM -0600, Michael Wolf wrote: On Tue, 2013-03-05 at 22:41 -0300, Marcelo Tosatti wrote: On Tue, Mar 05, 2013 at 02:22:08PM -0600, Michael Wolf wrote: Sorry for the delay in the response. I did

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-07 Thread Michael Wolf
On Thu, 2013-03-07 at 18:25 -0300, Marcelo Tosatti wrote: On Thu, Mar 07, 2013 at 03:15:09PM -0600, Michael Wolf wrote: Makes sense? Not sure what the concrete way to report stolen time relative to hard capping is (probably easier inside the scheduler, where run_delay

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-06 Thread Michael Wolf
On Tue, 2013-03-05 at 22:41 -0300, Marcelo Tosatti wrote: On Tue, Mar 05, 2013 at 02:22:08PM -0600, Michael Wolf wrote: Sorry for the delay in the response. I did not see the email right away. On Mon, 2013-02-18 at 22:11 -0300, Marcelo Tosatti wrote: On Mon, Feb 18, 2013 at 05:43

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-06 Thread Michael Wolf
On Wed, 2013-03-06 at 12:13 +0400, Glauber Costa wrote: On 03/06/2013 05:41 AM, Marcelo Tosatti wrote: On Tue, Mar 05, 2013 at 02:22:08PM -0600, Michael Wolf wrote: Sorry for the delay in the response. I did not see the email right away. On Mon, 2013-02-18 at 22:11 -0300, Marcelo

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-06 Thread Michael Wolf
On Wed, 2013-03-06 at 14:34 +0100, Frederic Weisbecker wrote: 2013/3/5 Michael Wolf m...@linux.vnet.ibm.com: Sorry for the delay in the response. I did not see the email right away. On Mon, 2013-02-18 at 22:11 -0300, Marcelo Tosatti wrote: On Mon, Feb 18, 2013 at 05:43:47PM +0100

Re: [PATCH 4/4] Add a timer to allow the separation of consigned from steal time.

2013-03-05 Thread Michael Wolf
Sorry for the delay in the response. I did not see your question. On Mon, 2013-02-18 at 20:57 -0300, Marcelo Tosatti wrote: On Tue, Feb 05, 2013 at 03:49:41PM -0600, Michael Wolf wrote: Add a helper routine to scheduler/core.c to allow the kvm module to retrieve the cpu hardlimit settings

Re: [PATCH 0/4] Alter steal-time reporting in the guest

2013-03-05 Thread Michael Wolf
Sorry for the delay in the response. I did not see the email right away. On Mon, 2013-02-18 at 22:11 -0300, Marcelo Tosatti wrote: On Mon, Feb 18, 2013 at 05:43:47PM +0100, Frederic Weisbecker wrote: 2013/2/5 Michael Wolf m...@linux.vnet.ibm.com: In the case of where you have a system

Re: [PATCH 2/4] Expand the steal time msr to also contain the consigned time.

2013-02-07 Thread Michael Wolf
On 02/06/2013 03:14 PM, Rik van Riel wrote: On 02/05/2013 04:49 PM, Michael Wolf wrote: Expand the steal time msr to also contain the consigned time. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/include/asm

Re: [PATCH 3/4] Add the code to send the consigned time from the host to the guest

2013-02-07 Thread Michael Wolf
On 02/06/2013 03:18 PM, Rik van Riel wrote: On 02/05/2013 04:49 PM, Michael Wolf wrote: Change the paravirt calls that retrieve the steal-time information from the host. Add to it getting the consigned value as well as the steal time. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com diff

Re: [PATCH 4/4] Add a timer to allow the separation of consigned from steal time.

2013-02-07 Thread Michael Wolf
On 02/07/2013 02:46 AM, Glauber Costa wrote: On 02/06/2013 10:07 PM, Michael Wolf wrote: On 02/06/2013 08:36 AM, Glauber Costa wrote: On 02/06/2013 01:49 AM, Michael Wolf wrote: Add a helper routine to scheduler/core.c to allow the kvm module to retrieve the cpu hardlimit settings

Re: [PATCH 4/4] Add a timer to allow the separation of consigned from steal time.

2013-02-06 Thread Michael Wolf
On 02/06/2013 08:36 AM, Glauber Costa wrote: On 02/06/2013 01:49 AM, Michael Wolf wrote: Add a helper routine to scheduler/core.c to allow the kvm module to retrieve the cpu hardlimit settings. The values will be used to set up a timer that is used to separate the consigned from the steal time

[PATCH 2/4] Expand the steal time msr to also contain the consigned time.

2013-02-05 Thread Michael Wolf
Expand the steal time msr to also contain the consigned time. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/include/asm/paravirt_types.h |2 +- arch/x86/kernel/kvm.c |7 ++- kernel/sched/core.c

[PATCH 3/4] Add the code to send the consigned time from the host to the guest

2013-02-05 Thread Michael Wolf
Change the paravirt calls that retrieve the steal-time information from the host. Add to it getting the consigned value as well as the steal time. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/include/asm/paravirt.h |4

[PATCH 4/4] Add a timer to allow the separation of consigned from steal time.

2013-02-05 Thread Michael Wolf
Add a helper routine to scheduler/core.c to allow the kvm module to retrieve the cpu hardlimit settings. The values will be used to set up a timer that is used to separate the consigned from the steal time. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/kvm_host.h

[PATCH 0/4] Alter steal-time reporting in the guest

2013-02-05 Thread Michael Wolf
: * Removed the steal time allowed percentage from the guest * Moved the separation of consigned (expected steal) and steal time to the host. * No longer include a sysctl interface. --- Michael Wolf (4): Alter the amount of steal time reported by the guest. Expand the steal time msr

[PATCH 1/4] Alter the amount of steal time reported by the guest.

2013-02-05 Thread Michael Wolf
. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- fs/proc/stat.c |9 +++-- include/linux/kernel_stat.h |1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/proc/stat.c b/fs/proc/stat.c index e296572..cb7fe80 100644 --- a/fs/proc/stat.c +++ b/fs

Re: [PATCH 0/5] Alter steal time reporting in KVM

2012-12-07 Thread Michael Wolf
On 12/05/2012 06:46 AM, Glauber Costa wrote: I am deeply sorry. I was busy first time I read this, so I postponed answering and ended up forgetting. Sorry include/linux/sched.h: unsigned long long run_delay; /* time spent waiting on a runqueue */ So if you are out of the runqueue, you won't

Re: [PATCH 0/5] Alter steal time reporting in KVM

2012-11-29 Thread Michael Wolf
On 11/28/2012 02:55 PM, Glauber Costa wrote: On 11/28/2012 10:43 PM, Michael Wolf wrote: On 11/27/2012 05:24 PM, Marcelo Tosatti wrote: On Mon, Nov 26, 2012 at 02:36:24PM -0600, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment

Re: [PATCH 2/5] Expand the steal time msr to also contain the consigned time.

2012-11-28 Thread Michael Wolf
On 11/27/2012 03:03 PM, Konrad Rzeszutek Wilk wrote: On Mon, Nov 26, 2012 at 02:36:45PM -0600, Michael Wolf wrote: Add a consigned field. This field will hold the time lost due to capping or overcommit. The rest of the time will still show up in the steal-time field. Signed-off-by: Michael

Re: [PATCH 0/5] Alter steal time reporting in KVM

2012-11-28 Thread Michael Wolf
On 11/27/2012 05:24 PM, Marcelo Tosatti wrote: On Mon, Nov 26, 2012 at 02:36:24PM -0600, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment the user may see steal time being reported in accounting tools such as top or vmstat

Re: [PATCH 0/5] Alter steal time reporting in KVM

2012-11-28 Thread Michael Wolf
On 11/28/2012 02:45 AM, Glauber Costa wrote: On 11/27/2012 07:10 PM, Michael Wolf wrote: On 11/27/2012 02:48 AM, Glauber Costa wrote: Hi, On 11/27/2012 12:36 AM, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment the user may

Re: [PATCH 0/5] Alter steal time reporting in KVM

2012-11-27 Thread Michael Wolf
On 11/27/2012 02:48 AM, Glauber Costa wrote: Hi, On 11/27/2012 12:36 AM, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment the user may see steal time being reported in accounting tools such as top or vmstat. This can cause

Re: [PATCH RFC V2 0/5] Separate consigned (expected steal) from steal time.

2012-11-26 Thread Michael Wolf
On 10/22/2012 10:33 AM, Rik van Riel wrote: On 10/16/2012 10:23 PM, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment the user may see steal time being reported in accounting tools such as top or vmstat. This can cause confusion

[PATCH 0/5] Alter steal time reporting in KVM

2012-11-26 Thread Michael Wolf
(expected steal) time. The host will separate the consigned time from the steal time. The consignment limit passed to the host will be the amount of steal time expected within a fixed period of time. Any other steal time accruing during that period will show as the traditional steal time. --- Michael

[PATCH 1/5] Alter the amount of steal time reported by the guest.

2012-11-26 Thread Michael Wolf
. The amount consigned_time will be passed in using an ioctl. The time will be expressed in the number of nanoseconds to be lost in during the fixed period. The fixed period is currently 1/10th of a second. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- fs/proc/stat.c |9

[PATCH 2/5] Expand the steal time msr to also contain the consigned time.

2012-11-26 Thread Michael Wolf
Add a consigned field. This field will hold the time lost due to capping or overcommit. The rest of the time will still show up in the steal-time field. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/include/asm

[PATCH 3/5] Add the code to send the consigned time from the host to the guest

2012-11-26 Thread Michael Wolf
Add the code to send the consigned time from the host to the guest. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/include/asm/kvm_para.h |3 ++- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/kernel/kvm.c |3

[PATCH 4/5] Add a timer to allow the separation of consigned from steal time.

2012-11-26 Thread Michael Wolf
Add a timer to the host. This will define the period. During a period the first n ticks will go into the consigned bucket. Any other ticks that occur within the period will be placed in the stealtime bucket. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm

[PATCH 5/5] Add an ioctl to communicate the consign limit to the host.

2012-11-26 Thread Michael Wolf
Add an ioctl to communicate the consign limit to the host. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/kvm/x86.c |6 ++ include/linux/kvm_host.h |2 ++ include/uapi/linux/kvm.h |2 ++ virt/kvm/kvm_main.c |7 +++ 4 files changed, 17

[PATCH 3/5] Add the code to send the consigned time from the host to the guest

2012-11-26 Thread Michael Wolf
Add the code to send the consigned time from the host to the guest. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/include/asm/kvm_para.h |3 ++- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/kernel/kvm.c |3

[PATCH 4/5] Add a timer to allow the separation of consigned from steal time.

2012-11-26 Thread Michael Wolf
Add a timer to the host. This will define the period. During a period the first n ticks will go into the consigned bucket. Any other ticks that occur within the period will be placed in the stealtime bucket. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm

[PATCH 0/5] Alter stealtime reporting in KVM

2012-11-26 Thread Michael Wolf
(expected steal) time. The host will separate the consigned time from the steal time. The consignment limit passed to the host will be the amount of steal time expected within a fixed period of time. Any other steal time accruing during that period will show as the traditional steal time. --- Michael

[PATCH 1/5] Alter the amount of steal time reported by the guest.

2012-11-26 Thread Michael Wolf
. The amount consigned_time will be passed in using an ioctl. The time will be expressed in the number of nanoseconds to be lost in during the fixed period. The fixed period is currently 1/10th of a second. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- fs/proc/stat.c |9

[PATCH 2/5] Expand the steal time msr to also contain the consigned time.

2012-11-26 Thread Michael Wolf
Add a consigned field. This field will hold the time lost due to capping or overcommit. The rest of the time will still show up in the steal-time field. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/include/asm

Re: [PATCH RFC V2 0/5] Separate consigned (expected steal) from steal time.

2012-10-17 Thread Michael Wolf
On Wed, 2012-10-17 at 21:14 +0400, Glauber Costa wrote: On 10/17/2012 06:23 AM, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment the user may see steal time being reported in accounting tools such as top or vmstat. This can

[PATCH RFC V2 1/5] Alter the amount of steal time reported by the guest.

2012-10-16 Thread Michael Wolf
. The amount consigned_time will be passed in using an ioctl. The time will be expressed in the number of nanoseconds to be lost in during the fixed period. The fixed period is currently 1/10th of a second. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- fs/proc/stat.c |9

[PATCH RFC V2 3/5] Add the code to send the consigned time from the host to the guest

2012-10-16 Thread Michael Wolf
Add the code to send the consigned time from the host to the guest Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/kvm_host.h |1 + arch/x86/include/asm/kvm_para.h |3 ++- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/kernel/kvm.c |3

[PATCH RFC V2 5/5] Add an ioctl to communicate the consign limit to the host.

2012-10-16 Thread Michael Wolf
Add an ioctl to communicate the consign limit to the host. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/kvm/x86.c |6 ++ include/linux/kvm.h |2 ++ include/linux/kvm_host.h |2 ++ virt/kvm/kvm_main.c |7 +++ 4 files changed, 17

[PATCH RFC V2 4/5] Add a timer to allow the separation of consigned from steal time.

2012-10-16 Thread Michael Wolf
Add a timer to the host. This will define the period. During a period the first n ticks will go into the consigned bucket. Any other ticks that occur within the period will be placed in the stealtime bucket. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm

[PATCH RFC V2 0/5] Separate consigned (expected steal) from steal time.

2012-10-16 Thread Michael Wolf
: * Change native_clock to take params and not return a value * Change update_rq_clock_task Changes from V1: * Removed the steal time allowed percentage from the guest * Moved the separation of consigned (expected steal) and steal time to the host. * No longer include a sysctl interface. --- Michael

[PATCH RFC V2 2/5] Expand the steal time msr to also contain the consigned time.

2012-10-16 Thread Michael Wolf
Add a consigned field. This field will hold the time lost due to capping or overcommit. The rest of the time will still show up in the steal-time field. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/include/asm/paravirt.h |4 ++-- arch/x86/kernel/kvm.c |7

Re: [PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-27 Thread Michael Wolf
On Sat, 2012-08-25 at 19:36 -0400, Glauber Costa wrote: On 08/24/2012 11:11 AM, Michael Wolf wrote: On Fri, 2012-08-24 at 08:53 +0400, Glauber Costa wrote: On 08/24/2012 03:14 AM, Michael Wolf wrote: This is an RFC regarding the reporting of stealtime. In the case of where you have

Re: [PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-27 Thread Michael Wolf
On Mon, 2012-08-27 at 11:50 -0700, Glauber Costa wrote: On 08/27/2012 08:50 AM, Michael Wolf wrote: On Sat, 2012-08-25 at 19:36 -0400, Glauber Costa wrote: On 08/24/2012 11:11 AM, Michael Wolf wrote: On Fri, 2012-08-24 at 08:53 +0400, Glauber Costa wrote: On 08/24/2012 03:14 AM, Michael

Re: [PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-27 Thread Michael Wolf
On Mon, 2012-08-27 at 11:55 -0700, Avi Kivity wrote: On 08/23/2012 04:14 PM, Michael Wolf wrote: This is an RFC regarding the reporting of stealtime. In the case of where you have a system that is running with partial processors such as KVM the user may see steal time being reported

Re: [PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-27 Thread Michael Wolf
On Mon, 2012-08-27 at 13:31 -0700, Avi Kivity wrote: On 08/27/2012 01:23 PM, Michael Wolf wrote: How would a guest know what its entitlement is? Currently the Admin/management tool setting up the guests will put it on the qemu commandline. From this it is passed via an ioctl

Re: [PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-27 Thread Michael Wolf
On Mon, 2012-08-27 at 14:41 -0700, Glauber Costa wrote: On 08/27/2012 02:27 PM, Michael Wolf wrote: On Mon, 2012-08-27 at 13:31 -0700, Avi Kivity wrote: On 08/27/2012 01:23 PM, Michael Wolf wrote: How would a guest know what its entitlement is? Currently the Admin/management tool

Re: [PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-24 Thread Michael Wolf
On Fri, 2012-08-24 at 08:53 +0400, Glauber Costa wrote: On 08/24/2012 03:14 AM, Michael Wolf wrote: This is an RFC regarding the reporting of stealtime. In the case of where you have a system that is running with partial processors such as KVM the user may see steal time being reported

[PATCH RFC 0/3] Add guest cpu_entitlement reporting

2012-08-23 Thread Michael Wolf
to the /proc/stat output and show the unaltered steal time. Since this additional field could cause more confusion than it would clear up I have left it out for now. Michael Wolf (3): Add a sysctl interface to control the cpu entitlement setting. Add a hypercall to retrieve

[PATCH RFC 1/3] Add a sysctl interface to control and report the cpu entitlement setting.

2012-08-23 Thread Michael Wolf
This setting will later be used to compute an expected steal time. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- Documentation/sysctl/kernel.txt | 14 ++ fs/proc/stat.c |1 + kernel/sysctl.c | 10 ++ 3 files changed, 25

[PATCH RFC 3/3] Modify the amount of stealtime that the kernel reports via the /proc interface.

2012-08-23 Thread Michael Wolf
-off-by: Michael Wolf m...@linux.vnet.ibm.com --- fs/proc/stat.c | 70 ++- include/linux/kernel_stat.h |2 + 2 files changed, 70 insertions(+), 2 deletions(-) diff --git a/fs/proc/stat.c b/fs/proc/stat.c index cf5..efbaa03 100644

[PATCH RFC 2/3] Add a hypercall to retrieve the cpu entitlement value from the host.

2012-08-23 Thread Michael Wolf
If the hypercall is not implemented on the host a default value of 100 will be used. This value will be stored in /proc/sys/kernel/cpu_entitlements. Signed-off-by: Michael Wolf m...@linux.vnet.ibm.com --- arch/x86/kvm/x86.c |8 fs/proc/stat.c |9