Re: [PATCH] kvm-all: PAGE_SIZE should be real host page size

On 10/11/2015 16:57, Andrew Jones wrote: > On Tue, Nov 10, 2015 at 04:41:16PM +0100, Paolo Bonzini wrote: >> >> >> On 10/11/2015 01:23, Andrew Jones wrote: >>> Just noticed this while grepping TARGET_PAGE_SIZE for an unrelated >>> reason. I didn't use qemu_

Re: [kvm-unit-tests PATCH 00/18] bunch of mostly trivial patches

On 06/11/2015 01:24, Andrew Jones wrote: > Many of these patches were posted once. Some weren't, but anyway > almost everything is pretty trivial. I'd like to get these in, or > at least get definitive nacks on them (and then drop them) in order > to clean my queue before more patches (coming

Re: [kvm-unit-tests PATCH 05/18] README: add pointer to new wiki page

On 06/11/2015 01:24, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > README | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/README b/README > index eab5ea28f7fab..45587f2a97ec6 100644 > --- a/README > +++ b/README > @@ -1,3 +1,9 @@ > +Welcome to

Re: [kvm-unit-tests PATCH 03/18] trivial: alloc: don't use 'top' outside spinlock

On 06/11/2015 01:24, Andrew Jones wrote: > This is a fix just due to being too much of a type-A person. > I noticed the issue while reading over the function, and > decided to fix it, even though it's unlikely to be a problem > ever because top is read-mostly (like written once, then only >

Re: [kvm-unit-tests PATCH 04/18] trivial: lib: missing extern in string.h

On 06/11/2015 01:24, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > lib/string.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/string.h b/lib/string.h > index 7820db86ee4e0..4e24f54d9e231 100644 > --- a/lib/string.h > +++

Re: [kvm-unit-tests PATCH 18/18] arm/arm64: uart0_init: check /chosen/stdout-path

On 06/11/2015 01:24, Andrew Jones wrote: > Arguably all of uart0_init() is unnecessary, as we're pretty sure > that the address we initialize uart0_base to is correct. We go > through the motions of finding the uart anyway though, because it's > easy. It's also easy to check chosen/stdout-path

Re: [kvm-unit-tests PATCH 10/18] run_tests: probe for max-smp

On 06/11/2015 01:24, Andrew Jones wrote: > KVM can be configured to only support a few vcpus. ARM and AArch64 > currently have a default config of only 4. While it's nice to be > able to write tests that use the maximum recommended, nr-host-cpus, > we can't assume that nr-host-cpus ==

Re: [kvm-unit-tests PATCH 09/18] arm/run: use ACCEL to choose between kvm and tcg

On 06/11/2015 01:24, Andrew Jones wrote: > Inspired by a patch by Alex Bennée. This version uses a new > unittests.cfg variable and includes support for DRYRUN. > > Signed-off-by: Andrew Jones > --- > arm/run | 43 +--

Re: [kvm-unit-tests PATCH 19/18] don't embed code inside asserts

On 09/11/2015 21:57, Andrew Jones wrote: > assert() is classically a macro which could also be disabled, so if > somebody introduces a switch to "#define assert(...) /*nothing*/" in > the future, we'd lose code. > > Suggested-by: Thomas Huth > Signed-off-by: Andrew Jones

Re: [kvm-unit-tests PATCH 01/18] makefiles: use bash

On 06/11/2015 01:24, Andrew Jones wrote: > Use bash in the makefiles, like we do in the scripts. Without > this some platforms using dash fail to execute make targets > that use bash-isms. > > Signed-off-by: Andrew Jones > --- > Makefile | 2 ++ > 1 file changed, 2

[GIT PULL] Second batch of KVM changes for 4.4

a scaled host TSC for guest readings of MSR_IA32_TSC KVM: VMX: Dump TSC multiplier in dump_vmcs() Paolo Bonzini (6): KVM: x86: merge handle_mmio_page_fault and handle_mmio_page_fault_common KVM: x86: declare a few variables as __read_mostly context_tracking: remove duplicate

Re: [PATCH 5/5] KVM: x86: MMU: Consolidate WARN_ON/BUG_ON checks for reverse-mapped sptes

On 10/11/2015 10:05, Takuya Yoshikawa wrote: > > >> BTW, on my todo list is to change the rmap items to a struct (with a >> single u64 inside) for type safety. Since you are touching this code, >> perhaps you can give it a shot? > > Yes, almost done here (assuming that you mean 'unsigned

Re: [PATCH 6/9] KVM, pkeys: add pkeys support for permission_fault logic

On 10/11/2015 10:28, Han, Huaitong wrote: > > pkru = is_long_mode(vcpu) ? read_pkru() : 0; > > if (unlikely(pkru) && (pfec & PFERR_PK_MASK)) { > > ... from above ... */ > > > > /* Flip PFERR_PK_MASK if pkru_bits is non-zero */ > > pfec ^= -pkru_bits &

[PATCH 3/3] KVM: x86: rename update_db_bp_intercept to update_bp_intercept

Because #DB is now intercepted unconditionally, this callback only operates on #BP for both VMX and SVM. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/svm.c | 2 +- arch/x86/kvm/vmx.c | 2 +- arch/x86/k

[PATCH 0/3] Infinite loops in microcode while running guests

: work around infinite loop in microcode when #AC is delivered Paolo Bonzini (2): KVM: svm: unconditionally intercept #DB KVM: x86: rename update_db_bp_intercept to update_bp_intercept arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/include/uapi/asm/svm.h | 1 + arch/x86/kvm/svm.c

[PATCH 1/3] KVM: x86: work around infinite loop in microcode when #AC is delivered

s pretty quickly due to the effects (CVE-2015-5307). Signed-off-by: Eric Northup <digitale...@google.com> Cc: sta...@vger.kernel.org Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/include/uapi/asm/svm.h | 1 + arch/x86/kvm/svm.c | 8 arch/x8

[PATCH 2/3] KVM: svm: unconditionally intercept #DB

el.org Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/kvm/svm.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 183926483c3a..1cc1ffca0d8c 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.

Re: [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

lt;asmeta...@virtuozzo.com> > Reviewed-by: Roman Kagan <rka...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > CC: Richard Henderson <r...@twiddle.net> > CC: Eduardo Habkost <ehabk...@redhat.co

Re: [PATCH v4 0/6] virtio core DMA API conversion

On 09/11/2015 13:15, Michael S. Tsirkin wrote: > Well that's not exactly true. I think we would like to make > it possible to put virtio devices behind an IOMMU on x86, > but if this means existing guests break, then many people won't be able > to use this option: having to find out which kernel

Re: [PATCH 7/9] KVM, pkeys: Add pkeys support for gva_to_gpa funcions

On 09/11/2015 12:54, Huaitong Han wrote: > index 7a84b83..6e9156d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3960,6 +3960,8 @@ gpa_t kvm_mmu_gva_to_gpa_read(struct kvm_vcpu *vcpu, > gva_t gva, > struct x86_exception *exception) > { >

Re: [PATCH 3/9] KVM, pkeys: expose CPUID:OSPKE to guest

On 09/11/2015 12:54, Huaitong Han wrote: > This patch exposes X86_FEATURE_OSPKE to guest, X86_FEATURE_OSPKE is > software support for pkeys, enumerated with CPUID.7.0.ECX[4]:OSPKE, > and it reflects the setting of CR4.PKE. > > Signed-off-by: Huaitong Han > > diff --git

Re: [PATCH 6/9] KVM, pkeys: add pkeys support for permission_fault logic

On 09/11/2015 12:54, Huaitong Han wrote: > Protection keys define a new 4-bit protection key field (PKEY) in bits > 62:59 of leaf entries of the page tables, the PKEY is an index to PKRU > register(16 domains), every domain has 2 bits(write disable bit, access > disable bit). > > Static logic

Re: [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling

On 09/11/2015 12:55, Huaitong Han wrote: > @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] = { >CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2, >CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM, >CPUID_7_0_EBX_RDSEED */

Re: [PATCH 6/9] KVM, pkeys: add pkeys support for permission_fault logic

On 09/11/2015 13:43, Paolo Bonzini wrote: > > > On 09/11/2015 12:54, Huaitong Han wrote: >> Protection keys define a new 4-bit protection key field (PKEY) in bits >> 62:59 of leaf entries of the page tables, the PKEY is an index to PKRU >> register(16 domains), ev

Re: [PATCH 5/9] KVM, pkeys: update memeory permission bitmask for pkeys

On 09/11/2015 12:54, Huaitong Han wrote: >* Byte index: page fault error code [4:1] >* Bit index: pte permissions in ACC_* format > + * > + * Add PFEC.PK (bit 5) for protection-key violations Instead, change "[4:1]" to "[5:1]" in the "Byte index" line. Paolo >

Re: [PATCH 5/5] KVM: x86: MMU: Consolidate WARN_ON/BUG_ON checks for reverse-mapped sptes

On 06/11/2015 08:25, Takuya Yoshikawa wrote: > At some call sites of rmap_get_first() and rmap_get_next(), BUG_ON is > placed right after the call to detect unrelated sptes which should not > be found in the reverse-mapping list. > > Move this check in rmap_get_first/next() so that all call

Re: [PATCH 0/5] KVM: x86: MMU: Clean up x86's mmu code for future work

On 06/11/2015 08:20, Takuya Yoshikawa wrote: > Patch 1/2/3 are easy ones. > > Following two, patch 4/5, may not be ideal solutions, but at least > explain, or try to explain, the problems. They are okay! I replied to patch 5 with a suggestion for further cleanup. I'll apply them for 4.5.

Re: [PATCH v2 0/4] KVM: VMX: enable LBR virtualization

On 09/11/2015 02:33, Jian Zhou wrote: > Hi Paolo, > > May I ask that any suggestion about the version 2 of VMX LBRV? > This version is updated following your advices in version 1. > BTW the kvm-unit-test for this feature has sent too, and I > have tested the CPUs emulated by QEMU. Hi, since

Re: [PATCH 1/3] context_tracking: remove duplicate enabled check

On 28/10/2015 06:19, Andy Lutomirski wrote: > On Tue, Oct 27, 2015 at 6:39 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: >> All calls to context_tracking_enter and context_tracking_exit >> are already checking context_tracking_is_enabled, except the >>

Re: [PATCH v2 00/12] KVM: x86: add support for VMX TSC scaling

On 20/10/2015 09:39, Haozhong Zhang wrote: > This patchset adds support for VMX TSC scaling feature which is > available on Intel Skylake CPU. The specification of VMX TSC scaling > can be found at >

Re: OpenBSD 5.3 guest on KVM

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/09/2013 01:31, Daniel Bareiro wrote: > Hi all! > > These days I tested OpenBSD 5.3 and pleasantly surprised me notice > that they implemented VirtIO for block devices, network and memory > ballooning. It is an important step for those who

Re: [PATCH v2] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c

On 06/11/2015 14:02, William Dauchy wrote: > Hi Paolo, > > Looking at the history of this function, is it reasonable to say > it fixes the following commit? af585b9 KVM: Halt vcpu if page it > tries to access is swapped out > > Does it make it a good candidate for -stable? It's just a

Re: [PATCH v2 00/12] KVM: x86: add support for VMX TSC scaling

On 06/11/2015 13:42, Haozhong Zhang wrote: > On 11/06/15 11:49, Paolo Bonzini wrote: >> >> >> On 20/10/2015 09:39, Haozhong Zhang wrote: >>> This patchset adds support for VMX TSC scaling feature which is >>> available on Intel Skylake CPU. The specificat

Re: [v2] KVM: VMX: Fix commit which broke PML

On 05/11/2015 03:04, Kai Huang wrote: > > Thanks for applying! I am really sorry that I forgot to delete the line > that clears SECONDARY_EXEC_ENABLE_PML bit in vmx_disable_pml, which is > renamed to vmx_destroy_pml_buffer now. > It won't impact functionality but to make the function

Re: [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter.

On 05/11/2015 17:07, Gerhard Wiesinger wrote: >> > > ./trace-cmd record -b 2 -e kvm > ./trace-cmd report | grep -i task_switch > qemu-system-x86-6024 [001] 792774.719297: kvm_exit: reason task_switch > rip 0x4883 info 158 40 0x158 is the segment selector of the incoming TSS, and

Re: [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter.

On 05/11/2015 17:15, Paolo Bonzini wrote: > > > On 05/11/2015 17:07, Gerhard Wiesinger wrote: >>> >> >> ./trace-cmd record -b 2 -e kvm >> ./trace-cmd report | grep -i task_switch >> qemu-system-x86-6024 [001] 792774.719297: kvm_exit: reason tas

[GIT PULL] First batch of KVM changes for 4.4

f memslots Paolo Bonzini (22): Merge branch 'x86/for-kvm' of git://git.kernel.org/.../tip/tip into HEAD tools lib traceevent: update KVM plugin KVM: x86: set TMR when the interrupt is accepted KVM: x86: store IOAPIC-handled vectors in each VCPU KVM: x86: replace vm_has_

Re: [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter.

On 04/11/2015 22:33, Gerhard Wiesinger wrote: >>> >> What is the problem you are seeing? KVM can emulate task switches; the >> intercept is set here because of a processor erratum that can mess them >> up even though, in theory, AMD supports task switching from guest mode. > > See old thread:

Re: [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter.

On 04/11/2015 20:33, Gerhard Wiesinger wrote: > Signed-off-by: Gerhard Wiesinger > --- > arch/x86/kvm/svm.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 2f9ed1f..e0b00fc 100644 > --- a/arch/x86/kvm/svm.c >

Re: [PATCH] kvm: irqchip: fix memory leak

On 03/11/2015 22:17, William Dauchy wrote: > Hi Paolo, > > I was wondering it this could be a valid candidate for -stable, don't you > think? > (commit ba60c41) Indeed, feel free to propose it! Paolo > Best regards, > > On Sep02 12:33, Sudip Mukherjee wrote: >> We were taking the exit path

Re: [v2] KVM: VMX: Fix commit which broke PML

> KVM: VMX: unify SECONDARY_VM_EXEC_CONTROL update > > Unify the update in vmx_cpuid_update() > > Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> > [Rewrite to use vmcs_set_secondary_exec_control. - Paolo] > Signed-off-by: Paolo Bonzini <p

Re: [PATCH] KVM: x86: obey KVM_X86_QUIRK_CD_NW_CLEARED in kvm_set_cr0()

them. > > We also carry over the kvm_arch_has_noncoherent_dma() sub-condition from > the other half of the original commit b18d5431acc7. > > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Janusz Mocek <janusz.

[PATCH] KVM: x86: merge handle_mmio_page_fault and handle_mmio_page_fault_common

They are exactly the same, except that handle_mmio_page_fault has an unused argument and a call to WARN_ON. Remove the unused argument from the callers, and move the warning to (the former) handle_mmio_page_fault_common. --- arch/x86/kvm/mmu.c | 20 +---

Re: [PATCH] kvm: irqchip: fix memory leak

On 03/11/2015 22:17, William Dauchy wrote: > Hi Paolo, > > I was wondering it this could be a valid candidate for -stable, don't you > think? > (commit ba60c41) Certainly, feel free to propose it to sta...@vger.kernel.org! Paolo > Best regards, > > On Sep02 12:33, Sudip Mukherjee wrote: >>

Re: [PULL 00/21] KVM/ARM Changes for v4.4-rc1

On 04/11/2015 15:49, Christoffer Dall wrote: > Hi Paolo, > > Here is the set of changes for v4.4. Some of the commits listed here were > already merged as fixes for v4.3, but since they are not in kvm/next yet, they > show up here. Let me know if you want me to handle this differently

Re: [PATCH] KVM: VMX: Fix commit which broke PML

KVM: VMX: unify SECONDARY_VM_EXEC_CONTROL update > > Unify the update in vmx_cpuid_update() > > Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> > [Rewrite to use vmcs_set_secondary_exec_control. - Paolo] >

Re: [PATCH 0/3] KVM: x86: simplify RSM into 64-bit protected mode

On 03/11/2015 10:40, Laszlo Ersek wrote: > On 11/02/15 10:32, Paolo Bonzini wrote: >> >> >> On 31/10/2015 20:50, Laszlo Ersek wrote: >>> Tested-by: Laszlo Ersek <ler...@redhat.com> >> >> Thanks Laszlo, I applied patches 1 and 2 (since your &q

Re: [PATCH] KVM: x86: fix eflags state following processor init/reset

On 28/10/2015 09:10, Nadav Amit wrote: > Here are my 5 cents. Note that vmx_vcpu_reset calls: > > vmcs_writel(GUEST_RFLAGS, 0x02); > > (And the RFLAGS value is not cached by KVM, so no consistency problem should > occur.) > > You may want to change the value into constant or call a

Re: [kvm-unit-tests PATCH 00/14] ppc64: initial drop

On 03/11/2015 08:08, Thomas Huth wrote: > On 03/08/15 16:41, Andrew Jones wrote: >> > This series is the first series of a series of series that will >> > bring support to kvm-unit-tests for ppc64, and eventually ppc64le. > Hi Andrew, > > may I ask about the current state of ppc64 support in

Re: [PATCH] KVM: VMX: fix SMEP and SMAP without EPT

On 02/11/2015 22:20, Radim Krčmář wrote: > The comment in code had it mostly right, but we enable paging for > emulated real mode regardless of EPT. > > Without EPT (which implies emulated real mode), secondary VCPUs won't > start unless we disable SM[AE]P when the guest doesn't use paging. >

Re: [PATCH v3 9/9] kvm/x86: Hyper-V kvm exit

cs > > Signed-off-by: Andrey Smetanin <asmeta...@virtuozzo.com> > Reviewed-by: Roman Kagan <rka...@virtiozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Vitaly Kuznetsov <vkuzn...@redhat.com> > CC: "K. Y. Srinivasan" <k..

[PATCH] KVM: x86: allow RSM from 64-bit mode

clearing CS.L and CR4.PCIDE. Cc: sta...@vger.kernel.org Fixes: 660a5d517aaab9187f93854425c4c63f4a09195c Cc: Laszlo Ersek <ler...@redhat.com> Cc: Radim Krčmář <rkrc...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/kvm/emulate.c | 30

Re: [kvm-unit-tests PATCH 00/14] ppc64: initial drop

On 03/11/2015 08:08, Thomas Huth wrote: > On 03/08/15 16:41, Andrew Jones wrote: >> > This series is the first series of a series of series that will >> > bring support to kvm-unit-tests for ppc64, and eventually ppc64le. > Hi Andrew, > > may I ask about the current state of ppc64 support in

Re: [PATCH v2] KVM: x86: Reset RFLAGS state following processor init/reset

On 03/11/2015 12:40, Wanpeng Li wrote: > Reference SDM Volume 1 3.4.3: > > Following initialization of the processor (either by asserting the > RESET pin or the INIT pin), the state of the EFLAGS register is > 0002H. > > However, the eflags fixed bit is not set and other bits are also

Re: [PATCH] KVM: x86: allow RSM from 64-bit mode

On 03/11/2015 14:40, Laszlo Ersek wrote: > On 11/03/15 14:29, Paolo Bonzini wrote: >> The SDM says that exiting system management mode from 64-bit mode >> is invalid, but that would be too good to be true. But actually, >> most of the code is already there to support exitin

Re: [PATCH v3 9/9] kvm/x86: Hyper-V kvm exit

On 03/11/2015 15:36, Andrey Smetanin wrote: >> >> >> if I run a patched QEMU but I *do not* enable the synthetic interrupt >> controller. I can fix it by wrapping the calls to synic_exit with "if >> (!host)", but I haven't checked yet the source---so that may not be the >> proper fix. Sorry

Re: [PATCH] KVM: x86: allow RSM from 64-bit mode

On 03/11/2015 15:02, Laszlo Ersek wrote: > On 11/03/15 14:46, Paolo Bonzini wrote: >> >> >> On 03/11/2015 14:40, Laszlo Ersek wrote: >>> On 11/03/15 14:29, Paolo Bonzini wrote: >>>> The SDM says that exiting system management mode from 64-bit mode &

Re: [PATCH v7 09/35] exec: allow file_ram_alloc to work on file

On 03/11/2015 04:56, Xiao Guangrong wrote: > > > On 11/03/2015 05:12 AM, Paolo Bonzini wrote: >> >> >> On 02/11/2015 10:13, Xiao Guangrong wrote: >>> Currently, file_ram_alloc() only works on directory - it creates a file >>> under @path and do

Re: [PATCH v3 0/3] virtio DMA API core stuff

On 29/10/2015 10:01, Michael S. Tsirkin wrote: > > Everyone seems to agree that x86's emulated Q35 thing > > is just buggy right now and should be taught to use the existing ACPI > > mechanism for enumerating passthrough devices. > > I'm not sure what ACPI has to do with it. > It's about a way

Re: [PATCH 1/3] KVM: x86: merge kvm_arch_set_irq with kvm_set_msi_inatomic

On 02/11/2015 15:59, Radim Krcmar wrote: > > We do not want to do too much work in atomic context, in particular > > not walking all the VCPUs of the virtual machine. So we want > > to distinguish the architecture-specific injection function for irqfd > > from kvm_set_msi. Since it's still

Re: [PATCH 1/3] KVM: x86: merge kvm_arch_set_irq with kvm_set_msi_inatomic

On 02/11/2015 18:01, Radim Krcmar wrote: >> > Yes. Both because the Virtuozzo people confirmed that kvm_arch_set_irq >> > isn't needed for synic, and because synic is currently broken with APICv. > Thanks. > > (We can add direct delivery for |online vcpus| < X if performance with > low number

Re: [PATCH v7 09/35] exec: allow file_ram_alloc to work on file

On 02/11/2015 10:13, Xiao Guangrong wrote: > Currently, file_ram_alloc() only works on directory - it creates a file > under @path and do mmap on it > > This patch tries to allow it to work on file directly, if @path is a > directory it works as before, otherwise it treats @path as the target >

Re: [PATCH 0/3] KVM: x86: simplify RSM into 64-bit protected mode

On 31/10/2015 20:50, Laszlo Ersek wrote: > Tested-by: Laszlo Ersek Thanks Laszlo, I applied patches 1 and 2 (since your "part 2" never was :)). Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

On 30/10/2015 07:16, Yunhong Jiang wrote: > And with this change, we even don't need the module option anymore, we first > try the primary handler, which is in hard irq context, and if failed, then > threaded irq handler. Am I right? Yes. > Paolo/Alex, do you want to work on the patch

Re: [GIT PULL 0/3] KVM: s390: Bugfix and cleanups for kvm/next (4.4)

On 29/10/2015 16:08, Christian Borntraeger wrote: > git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git > tags/kvm-s390-next-20151028 Pulled, thanks! Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] KVM: x86: zero apic_arb_prio on reset

On 30/10/2015 15:48, Radim Krčmář wrote: > BSP doesn't get INIT so its apic_arb_prio isn't zeroed after reboot. > BSP won't get lowest priority interrupts until other VCPUs get enough > interrupts to match their pre-reboot apic_arb_prio. > > That behavior doesn't fit into KVM's round-robin-like

Re: [PATCH 0/7] Hyper-V Synthetic interrupt controller

m> > Reviewed-by: Roman Kagan <rka...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Vitaly Kuznetsov <vkuzn...@redhat.com> > CC: "K. Y. Srinivasan" <k...@microsoft.com> > CC: Gleb Natapov <g...@kernel.org> > CC: Paolo Bon

Re: [PATCH] KVM: x86: removing unused variable

On 30/10/2015 08:26, Saurabh Sengar wrote: > removing unused variables, found by coccinelle > > Signed-off-by: Saurabh Sengar > --- > arch/x86/kvm/x86.c | 16 +--- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/arch/x86/kvm/x86.c

Re: [kvm-unit-tests PATCH] x86: hyperv_synic: Hyper-V SynIC test

uozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Vitaly Kuznetsov <vkuzn...@redhat.com> > CC: "K. Y. Srinivasan" <k...@microsoft.com> > CC: Gleb Natapov <g...@kernel.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > CC:

Re: [kvm-unit-tests PATCH] x86: hyperv_synic: Hyper-V SynIC test

On 02/11/2015 13:18, Denis V. Lunev wrote: >> I'm keeping the kernel patches queued for my own testing, but this of >> course has to be fixed before including them---which will delay this >> feature to 4.5, unfortunately. > > well, the problem is that it actually uses auto EOI Ok, no big

[PATCH 2/3] KVM: device assignment: remove pointless #ifdefs

The symbols are always defined. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/kvm/assigned-dev.c | 25 - 1 file changed, 25 deletions(-) diff --git a/arch/x86/kvm/assigned-dev.c b/arch/x86/kvm/assigned-dev.c index d090ecf08809..1c17ee807ef7

Re: [GIT PULL] Please pull my kvm-ppc-next branch

On 26/10/2015 05:17, Paul Mackerras wrote: > Paolo, > > Here is my current patch queue for KVM on PPC. There's nothing much > in the way of new features this time; it's mostly bug fixes, plus > Nikunj has implemented support for KVM_CAP_NR_MEMSLOTS. These are > intended for the "next" branch of

[PATCH 3/3] KVM: x86: move kvm_set_irq_inatomic to legacy device assignment

The function is not used outside device assignment, and kvm_arch_set_irq_inatomic has a different prototype. Move it here and make it static to avoid confusion. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/kvm/assigned-dev.c | 37 +

[PATCH 1/3] KVM: x86: merge kvm_arch_set_irq with kvm_set_msi_inatomic

it to kvm_arch_set_irq_inatomic. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/kvm/irq_comm.c | 14 -- include/linux/kvm_host.h | 7 +++ virt/kvm/eventfd.c | 11 --- 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/arch/x

[PATCH 0/3] KVM: x86: clean up interrupt injection

. Patch 1 is the real change, everything else cleans up what's left behind. Paolo Paolo Bonzini (3): KVM: x86: merge kvm_arch_set_irq with kvm_set_msi_inatomic KVM: device assignment: remove pointless #ifdefs KVM: x86: move kvm_set_irq_inatomic to legacy device assignment arch/x86/kvm

Re: [GIT PULL] Please pull my kvm-ppc-next branch

On 26/10/2015 05:17, Paul Mackerras wrote: > Paolo, > > Here is my current patch queue for KVM on PPC. There's nothing much > in the way of new features this time; it's mostly bug fixes, plus > Nikunj has implemented support for KVM_CAP_NR_MEMSLOTS. These are > intended for the "next" branch of

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

On 29/10/2015 04:11, Alex Williamson wrote: > > The irqfd is already able to schedule a work item, because it runs with > > interrupts disabled, so I think we can always return IRQ_HANDLED. > > I'm confused by this. The problem with adding IRQF_NO_THREAD to our > current handler is that it hits

Re: [PATCH v3 8/9] kvm/x86: Hyper-V synthetic interrupt controller

On 29/10/2015 09:45, Roman Kagan wrote: > While Andrey is testing it, I'd like to ask similar question re. MSI: > why is there a "shortcut" for KVM_IRQ_ROUTING_MSI case (which we > basically modelled after) when it would probably get handled through > ->set handler in irqfd_inject() too?

Re: [PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on kernel entry and exit

On 28/10/2015 06:22, Andy Lutomirski wrote: >> > called by guest_enter and guest_exit. >> > >> > Use the previously introduced __context_tracking_entry and >> > __context_tracking_exit. > x86 isn't ready for this yet. We could do a quick-and-dirty fix with > explicit IRQs-on-and-off much

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

On 28/10/2015 17:00, Alex Williamson wrote: > > Alex, would it make sense to use the IRQ bypass infrastructure always, > > not just for VT-d, to do the MSI injection directly from the VFIO > > interrupt handler and bypass the eventfd? Basically this would add an > > RCU-protected list of

Re: [PATCH v3 8/9] kvm/x86: Hyper-V synthetic interrupt controller

gt; CC: Vitaly Kuznetsov <vkuzn...@redhat.com> > CC: "K. Y. Srinivasan" <k...@microsoft.com> > CC: Gleb Natapov <g...@kernel.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > CC: Roman Kagan <rka...@virtuozzo.com> > > Changes v3: > *

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

On 28/10/2015 18:50, Yunhong Jiang wrote: > > No, I don't think you can use raw_spinlock there. The problem is not > > just eventfd_signal, it is especially wake_up_locked_poll. You cannot > > convert the whole workqueue infrastructure to use raw_spinlock. > > You mean the waitqueue, instead

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

On 27/10/2015 07:35, Yunhong Jiang wrote: > On Mon, Oct 26, 2015 at 09:37:14PM -0600, Alex Williamson wrote: >> On Mon, 2015-10-26 at 18:20 -0700, Yunhong Jiang wrote: >>> An option to force VFIO PCI MSI/MSI-X handler as non-threaded IRQ, >>> even when CONFIG_IRQ_FORCED_THREADING=y. This is

[PATCH 1/3] context_tracking: remove duplicate enabled check

wrappers around the user_enter and user_exit inline functions. Cc: Andy Lutomirski <l...@kernel.org> Cc: Frederic Weisbecker <fweis...@gmail.com> Cc: Rik van Riel <r...@redhat.com> Cc: Paul McKenney <paul...@linux.vnet.ibm.com> Signed-off-by: Paolo Bonzini <pbonz...@red

[PATCH 2/3] context_tracking: avoid irq_save/irq_restore on guest entry and exit

Cc: Rik van Riel <r...@redhat.com> Cc: Paul McKenney <paul...@linux.vnet.ibm.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- include/linux/context_tracking.h | 8 +++-- kernel/context_tracking.c| 64 2 files changed,

[PATCH 3/3] x86: context_tracking: avoid irq_save/irq_restore on kernel entry and exit

and __context_tracking_exit. Cc: Andy Lutomirski <l...@kernel.org> Cc: Frederic Weisbecker <fweis...@gmail.com> Cc: Rik van Riel <r...@redhat.com> Cc: Paul McKenney <paul...@linux.vnet.ibm.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> --- arch/x86/entry/common.c

Re: [RFC PATCH] VFIO: Add a parameter to force nonthread IRQ

On 27/10/2015 22:26, Yunhong Jiang wrote: >> > On RT kernels however can you call eventfd_signal from interrupt >> > context? You cannot call spin_lock_irqsave (which can sleep) from a >> > non-threaded interrupt handler, can you? You would need a raw spin lock. > Thanks for pointing this out.

[PATCH 0/3] context_tracking: streamline code, avoid IRQ save/restore

brought this series up at kernel summit yesterday, and Andy's cleanups actually makes it trivial to apply this to syscall entry. So here it is, perhaps it's worth it. Assuming it works, of course, because this is compile-tested only. :) Paolo Paolo Bonzini (3): context_tracking: remove duplicate

Re: [PATCH 0/3] context_tracking: streamline code, avoid IRQ save/restore

On 28/10/2015 02:39, Paolo Bonzini wrote: > The first two of these patches were posted last February, the last one > is new. Rik's old measurements were that it shaved around .3 microseconds > on each iteration of his KVM benchmark. > > I guess three days before the start of t

Re: [Qemu-devel] [PATCH 3/7] linux-headers/kvm: add Hyper-V SynIC irq routing type and struct

On 26/10/2015 11:16, Peter Maydell wrote: > On 26 October 2015 at 10:12, Denis V. Lunev wrote: >> On 10/26/2015 01:03 PM, Peter Maydell wrote: >>> Hi. Changes to linux-headers/ should only be made as part of >>> an automated update from a mainline Linux kernel tree using >>>

Re: [PATCH] KVM: x86: fix RSM into 64-bit protected mode, round 2

On 26/10/2015 16:43, Laszlo Ersek wrote: > > The code would be cleaner if we had a different approach, but this works > > too and is safer for stable. In case you prefer to leave the rewrite for > > a future victim, > > It's hard to express how much I prefer that. Radim, if you want to have a

Re: sanitizing kvmtool

On 21/10/2015 19:07, Sasha Levin wrote: > On 10/19/2015 11:15 AM, Dmitry Vyukov wrote: >> But still: if result of a racy read is passed to guest, that can leak >> arbitrary host data into guest. > > I see what you're saying. I don't... how can it leak arbitrary host data? The memcpy cannot

Re: [PATCH v2 00/12] KVM: x86: add support for VMX TSC scaling

On 23/10/2015 14:46, Joerg Roedel wrote: >> > No, since I don't have AMD machines at hand. The modifications to SVM >> > code are mostly lifting common code with VMX TSC scaling code, so it >> > should still work on AMD machines. > Well, I think it would be good if you can provide a Tested-by on

Re: Difference between vcpu_load and kvm_sched_in ?

On 21/10/2015 19:21, Yacine HEBBAL wrote: > If I correctly understood you last paragraph, it is better to use vm_ioctl > to do generic processing that doesn't rely on a given VCPU and hence I won't > need to use "CPU_FOREACH, run_on_cpu and current_cpu". Right. On the other hand, you

Re: [PATCH v3 9/9] kvm/x86: Hyper-V kvm exit

On 22/10/2015 18:10, Andrey Smetanin wrote: > A new vcpu exit is introduced to notify the userspace of the > changes in Hyper-V SynIC configuration triggered by guest writing to the > corresponding MSRs. > > Changes v3: > * added KVM_EXIT_HYPERV types and structs notes into docs Thanks. The

[GIT PULL] KVM changes for 4.3-rc7

map->active on pend/active clear arm/arm64: KVM: Fix disabled distributor operation Paolo Bonzini (1): Merge tag 'kvm-arm-for-v4.3-rc7' of git://git.kernel.org/.../kvmarm/kvmarm into kvm-master Pavel Fedin (2): KVM: arm/arm64: Do not inject spurious interrupts KVM:

Re: [GIT PULL 0/6] A handful of fixes for KVM/ARM for v4.3-rc7

On 20/10/2015 18:19, Christoffer Dall wrote: > Hi Paolo, > > The following changes since commit 920552b213e3dc832a874b4e7ba29ecddbab31bc: > > KVM: disable halt_poll_ns as default for s390x (2015-09-25 10:31:30 +0200) > > are available in the git repository at: > >

Re: Difference between vcpu_load and kvm_sched_in ?

On 21/10/2015 00:57, Wanpeng Li wrote: >> kvm_sched_out and kvm_sched_in are part of KVM's preemption hooks. The >> hooks are registered only between vcpu_load and vcpu_put, therefore they >> know that the mutex is taken. The sequence will go like this: >> >> vcpu_load >>

Re: Difference between vcpu_load and kvm_sched_in ?

On 21/10/2015 12:17, Hebbal Yacine wrote: > Thanks for the explanation, it's very clear. > I tired that but I didn't succeed to send the ioctl from "run_on_cpu" > function, I didn't find how to set the right CPUStat > I've tried "current_cpu" Current_cpu is always NULL outside the VCPU thread.

Fwd: Re: [PATCH v3 2/4] KVM: use simple waitqueue for vcpu->wq

ter Zijlstra <pet...@infradead.org> To: Daniel Wagner <daniel.wag...@bmw-carit.de> CC: linux-ker...@vger.kernel.org, linux-rt-us...@vger.kernel.org, Marcelo Tosatti <mtosa...@redhat.com>, Paolo Bonzini <pbonz...@redhat.com>, Paul E. McKenney <paul...@linux.vnet.ibm.com

<    1   2   3   4   5   6   7   8   9   10   >