Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions

2015-09-14 Thread Rustad, Mark D
> On Sep 11, 2015, at 6:11 PM, Rustad, Mark D <mark.d.rus...@intel.com> wrote: > > Superficially this looks pretty good. I need to think harder to be sure of > the details. This is the first time I've looked at all at any of the vfio code, but this is still looking

Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions

2015-09-11 Thread Rustad, Mark D
Alex, > On Sep 11, 2015, at 11:16 AM, Alex Williamson > wrote: > > RFC - Is this something we should do? Superficially this looks pretty good. I need to think harder to be sure of the details. > Should we consider providing > similar emulation through PCI sysfs

Re: [PATCH V2 1/4] x86/kvm: Resolve some missing-initializers warnings

2014-07-31 Thread Rustad, Mark D
On Jul 31, 2014, at 4:50 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/07/2014 23:18, Mark D Rustad ha scritto: Resolve some missing-initializers warnings that appear in W=2 builds. They are resolved by adding the name as a parameter to the macros and having the macro generate all four

Re: [PATCH 3/4] x86/kvm: Resolve shadow warnings in macro expansion

2014-07-25 Thread Rustad, Mark D
On Jul 25, 2014, at 7:06 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 25/07/2014 15:27, Jeff Kirsher ha scritto: From: Mark Rustad mark.d.rus...@intel.com Resolve shadow warnings that appear in W=2 builds. In this case, a macro declared an inner local variable with the same name as an

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Rustad, Mark D
On Jul 18, 2012, at 9:00 AM, Michael S. Tsirkin wrote: On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: If you add support for a new command, you need to provide userspace a way to disable this command. If

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Rustad, Mark D
On Jul 18, 2012, at 10:17 AM, Michael S. Tsirkin wrote: snip You do have to pay very close attention to some things however. Don't change the device identity in any way - even version information, otherwise a Windows initiator will blue-screen. I made that mistake myself, so I remember it