Re: [RFC PATCH v3 00/19] ACPI memory hotplug

2012-11-01 Thread Vasilis Liaskovitis
On Wed, Oct 31, 2012 at 01:16:56PM +0200, Avi Kivity wrote: On 10/31/2012 12:58 PM, Stefan Hajnoczi wrote: On Fri, Sep 21, 2012 at 1:17 PM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: This is v3 of the ACPI memory hotplug functionality. Only x86_64 target is supported

Re: [Qemu-devel] [RFC PATCH v3 05/19] Implement dimm device abstraction

2012-10-24 Thread Vasilis Liaskovitis
Hi, On Wed, Oct 24, 2012 at 12:15:17PM +0200, Stefan Hajnoczi wrote: On Wed, Oct 24, 2012 at 10:06 AM, liu ping fan qemul...@gmail.com wrote: On Tue, Oct 23, 2012 at 8:25 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Sep 21, 2012 at 01:17:21PM +0200, Vasilis Liaskovitis wrote

Re: [RFC PATCH v3 06/19] Implement -dimm command line option

2012-10-22 Thread Vasilis Liaskovitis
Hi, On Thu, Oct 18, 2012 at 02:33:02PM +0200, Avi Kivity wrote: On 10/18/2012 11:27 AM, Vasilis Liaskovitis wrote: On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: I don't think so, but probably there's a limit of DIMMs

Re: [RFC PATCH v3 06/19] Implement -dimm command line option

2012-10-18 Thread Vasilis Liaskovitis
On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: I don't think so, but probably there's a limit of DIMMs that real controllers have, something like 8 max. In the case of i440fx specifically, do you mean that we should model

Re: [RFC PATCH v3 06/19] Implement -dimm command line option

2012-10-17 Thread Vasilis Liaskovitis
On Sat, Oct 13, 2012 at 08:57:19AM +, Blue Swirl wrote: On Tue, Oct 9, 2012 at 5:04 PM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: snip Maybe even the dimmbus device shouldn't exist by itself after all, or it should be pretty much invisible to users. On real HW

Re: [RFC PATCH v3 06/19] Implement -dimm command line option

2012-10-09 Thread Vasilis Liaskovitis
Hi, sorry for the delayed answer. On Sat, Sep 29, 2012 at 11:13:04AM +, Blue Swirl wrote: The -dimm option is supposed to specify the dimm/memory layout, and not create any devices. If we don't want this new option, I have a question: A -device/device_add means we create a

Re: [RFC PATCH v3 06/19] Implement -dimm command line option

2012-09-24 Thread Vasilis Liaskovitis
On Sat, Sep 22, 2012 at 01:46:57PM +, Blue Swirl wrote: On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: Example: -dimm id=dimm0,size=512M,node=0,populated=off There should not be a need to introduce a new top level option, instead you

Re: [RFC PATCH v3 20/19][SeaBIOS] alternative: Use paravirt interface for pci windows

2012-09-24 Thread Vasilis Liaskovitis
On Mon, Sep 24, 2012 at 02:35:30PM +0800, Wen Congyang wrote: At 09/21/2012 07:20 PM, Vasilis Liaskovitis Wrote: Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based

Re: [RFC PATCH v3 11/19] Implement qmp and hmp commands for notification lists

2012-09-24 Thread Vasilis Liaskovitis
Hi, On Fri, Sep 21, 2012 at 04:03:26PM -0600, Eric Blake wrote: On 09/21/2012 05:17 AM, Vasilis Liaskovitis wrote: Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. This patch implements a tail queue to store guest notifications for memory hot-add and hot-remove

Re: [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-24 Thread Vasilis Liaskovitis
On Sat, Sep 22, 2012 at 02:15:28PM +, Blue Swirl wrote: + +/* Function to configure memory offsets of hotpluggable dimms */ + +target_phys_addr_t pc_set_hp_memory_offset(uint64_t size) +{ +target_phys_addr_t ret; + +/* on first call, initialize ram_hp_offset */ +

[RFC PATCH v3 00/19] ACPI memory hotplug

2012-09-21 Thread Vasilis Liaskovitis
meeting agenda if needed. series is based on uq/master for qemu-kvm, and master for seabios. Can be found also at: http://github.com/vliaskov/qemu-kvm/commits/memhp-v3 http://github.com/vliaskov/seabios/commits/memhp-v3 Vasilis Liaskovitis (12): Implement dimm device abstraction Implement -dimm

[RFC PATCH v3 01/19][SeaBIOS] Add ACPI_EXTRACT_DEVICE* macros

2012-09-21 Thread Vasilis Liaskovitis
This allows to extract the beginning, end and name of a Device object. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- tools/acpi_extract.py | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/tools/acpi_extract.py b

[RFC PATCH v3 03/19][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

2012-09-21 Thread Vasilis Liaskovitis
Extend the DSDT to include methods for handling memory hot-add and hot-remove notifications and memory device status requests. These functions are called from the memory device SSDT methods. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 70

[RFC PATCH v3 04/19][SeaBIOS] acpi: generate hotplug memory devices

2012-09-21 Thread Vasilis Liaskovitis
255 devices) v1-v2: Seabios reads mems_sts from qemu to build e820_map SSDT size and some offsets are calculated with extraction macros. v2-v3: Minor name changes Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi.c | 158

[RFC PATCH v3 10/19] fix live-migration when populated=on is missing

2012-09-21 Thread Vasilis Liaskovitis
ramblock in its ram_list. Activate the dimm on the destination during ram_load. Perhaps several fields of the DimmDevice should be part of a VMStateDescription to handle migration in a cleaner way. But the problem is that ramblocks are checked before qdev vmstates. Signed-off-by: Vasilis

[RFC PATCH v3 09/19] pc: Add dimm paravirt SRAT info

2012-09-21 Thread Vasilis Liaskovitis
Documentation of the new fwcfg layout is included in docs/specs/fwcfg.txt Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/fwcfg.txt | 28 hw/pc.c | 14 -- 2 files changed, 40 insertions(+), 2 deletions

[RFC PATCH v3 11/19] Implement qmp and hmp commands for notification lists

2012-09-21 Thread Vasilis Liaskovitis
state (not yet implemented). Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx |2 + hmp.c| 17 ++ hmp.h|1 + hw/dimm.c| 62 +- hw/dimm.h

[RFC PATCH v3 17/19][SeaBIOS] Implement _PS3 method for memory device

2012-09-21 Thread Vasilis Liaskovitis
Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 15 +++ src/ssdt-mem.dsl |4 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 0d37bbc..8a18770 100644 --- a/src/acpi

[RFC PATCH v3 18/19] Implement _PS3 for dimm

2012-09-21 Thread Vasilis Liaskovitis
This will allow us to update dimm state on OSPM-initiated eject operations e.g. with echo 1 /sys/bus/acpi/devices/PNP0C80\:00/eject Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/acpi_hotplug.txt |7 +++ hw/acpi_piix4.c |5

[RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-21 Thread Vasilis Liaskovitis
. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/pc.c | 41 + hw/pc.h |6 ++ hw/pc_piix.c | 20 ++-- vl.c |1 + 4 files changed, 62 insertions(+), 6 deletions(-) diff --git a/hw

[RFC PATCH v3 19/19][SeaBIOS] Calculate pcimem_start and pcimem64_start from SRAT entries

2012-09-21 Thread Vasilis Liaskovitis
is that no new paravirt interface is introduced. Suggestions to make the code change cleaner are welcome. The alternative patch (will be sent as a reply to this patch) implements a paravirt interface to read the starting values of pcimem_start and pcimem64_start from QEMU. Signed-off-by: Vasilis

[RFC PATCH v3 16/19] Update dimm state on reset

2012-09-21 Thread Vasilis Liaskovitis
acpi_pm device. This way the dimm is still active after a VM reboot and dimm visibility has always the same behaviour, regardless of _OST support in the guest. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c |1 + hw/dimm.c | 20

[RFC PATCH v3 15/19] Add _OST dimm support

2012-09-21 Thread Vasilis Liaskovitis
flag on hot-remove fail. This allows failed hot operations to be retried at anytime. This only works for guests that use _OST notification. Also adds new _OST registers in docs/specs/acpi_hotplug.txt Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs

[RFC PATCH v3 14/19][SeaBIOS] Add _OST dimm method

2012-09-21 Thread Vasilis Liaskovitis
Add support for _OST method. _OST method will write into the correct I/O byte to signal success / failure of hot-add or hot-remove to qemu. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 50 ++ src

[RFC PATCH v3 13/19] balloon: update with hotplugged memory

2012-09-21 Thread Vasilis Liaskovitis
not online hotplugged-memory, it's easy for a balloon inflate command to OOM a guest. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/virtio-balloon.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio

[RFC PATCH v3 12/19] Implement info memory-total and query-memory-total

2012-09-21 Thread Vasilis Liaskovitis
, since a guest can be using ACPI memory hotplug without using a balloon device. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx |2 ++ hmp.c|7 +++ hmp.h|1 + hw/dimm.c| 21 + hw/dimm.h

[RFC PATCH v3 07/19] acpi_piix4: Implement memory device hotplug registers

2012-09-21 Thread Vasilis Liaskovitis
). _EJ array is reduced to a single byte. Add documentation in docs/specs/acpi_hotplug.txt v2-v3: minor name changes Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/acpi_hotplug.txt | 22 + hw/acpi_piix4.c | 73

[RFC PATCH v3 05/19] Implement dimm device abstraction

2012-09-21 Thread Vasilis Liaskovitis
operation detaches and frees the MemoryRegion from system memory, and removes the DimmDevice from the DimmBus. Hotplug operations are done through normal device_add /device_del commands. Also add properties to DimmDevice. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw

[RFC PATCH v3 06/19] Implement -dimm command line option

2012-09-21 Thread Vasilis Liaskovitis
Example: -dimm id=dimm0,size=512M,node=0,populated=off will define a 512M memory slot belonging to numa node 0. When populated=on, a DimmDevice is created and hot-plugged at system startup. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/Makefile.objs |2

[RFC PATCH v3 02/19][SeaBIOS] Add SSDT memory device support

2012-09-21 Thread Vasilis Liaskovitis
extraction macros are used to place the AML code in variables later used by src/acpi. The design is taken from SSDT cpu generation. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- Makefile |2 +- src/ssdt-mem.dsl | 65

[RFC PATCH v3 19/19] alternative: Introduce paravirt interface QEMU_CFG_PCI_WINDOW

2012-09-21 Thread Vasilis Liaskovitis
Qemu already calculates the 32-bit and 64-bit PCI starting offsets based on initial memory and hotplug-able dimms. This info needs to be passed to Seabios for PCI initialization. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/fwcfg.txt |9 + hw

[RFC PATCH v3 20/19][SeaBIOS] alternative: Use paravirt interface for pci windows

2012-09-21 Thread Vasilis Liaskovitis
Initialize the 32-bit and 64-bit pci starting offsets from values passed in by the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the starting offsets based on initial memory and hotplug-able dimms. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src

Re: [RFC PATCH v2 03/21][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

2012-07-20 Thread Vasilis Liaskovitis
On Tue, Jul 17, 2012 at 03:23:00PM +0800, Wen Congyang wrote: +Method(MESC, 0) { +// Local5 = active memdevice bitmap +Store (MES, Local5) +// Local2 = last read byte from bitmap +Store (Zero, Local2) +// Local0 =

Re: [Qemu-devel] [RFC PATCH v2 06/21] dimm: Implement memory device abstraction

2012-07-13 Thread Vasilis Liaskovitis
Hi, On Thu, Jul 12, 2012 at 07:55:42PM +, Blue Swirl wrote: On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: Each hotplug-able memory slot is a SysBusDevice. A hot-add operation for a particular dimm creates a new MemoryRegion

Re: [Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-13 Thread Vasilis Liaskovitis
On Thu, Jul 12, 2012 at 08:04:56PM +, Blue Swirl wrote: On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: This is v2 of the ACPI memory hotplug prototype for x86_64 target. I think the concept of DIMMs (what about SIMMs? SODIMMs? I liked

Re: [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value

2012-07-12 Thread Vasilis Liaskovitis
On Thu, Jul 12, 2012 at 09:22:14AM +0200, Gerd Hoffmann wrote: On 07/11/12 18:45, Vasilis Liaskovitis wrote: Hi, On Wed, Jul 11, 2012 at 01:56:19PM +0200, Gerd Hoffmann wrote: On 07/11/12 12:31, Vasilis Liaskovitis wrote: In order to hotplug memory between RamSize

[RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-11 Thread Vasilis Liaskovitis
http://github.com/vliaskov/seabios/commits/memhp-v2 Vasilis Liaskovitis (14): dimm: Implement memory device abstraction acpi_piix4: Implement memory device hotplug registers pc: calculate dimm physical addresses and adjust memory map pc: Add dimm paravirt SRAT info Implement -dimm

[RFC PATCH v2 03/21][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

2012-07-11 Thread Vasilis Liaskovitis
Extend the DSDT to include methods for handling memory hot-add and hot-remove notifications and memory device status requests. These functions are called from the memory device SSDT methods. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 70

[RFC PATCH v2 07/21] acpi_piix4: Implement memory device hotplug registers

2012-07-11 Thread Vasilis Liaskovitis
). _EJ array is reduced to a single byte. Add documentation in docs/specs/acpi_hotplug.txt Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/acpi_hotplug.txt | 22 + hw/acpi_piix4.c | 73 -- 2

[RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Vasilis Liaskovitis
-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx |2 + hmp.c| 17 hmp.h|1 + hw/dimm.c| 55 ++ hw/dimm.h|6 + monitor.c|7

[RFC PATCH v2 14/21][SeaBIOS] acpi_dsdt: Support _OST dimm method

2012-07-11 Thread Vasilis Liaskovitis
Add support for _OST method. _OST method will write into the correct I/O byte to signal success / failure of hot-add or hot-remove to qemu. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 46 ++ src

[RFC PATCH v2 18/21] acpi_piix4: Update dimm bitmap state on hot-remove fail

2012-07-11 Thread Vasilis Liaskovitis
This allows failed hot operations to be retried at anytime. This only works for guests that use _OST notification. Other guests cannot retry failed hot operations on same devices until after reboot. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c

[RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options

2012-07-11 Thread Vasilis Liaskovitis
starting from 0) Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/dimm.c |9 ++ hw/dimm.h |2 +- qemu-config.c | 45 qemu-options.hx | 10 ++ vl.c| 86

[RFC PATCH v2 06/21] dimm: Implement memory device abstraction

2012-07-11 Thread Vasilis Liaskovitis
from system memory. This prototype still lacks proper qdev integration: a separate hotplug side-channel is used and main system bus hotplug capability is ignored. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/Makefile.objs |2 +- hw/dimm.c| 234

[RFC PATCH v2 12/21] fix live-migration when populated=on is missing

2012-07-11 Thread Vasilis Liaskovitis
ramblock in its ram_list. Activate the memslot on the destination during ram_load. Perhaps several fields of the DimmState struct should be part of a VMStateDescription to handle migration in a cleaner way. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- arch_init.c

[RFC PATCH v2 16/21] acpi_piix4: Update dimm state on VM reboot

2012-07-11 Thread Vasilis Liaskovitis
-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index d8e2c22..ebc5de7 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -91,6 +91,7

[RFC PATCH v2 17/21][SeaBIOS] acpi_dsdt: Revert internal dimm state on _OST failure

2012-07-11 Thread Vasilis Liaskovitis
This reverts bitmap state in the case of a failed hot operation, in order to allow retry of failed hot operations Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/acpi

[RFC PATCH v2 19/21] Implement info memtotal and query-memtotal

2012-07-11 Thread Vasilis Liaskovitis
Returns total memory of guest in bytes, including hotplugged memory. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx |2 ++ hmp.c|7 +++ hmp.h|1 + hw/dimm.c| 15 +++ monitor.c

[RFC PATCH v2 15/21] acpi_piix4: _OST dimm support

2012-07-11 Thread Vasilis Liaskovitis
-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/acpi_hotplug.txt | 24 hw/acpi_piix4.c | 15 +++ hw/dimm.c | 18 ++ hw/dimm.h |1 + 4 files changed, 58

[RFC PATCH v2 11/21] Implement dimm_add and dimm_del hmp/qmp commands

2012-07-11 Thread Vasilis Liaskovitis
Hot-add hmp syntax: dimm_add dimmid Hot-remove hmp syntax: dimm_del dimmid Respective qmp commands are dimm-add, dimm-del. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx | 32 monitor.c | 11

[RFC PATCH v2 10/21] Implement -dimm command line option

2012-07-11 Thread Vasilis Liaskovitis
proximity for this dimm. Default is node zero. Example: -dimm id=dimm0,size=512M,node=0,populated=off will define a 512M memory slot belonging to numa node 0. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- qemu-config.c | 25 + qemu

[RFC PATCH v2 09/21] pc: Add dimm paravirt SRAT info

2012-07-11 Thread Vasilis Liaskovitis
Documentation of the new fwcfg layout is included in docs/specs/fwcfg.txt Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/fwcfg.txt | 28 ++ hw/pc.c | 53 - vl.c

[RFC PATCH v2 08/21] pc: calculate dimm physical addresses and adjust memory map

2012-07-11 Thread Vasilis Liaskovitis
Dimm physical address offsets are calculated automatically and memory map is adjusted accordingly. If a DIMM can fit before the PCI_HOLE_START (currently 0xe000), it will be added normally, otherwise its physical address will be above 4GB. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi

[RFC PATCH v2 04/21][SeaBIOS] acpi: generate hotplug memory devices

2012-07-11 Thread Vasilis Liaskovitis
255 devices) v1-v2: Seabios reads mems_sts from qemu to build e820_map SSDT size and some offsets are calculated with extraction macros. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi.c | 158 +-- 1 files

[RFC PATCH v2 02/21][SeaBIOS] Add SSDT memory device support

2012-07-11 Thread Vasilis Liaskovitis
extraction macros are used to place the AML code in variables later used by src/acpi. The design is taken from SSDT cpu generation. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- Makefile |2 +- src/ssdt-mem.dsl | 65

Re: [RFC PATCH v2 04/21][SeaBIOS] acpi: generate hotplug memory devices

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 06:48:38PM +0800, Wen Congyang wrote: +if (enabled) +add_e820(mem_base, mem_len, E820_RAM); add_e820() is declared in memmap.h. You should include this header file, otherwise, seabios cannot be built. thanks. you had the same comment on v1

Re: [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 01:56:19PM +0200, Gerd Hoffmann wrote: On 07/11/12 12:31, Vasilis Liaskovitis wrote: In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci window needs to start at BUILD_PCIMEM_START (0xe000). Otherwise, the guest cannot online new dimms

Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 08:59:03AM -0600, Eric Blake wrote: On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote: Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. This patch implements a tail queue to store guest notifications for memory hot-add and hot-remove

Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement info memtotal and query-memtotal

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 09:14:29AM -0600, Eric Blake wrote: On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote: Returns total memory of guest in bytes, including hotplugged memory. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com Should this instead be merged

Re: [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 05:55:25PM +0300, Avi Kivity wrote: On 07/11/2012 01:32 PM, Vasilis Liaskovitis wrote: Implement batch dimm creation command line options. These could be useful for not bloating the command line with a large number of dimms. IMO this is unneeded

Re: [RFC PATCH 0/9] ACPI memory hotplug

2012-04-24 Thread Vasilis Liaskovitis
Hi, On Tue, Apr 24, 2012 at 10:52:24AM +0300, Gleb Natapov wrote: On Mon, Apr 23, 2012 at 02:31:15PM +0200, Vasilis Liaskovitis wrote: The 440fx spec mentions: The address range from the top of main DRAM to 4 Gbytes (top of physical memory space supported by the 440FX PCIset) is normally

Re: [RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory devices.

2012-04-24 Thread Vasilis Liaskovitis
Hi, On Mon, Apr 23, 2012 at 07:37:51PM -0400, Kevin O'Connor wrote: On Thu, Apr 19, 2012 at 04:08:41PM +0200, Vasilis Liaskovitis wrote: The memory device generation is guided by qemu paravirt info. Seabios first uses the info to setup SRAT entries for the hotplug-able memory slots

Re: [RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove

2012-04-23 Thread Vasilis Liaskovitis
On Sun, Apr 22, 2012 at 04:58:47PM +0300, Gleb Natapov wrote: On Thu, Apr 19, 2012 at 04:08:46PM +0200, Vasilis Liaskovitis wrote: Hotplugged memory is not persistent in the e820 memory maps. After hotplugging a memslot and rebooting the VM, the hotplugged device is not present

Re: [RFC PATCH 0/9] ACPI memory hotplug

2012-04-23 Thread Vasilis Liaskovitis
Hi, On Sun, Apr 22, 2012 at 05:20:59PM +0300, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: On 04/22/2012 05:09 PM, Gleb Natapov wrote: On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote: On 04/22/2012 04:56 PM, Gleb Natapov wrote: start.

Re: [Qemu-devel] [RFC PATCH 2/9][SeaBIOS] Implement acpi-dsdt functions for memory hotplug.

2012-04-20 Thread Vasilis Liaskovitis
Hi, On Fri, Apr 20, 2012 at 12:55:24PM +0200, Igor Mammedov wrote: +/* Memory eject notify method */ +OperationRegion(MEMJ, SystemIO, 0xaf40, 32) +Field (MEMJ, ByteAcc, NoLock, Preserve) +{ +MPE, 256 +} + +Method (MPEJ, 2,

Re: [RFC PATCH 0/9] ACPI memory hotplug

2012-04-20 Thread Vasilis Liaskovitis
On Thu, Apr 19, 2012 at 04:08:38PM +0200, Vasilis Liaskovitis wrote: series is based on uq/master for qemu-kvm, and master for seabios. Can be found also at: forgot to paste the repo links in the original coverletter, here they are if someone wants them: https://github.com/vliaskov/qemu-kvm

Re: [Qemu-devel] [RFC PATCH 6/9] pc: pass paravirt info for hotplug memory slots to BIOS

2012-04-20 Thread Vasilis Liaskovitis
On Fri, Apr 20, 2012 at 12:33:57PM +0200, Igor Mammedov wrote: On 04/19/2012 04:08 PM, Vasilis Liaskovitis wrote: -numa_fw_cfg = g_malloc0((1 + max_cpus + nb_numa_nodes) * 8); +numa_fw_cfg = g_malloc0((2 + max_cpus + nb_numa_nodes + 3 * nb_hp_memslots) * 8); numa_fw_cfg[0

[RFC PATCH 0/9] ACPI memory hotplug

2012-04-19 Thread Vasilis Liaskovitis
map entries. A better solution is needed for hot-remove after a reboot, because e820 entries can be merged. series is based on uq/master for qemu-kvm, and master for seabios. Can be found also at: Vasilis Liaskovitis (9): Seabios: Add SSDT memory device support Seabios, acpi: Implement acpi

[RFC PATCH 3/9][SeaBIOS] acpi: generate hotplug memory devices.

2012-04-19 Thread Vasilis Liaskovitis
entry) is generated for each hotplug-able qemu memslot. Currently no SSDT memory device is created for initial system memory (the method can be generalized to all memory though). Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi.c | 151

[RFC PATCH 1/9][SeaBIOS] Add SSDT memory device support

2012-04-19 Thread Vasilis Liaskovitis
/ssdt-mem.dsl with directions for generating the per-memory device processor object AML code. The design is taken from SSDT cpu generation. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/ssdt-mem.dsl | 66 ++ 1

[RFC PATCH 4/9] Implement memslot device abstraction

2012-04-19 Thread Vasilis Liaskovitis
-remove operation detaches and frees the MemoryRegion from system memory. This is an early prototype and lacks proper qdev integration: a separate hotplug mechanism/side-channel is used and main system bus hotplug capability is ignored. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi

[RFC PATCH 5/9] acpi_piix4: Implement memory device hotplug registers

2012-04-19 Thread Vasilis Liaskovitis
implemented in this version). Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 93 -- 1 files changed, 89 insertions(+), 4 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 797ed24..a14dd3c

[RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove

2012-04-19 Thread Vasilis Liaskovitis
, but it is not a sufficient solution in general: Seabios and GuestOS merge adjacent e820 entries on machine reboot, so the sequence hot-add/ rebootVM / hot-remove will fail to remove a corresponding e820 entry at the hot-remove phase. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw

[RFC PATCH 9/9][SeaBIOS] enable memory devices if e820 entry is present

2012-04-19 Thread Vasilis Liaskovitis
On a reboot, seabios regenerates srat/ssdt objects. If a valid e820 entry is found spanning the whole address range of a hotplug memory device, the device will be enabled. This ensures persistency of hotplugged memory slots across VM reboots. Signed-off-by: Vasilis Liaskovitis

[RFC PATCH 7/9] Implement memslot command-line option and memslot hmp command

2012-04-19 Thread Vasilis Liaskovitis
. Defining no node will automatically add a memslot to node 0. Also implement a new hmp monitor command for hot-add and hot-remove of memory slots Syntax: memslot slotname action where action is add/delete and slotname is the qdev-id of the memory slot. Signed-off-by: Vasilis Liaskovitis

[RFC PATCH 6/9] pc: pass paravirt info for hotplug memory slots to BIOS

2012-04-19 Thread Vasilis Liaskovitis
to SeaBIOS. This information is used by Seabios to build hotplug memory device objects at runtime. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/pc.c | 59 +-- vl.c|4 +++- 2 files changed, 56

[RFC PATCH 2/9][SeaBIOS] Implement acpi-dsdt functions for memory hotplug.

2012-04-19 Thread Vasilis Liaskovitis
to recent master patch for other ACPI hotplug events. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 68 +++- 1 files changed, 66 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-19 Thread Vasilis Liaskovitis
Hi, On Thu, Apr 19, 2012 at 09:49:31AM -0500, Anthony Liguori wrote: On 04/19/2012 09:08 AM, Vasilis Liaskovitis wrote: This is a prototype for ACPI memory hotplug on x86_64 target. Based on some earlier work and comments from Gleb. Memslot devices are modeled with a new qemu command line

Re: [RFC PATCH 7/9] Implement memslot command-line option and memslot hmp command

2012-04-19 Thread Vasilis Liaskovitis
Hi, On Thu, Apr 19, 2012 at 05:22:52PM +0300, Avi Kivity wrote: On 04/19/2012 05:08 PM, Vasilis Liaskovitis wrote: Implement -memslot qemu-kvm command line option to define hotplug-able memory slots. Syntax: -memslot id=name,start=addr,size=sz,node=nodeid e.g. -memslot id=hot1

live migration between qemu-kvm 1.0 and 0.15

2012-03-27 Thread Vasilis Liaskovitis
Hi, is live migration between qemu-kvm stable-0.15 and stable-1.0 trees possible? When I live migrate a VM from 1.0 to 0.15, the destination side 0.15 qemu-kvm exits with: (qemu) Unknown savevm section or instance 'i8259' 0 That's expected, since commit i8259:convert to qdev

Re: [PATCH][SeaBIOS] memory hotplug

2012-03-16 Thread Vasilis Liaskovitis
Hi, On Thu, Mar 15, 2012 at 02:01:38PM +0200, Gleb Natapov wrote: Commenting a little bit late, but since you've said that you are working on a new version of the patch... better late than never. On Thu, Aug 11, 2011 at 04:39:38PM +0200, Vasilis Liaskovitis wrote: Hi, I am testing

live migration between amd fam15h-fam10h

2012-03-01 Thread Vasilis Liaskovitis
Hi, I am getting a frozen guest when migrating from an Opteron 6274 host (amd fam15h) to an Opteron 6174 host (amd fam10h). The live migration completes succesfully, but the guest is frozen: vcn screen is still there, but no input is possible and no kernel output is seen. Trying c on the

Re: [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4

2012-01-30 Thread Vasilis Liaskovitis
On Thu, Jan 26, 2012 at 12:46:18PM +0200, Avi Kivity wrote: On 01/24/2012 04:56 PM, Vasilis Liaskovitis wrote: On Tue, Jan 24, 2012 at 11:28:41AM +0100, Jan Kiszka wrote: On 2012-01-24 11:10, Vasilis Liaskovitis wrote: Add stub functions for CPU eject callback. Define cpu_acpi_eject

[PATCH v2 0/4] acpi_piix4: Add CPU eject infrastructure for pc-1.1

2012-01-24 Thread Vasilis Liaskovitis
series, specifically: http://patchwork.ozlabs.org/patch/136463/ Vasilis Liaskovitis (3): uq/master: Add machine model pc-1.1 uq/master: Add CPU eject handling for acpi_piix4 uq/master: Add acpi cpu interface documentation docs/specs/acpi_hotplug.txt | 49

[PATCH v2 1/4][SeaBios] Add bitmap for CPU EJ0 callback

2012-01-24 Thread Vasilis Liaskovitis
Add bitmap for CPU EJ0 callback and write to it on a cpu _EJ0 callback. Remove Sleep() call. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi

[PATCH 2/4] uq/master: Add machine model pc-1.1

2012-01-24 Thread Vasilis Liaskovitis
Add machine model pc-1.1 Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/pc_piix.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 744b0dc..ac251c6 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c

[PATCH 4/4] uq/master: Add acpi cpu interface documentation

2012-01-24 Thread Vasilis Liaskovitis
Add CPU acpi interface documentation. Move all ACPI documentation (CPU and PCI) to one file. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- docs/specs/acpi_hotplug.txt | 49 +++ docs/specs/acpi_pci_hotplug.txt | 37

[PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4

2012-01-24 Thread Vasilis Liaskovitis
Add stub functions for CPU eject callback. Define cpu_acpi_eject property and enable eject callback only for pc-1.1 machine model. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 20 hw/pc_piix.c|8 2 files

Re: [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4

2012-01-24 Thread Vasilis Liaskovitis
On Tue, Jan 24, 2012 at 11:28:41AM +0100, Jan Kiszka wrote: On 2012-01-24 11:10, Vasilis Liaskovitis wrote: Add stub functions for CPU eject callback. Define cpu_acpi_eject property and enable eject callback only for pc-1.1 machine model. Just to get the idea: What is the plan

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-19 Thread Vasilis Liaskovitis
On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote: [...] Method (CPEJ, 2, NotSerialized) { // _EJ0 method - eject callback +Store(ShiftLeft(1, Arg0), PRE) Sleep(200) } I have another question here: the PCI _EJO

Re: [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback

2012-01-16 Thread Vasilis Liaskovitis
On Sun, Jan 15, 2012 at 02:38:52PM +0200, Avi Kivity wrote: On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote: Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-16 Thread Vasilis Liaskovitis
On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote: On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote: Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com The SeaBIOS change is okay with me, but the qemu/kvm change needs to be accepted

[PATCH 0/3] acpi_piix4: Add CPU eject handling

2012-01-13 Thread Vasilis Liaskovitis
to handle the CPU_DEAD event in Liu Ping Fan's cpu lifecycle/destruction patchseries, see: http://patchwork.ozlabs.org/patch/127832/ This ACPI implementation can be used instead of the cpustate virtio/pci device in the original series. Vasilis Liaskovitis (2): acpi_piix4: Add CPU ejection

[PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-13 Thread Vasilis Liaskovitis
Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 7082b65..71d8ac4 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl

[PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback

2012-01-13 Thread Vasilis Liaskovitis
Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index d5743b6..8bf30dd 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -37,6

[PATCH 3/3] acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection

2012-01-13 Thread Vasilis Liaskovitis
Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 8bf30dd..12eef55 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c

Re: [PATCH 3/3] acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection

2012-01-13 Thread Vasilis Liaskovitis
On Fri, Jan 13, 2012 at 12:58:53PM +0100, Jan Kiszka wrote: On 2012-01-13 12:11, Vasilis Liaskovitis wrote: Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c | 21 + 1 files changed, 21 insertions(+), 0 deletions

Re: [PATCH 0/3] acpi_piix4: Add CPU eject handling

2012-01-13 Thread Vasilis Liaskovitis
On Fri, Jan 13, 2012 at 12:58:10PM +0100, Jan Kiszka wrote: Please work against upstream (uq/master for kvm-related patches), not qemu-kvm. It possibly makes no technical difference here, but we do not want to let the code bases needlessly diverge again. If if does make a difference and

[PATCH] KVM, CPU hotplug: Avoid wraparound in pvclock_get_nsec_offset

2011-12-12 Thread Vasilis Liaskovitis
Hotplugging a vCPU with kvmclock enabled can cause a guest stall/hang. When the stall happens, pvclock_clocksource_read() is called for the new vCPU and pvclock_get_nsec_offset calculates native_read_tsc() - shadow-tsc_timestamp. shadow-tsc_timestamp contains a value larger than native_read_tsc(),

Re: [PATCH] KVM, CPU hotplug: Avoid wraparound in pvclock_get_nsec_offset

2011-12-12 Thread Vasilis Liaskovitis
On Mon, Dec 12, 2011 at 02:53:29PM +0100, Jan Kiszka wrote: Can't comment on the semantics, but your patch is whitespace damaged and doesn't follow kernel coding style. But I assume it's not for application yet, right? right. It fixes the hang for me, but I am not sure it's the best

  1   2   >