On 10/28/2013 04:01 PM, Asias He wrote:
> vqs are freed in virtscsi_freeze but the hotcpu_notifier is not
> unregistered. We will have a use-after-free usage when the notifier
> callback is called after virtscsi_freeze.
>
> Signed-off-by: Asias He
Reviewed-by: Wanlong Gao
&
00 00 49 63 c4 48 c1 e0 04 48 8b bc 0
> 3 10 02 00 00 <48> 8b 47 20 48 8b 80 d0 01 00 00 48 8b 40 50 48 85 c0 74 07 be
> RIP [] __virtscsi_set_affinity+0x6f/0x120
> RSP
> CR2: 0020
> ---[ end trace 99679331a3775f48 ]---
>
> CC: sta...@vger.kernel.
On 04/06/2013 04:40 PM, James Bottomley wrote:
> On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote:
>> On 03/28/2013 10:22 AM, Wanlong Gao wrote:
>>> On 03/23/2013 07:28 PM, Wanlong Gao wrote:
>>>> This series implements virtio-scsi queue steering, which gives
&g
On 03/28/2013 10:22 AM, Wanlong Gao wrote:
> On 03/23/2013 07:28 PM, Wanlong Gao wrote:
>> This series implements virtio-scsi queue steering, which gives
>> performance improvements of up to 50% (measured both with QEMU and
>> tcm_vhost backends).
>>
>> This versi
On 03/23/2013 07:28 PM, Wanlong Gao wrote:
> This series implements virtio-scsi queue steering, which gives
> performance improvements of up to 50% (measured both with QEMU and
> tcm_vhost backends).
>
> This version rebased on Rusty's virtio ring rework patches, which
>
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
Tested-by: Venkatesh Srinivas
---
drivers/scsi/virtio_scsi.c | 282 -
1 file changed, 254 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio
On 03/23/2013 02:36 PM, Paolo Bonzini wrote:
> Il 20/03/2013 08:56, Wanlong Gao ha scritto:
>>> This one does not apply on top of virtio-next + patch 1-4 in this series.
>>
>> I'm very sorry.
>>
>> This fault is because I modified the 4/5 from
>>
y.
Cc: James Bottomley
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 71 --
1 file changed, 25 insertions(+), 46 deletions(-)
diff --git a/driver
ecause of the prerequisites. James, can we get your Acked-by?
Paolo Bonzini (3):
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (2):
virtio-scsi: redo all
On 03/20/2013 03:24 PM, Asias He wrote:
> On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
>> Add hot cpu notifier to reset the request virtqueue affinity
>> when doing cpu hotplug.
>>
>> Cc: linux-s...@vger.kernel.org
>> Signed-off-by: Paolo Bonzi
On 03/20/2013 03:24 PM, Asias He wrote:
> On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
>> Add hot cpu notifier to reset the request virtqueue affinity
>> when doing cpu hotplug.
>>
>> Cc: linux-s...@vger.kernel.org
>> Signed-off-by: Paolo Bonzi
+ /* Does the affinity hint is set for virtqueues? */
> Could you rephrase that, please?
Thank you, fixed in V6, please review.
>
> Tested on qemu and w/ Google Compute Engine's virtio-scsi device.
Cool.
>
> Reviewed-and-tested-by: Venkatesh Srinivas
Do you mind revi
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8
y.
Cc: James Bottomley
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 71 --
1 file changed, 25 insertions(+), 46 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/driver
an we get your Acked-by?
Paolo Bonzini (3):
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (2):
virtio-scsi: redo allocation of target data
virtio-scsi: rese
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 282 -
1 file changed, 254 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index dc2daec..13d
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions
io-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (1):
virtio-scsi: reset virtqueue affinity when doing cpu hotplug
drivers/scsi/virtio_scsi.c | 359 -
1 file changed, 290 insertions(+), 69 d
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 269 -
1 file changed, 241 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 94a64ad..1d9
-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 40 +++-
1 file changed, 11 insertions(+), 29 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index b53ba9e..3256c51 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi
d-by?
Paolo Bonzini (4):
virtio-scsi: redo allocation of target data
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (1):
virtio-scsi: reset virtqueue affinity
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a
structs in the
flexible array member at the end of struct virtio_scsi, because
we will place the virtqueues there in the next patches.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 45
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 269 -
1 file changed, 241 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 3573704..7a54293 100644
--- a/drivers/sc
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers
On 03/05/2013 05:17 PM, Asias He wrote:
> In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for
> virtio-scsi), hotplug support is added to virtio-scsi.
>
> This patch adds hotplug and hotunplug support to tcm_vhost.
>
> You can create or delate a LUN in targetcli to hotplug or hotplug a
ur Acked-by?
I can't apply this series on top of Rusty's virtio-next, I missed something
or needed rebase them ?
Thanks,
Wanlong Gao
>
> Paolo
>
> Paolo Bonzini (4):
> virtio-scsi: redo allocation of target data
> virtio-scsi: pass struct virtio_scsi to
On 01/28/2013 12:24 PM, Jason Wang wrote:
> On 01/28/2013 11:27 AM, Wanlong Gao wrote:
>> On 01/25/2013 06:35 PM, Jason Wang wrote:
>>> Hello all:
>>>
>>> This seires is an update of last version of multiqueue virtio-net support.
>>>
>>> This s
dev=hn0
>
> Management tools such as libvirt can pass multiple pre-created fds/vhostfds
> through
>
> ./qemu -netdev tap,id=hn0,fds=X:Y,vhostfds=M:N -device
> virtio-net-pci,netdev=hn0
>
> No git tree this round since github is unavailable in China...
I saw that githu
On 01/16/2013 11:31 AM, Rusty Russell wrote:
> Wanlong Gao writes:
>> Add hot cpu notifier to reset the request virtqueue affinity
>> when doing cpu hotplug.
>
> You need to be careful to get_online_cpus() and put_online_cpus() here,
> so CPUs can't go up and dow
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index
These two patches are based on the multi-queue virtio-scsi patch set.
We set cpu affinity when the num_queues equals to the number
of VCPUs. Split out the set affinity function, this also
fix the bug when CPU IDs are not consecutive.
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c
On 01/10/2013 03:16 PM, Jason Wang wrote:
> On Thursday, January 10, 2013 02:49:14 PM Wanlong Gao wrote:
>> On 01/10/2013 02:43 PM, Jason Wang wrote:
>>> On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote:
>>>> On 01/09/2013 06:01 PM, Wanlong Gao wrote:
>&
On 01/10/2013 02:43 PM, Jason Wang wrote:
> On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote:
>> On 01/09/2013 06:01 PM, Wanlong Gao wrote:
>>> On 01/09/2013 05:30 PM, Jason Wang wrote:
>>>> On 01/09/2013 04:23 PM, Wanlong Gao wrote:
>>>>
On 01/09/2013 05:30 PM, Jason Wang wrote:
> On 01/09/2013 04:23 PM, Wanlong Gao wrote:
>> On 01/08/2013 06:14 PM, Jason Wang wrote:
>>> On 01/08/2013 06:00 PM, Wanlong Gao wrote:
>>>> On 01/08/2013 05:51 PM, Jason Wang wrote:
>>>>> On 01/08/2013 05:49 P
On 01/08/2013 06:14 PM, Jason Wang wrote:
> On 01/08/2013 06:00 PM, Wanlong Gao wrote:
>> On 01/08/2013 05:51 PM, Jason Wang wrote:
>>> On 01/08/2013 05:49 PM, Wanlong Gao wrote:
>>>> On 01/08/2013 05:29 PM, Jason Wang wrote:
>>>>> On 01/08/2013 05:07 P
On 01/08/2013 06:14 PM, Jason Wang wrote:
> On 01/08/2013 06:00 PM, Wanlong Gao wrote:
>> On 01/08/2013 05:51 PM, Jason Wang wrote:
>>> On 01/08/2013 05:49 PM, Wanlong Gao wrote:
>>>> On 01/08/2013 05:29 PM, Jason Wang wrote:
>>>>> On 01/08/2013 05:07 P
On 01/08/2013 05:29 PM, Jason Wang wrote:
> On 01/08/2013 05:07 PM, Wanlong Gao wrote:
>> On 12/28/2012 06:32 PM, Jason Wang wrote:
>>> +} else if (nc->peer->info->type != NET_CLIENT_OPTIONS_KIND_TAP) {
>>> +ret = -1;
>>> +}
On 01/08/2013 05:51 PM, Jason Wang wrote:
> On 01/08/2013 05:49 PM, Wanlong Gao wrote:
>> On 01/08/2013 05:29 PM, Jason Wang wrote:
>>> On 01/08/2013 05:07 PM, Wanlong Gao wrote:
>>>> On 12/28/2012 06:32 PM, Jason Wang wrote:
>>>
On 01/08/2013 05:29 PM, Jason Wang wrote:
> On 01/08/2013 05:07 PM, Wanlong Gao wrote:
>> On 12/28/2012 06:32 PM, Jason Wang wrote:
>>> +} else if (nc->peer->info->type != NET_CLIENT_OPTIONS_KIND_TAP) {
>>> +ret = -1;
>>> +}
qemu-system-x86_64: /work/git/qemu/hw/virtio-net.c:330: virtio_net_set_queues:
Assertion `!peer_detach(n, i)' failed.
Any thoughts?
Thanks,
Wanlong Gao
> +}
> +}
> +}
> +
> +static void virtio_net_set_multiqueue(VirtIONet *n, int multiqueue, int
> ctrl);
>
io=34625MB, aggrb=247902KB/s, minb=247902KB/s, maxb=247902KB/s,
mint=143025msec, maxt=143025msec
Chained:
Run status group 0 (all jobs):
READ: io=34863MB, aggrb=242320KB/s, minb=242320KB/s, maxb=242320KB/s,
mint=147325msec, maxt=147325msec
WRITE: io=34437MB, aggrb=
On 12/27/2012 02:39 PM, Jason Wang wrote:
> Currently, polling error were ignored in vhost. This may lead some issues (e.g
> kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix
> this
> by:
Can this kernel crash be reproduced by hand?
Thanks,
Wanlong Gao
&
if (err)
>>>>>> return err;
>>>>>>
>>>>>> -virtscsi_init_vq(&vscsi->ctrl_vq, vqs[0]);
>>>>>> -virtscsi_init_vq(&vscsi->event_vq, vqs[1]);
>>>>>>
n here.
> Without this data it is possible that your host
> is undersubscribed and you are drinking up more host CPU.
>
> Another thing to note is that ATM you might need to
> test with idle=poll on host otherwise we have strange interaction
> with power management where reducing
d the improvement, because the code you
> touched (complete_event) shouldn't ever run during a normal benchmark.
> It's only used for hotplug/hot-unplug.
>
> Nevertheless, I'll queue the cleanup patches. Thanks for those.
Oops, got it, I will investigate more. Thank you
On 11/07/2012 08:23 PM, Asias He wrote:
> On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao wrote:
>> patch 1-3,5 are some cleanups.
>> patch 4: create a separate work queue for virtio-scsi
>> to improve the performance, I tested with tmpfs backed
>> disk, the config fil
=4820/3169, in_queue=7991, util=90.62%
sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63%
sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41%
Wanlong Gao (5):
virtio-scsi: remove the useless assignment
virtio-scsi: remove the needless
Just use the macro instead of define a variable.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: kvm@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Reassign err is not needed, just a cleanup.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: kvm@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi
Use pr_err() instead of printk() for code cleanups.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: kvm@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
Tidy up the goto label in init(), and remove the useless
NULL pointer assignment.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: kvm@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 28 +++-
1
Create a separate work queue for virtio-scsi to improve the performance.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: kvm@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 15 ++-
1 file changed, 14
Remove useless arguments kvm_dev and name.
Signed-off-by: Wanlong Gao
---
tools/kvm/include/kvm/kvm.h |2 +-
tools/kvm/kvm.c |2 +-
tools/kvm/powerpc/kvm.c |2 +-
tools/kvm/x86/kvm.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
Remove useless arguments kvm_dev and name.
Signed-off-by: Wanlong Gao
---
tools/kvm/include/kvm/kvm.h |2 +-
tools/kvm/kvm.c |2 +-
tools/kvm/powerpc/kvm.c |2 +-
tools/kvm/x86/kvm.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
On 12/21/2011 04:07 PM, Asias He wrote:
> lkvm alias vm is not removed in 'make clean'.
> This patch fixes this.
>
> Signed-off-by: Asias He
Reviewed-by: Wanlong Gao
> ---
> tools/kvm/Makefile |2 +-
> 1 files changed, 1 insertions(+), 1 deletions
rs in both sides, so don't remove the pr_info?
Thanks
-Wanlong Gao
>
> Signed-off-by: Asias He
> ---
> tools/kvm/builtin-pause.c |2 ++
> tools/kvm/builtin-resume.c |2 ++
> tools/kvm/builtin-run.c|1 -
> 3 files changed, 4 insertions(+), 1 deletions(-)
Introduce a new macro KVM_BINARY_NAME for the binary name of kvm tools,
also for future using in printing command messages like these.
Signed-off-by: Wanlong Gao
---
tools/kvm/builtin-help.c|7 ---
tools/kvm/builtin-run.c |6 --
tools/kvm/builtin-setup.c | 11
Commands' usage : Change the binary name from *kvm* to *lkvm*,
since commit ad3efb18 has done it.
Signed-off-by: Wanlong Gao
---
tools/kvm/builtin-balloon.c |2 +-
tools/kvm/builtin-debug.c |2 +-
tools/kvm/builtin-help.c|4 ++--
tools/kvm/builtin-list.c|2 +-
README: change the binary name from kvm to lkvm since
commit ad3efb18 has already done it.
Signed-off-by: Wanlong Gao
---
tools/kvm/README |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/kvm/README b/tools/kvm/README
index c262995..d626b77 100644
--- a/tools
Documentation: Change the binary name from *kvm* to *lkvm*,
since commit ad3efb18 already called the binary *lkvm* and
with a alias name *vm*.
Signed-off-by: Wanlong Gao
---
tools/kvm/Documentation/kernel-debugging.txt |2 +-
tools/kvm/Documentation/kvm-balloon.txt |8
nclude/sys/cdefs.h:226:0: note: this is the location of the previous
definition
cc1: all warnings being treated as errors
make: *** [builtin-run.o] Error 1
Signed-off-by: Wanlong Gao
---
tools/kvm/include/linux/compiler.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a
The -Wunused-result is the default option of gcc, so no need to
add it to the FLAGS.
And the previous version of gcc can't support this flag, it may
cause a compile error.
Signed-off-by: Wanlong Gao
---
tools/kvm/Makefile |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --
71 matches
Mail list logo
