Re: Mask bit support's API

2010-12-02 Thread Yang, Sheng
it. -- regards Yang, Sheng So maybe just add an ioctl to get and to clear pending bits. Maybe set for symmetry. For live migration too. But if they live in memory, no need for get/set, just specify the address. -- error compiling committee.c: too many arguments to function

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-01 Thread Yang, Sheng
for kernel part to work alone... http://www.mail-archive.com/kvm@vger.kernel.org/msg44368.html -- regards Yang, Sheng static int msix_mmio_write(struct kvm_io_device *this, gpa_t addr, int len, const void *val) { struct kvm_assigned_dev_kernel *adev

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-01 Thread Yang, Sheng
/kvm/msg44795.html -- regards Yang, Sheng static int msix_mmio_write(struct kvm_io_device *this, gpa_t addr, int len, const void *val) { struct kvm_assigned_dev_kernel *adev = container_of(this, struct kvm_assigned_dev_kernel

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-01 Thread Yang, Sheng
() of the 4th patch for QEmu? I suppose something wrong with it. I would try to reproduce it here. And if you only use one vf, how about the gain? -- regards Yang, Sheng 2010/12/1 Yang, Sheng sheng.y...@intel.com: On Wednesday 01 December 2010 16:41:38 lidong chen wrote: I used sr-iov, give each vm

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-01 Thread Yang, Sheng
On Wednesday 01 December 2010 17:02:57 Yang, Sheng wrote: On Wednesday 01 December 2010 16:54:16 lidong chen wrote: yes, i patch qemu as well. and i found the address of second vf is not in mmio range. the first one is fine. So looks like something wrong with MMIO register part. Could

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-01 Thread Yang, Sheng
. If you can see the mask bit accessing in kernel from both devices. -- regards Yang, Sheng #ifdef KVM_CAP_MSIX_MASK if (cap_mask) { memset(msix_mmio, 0, sizeof msix_mmio); msix_mmio.id = calc_assigned_dev_id(r_dev-h_busnr, r_dev-h_devfn

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-01 Thread Yang, Sheng
the last one. Please check the PCI spec. -- regards Yang, Sheng 2010/11/30 Yang, Sheng sheng.y...@intel.com: On Tuesday 30 November 2010 17:10:11 lidong chen wrote: sr-iov also meet this problem, MSIX mask waste a lot of cpu resource. I test kvm with sriov, which the vf driver could

Re: Performance test result between virtio_pci MSI-X disable and enable

2010-11-30 Thread Yang, Sheng
. and we can see how xen deal with MSIX mask. if this problem sloved, maybe with MSIX enabled, the performace is better. Please refer to my posted patches for this issue. http://www.spinics.net/lists/kvm/msg44992.html -- regards Yang, Sheng 2010/11/23 Avi Kivity a...@redhat.com: On 11/23/2010

Re: Mask bit support's API

2010-11-30 Thread Yang, Sheng
On Tuesday 30 November 2010 22:15:29 Avi Kivity wrote: On 11/26/2010 04:35 AM, Yang, Sheng wrote: Shouldn't kvm also service reads from the pending bitmask? Of course KVM should service reading from pending bitmask. For assigned device, it's kernel who would set the pending bit

Re: Mask bit support's API

2010-11-25 Thread Yang, Sheng
On Wednesday 24 November 2010 09:59:23 Yang, Sheng wrote: On Tuesday 23 November 2010 22:06:20 Avi Kivity wrote: On 11/23/2010 03:57 PM, Yang, Sheng wrote: Yeah, but won't be included in this patchset. What API changes are needed? I'd like to see the complete API. I am

Re: Mask bit support's API

2010-11-23 Thread Yang, Sheng
On Tuesday 23 November 2010 15:54:40 Avi Kivity wrote: On 11/23/2010 08:35 AM, Yang, Sheng wrote: On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: On 11/23/2010 08:09 AM, Yang, Sheng wrote: Hi Avi, I've purposed the following API for mask bit support

Re: Mask bit support's API

2010-11-23 Thread Yang, Sheng
On Tuesday 23 November 2010 20:47:33 Avi Kivity wrote: On 11/23/2010 10:30 AM, Yang, Sheng wrote: On Tuesday 23 November 2010 15:54:40 Avi Kivity wrote: On 11/23/2010 08:35 AM, Yang, Sheng wrote: On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: On 11/23/2010 08:09 AM

Re: Mask bit support's API

2010-11-23 Thread Yang, Sheng
On Tuesday 23 November 2010 20:04:16 Michael S. Tsirkin wrote: On Tue, Nov 23, 2010 at 02:09:52PM +0800, Yang, Sheng wrote: Hi Avi, I've purposed the following API for mask bit support. The main point is, QEmu can know which entries are enabled(by pci_enable_msix

Re: Mask bit support's API

2010-11-23 Thread Yang, Sheng
On Tuesday 23 November 2010 22:06:20 Avi Kivity wrote: On 11/23/2010 03:57 PM, Yang, Sheng wrote: Yeah, but won't be included in this patchset. What API changes are needed? I'd like to see the complete API. I am not sure about it. But I suppose the structure should

Mask bit support's API

2010-11-22 Thread Yang, Sheng
]; }; -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: Mask bit support's API

2010-11-22 Thread Yang, Sheng
On Tuesday 23 November 2010 14:17:28 Avi Kivity wrote: On 11/23/2010 08:09 AM, Yang, Sheng wrote: Hi Avi, I've purposed the following API for mask bit support. The main point is, QEmu can know which entries are enabled(by pci_enable_msix()). And for enabled entries, kernel own

Re: [PATCH 1/3] Introduce a workqueue to deliver PIT timer interrupts.

2010-06-11 Thread Yang, Sheng
using scripts/checkpatch.pl to check it. -- regards Yang, Sheng + + if (ktimer-t_ops-is_periodic(ktimer)) { + hrtimer_add_expires_ns(ktimer-timer, ktimer-period); + return HRTIMER_RESTART; + } + else + return HRTIMER_NORESTART; +} Also need

Re: [PATCH] KVM: x86: Propagate fpu_alloc errors

2010-05-25 Thread Yang, Sheng
On Tuesday 25 May 2010 22:01:50 Jan Kiszka wrote: Memory allocation may fail. Propagate such errors. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Reviewed-by: Sheng Yang sh...@linux.intel.com -- regards Yang, Sheng arch/x86/include/asm/kvm_host.h |2 +- arch/x86/kvm/svm.c

Re: [UNTESTED] KVM: do not call kvm_set_irq from irq disabled section

2010-04-21 Thread Yang, Sheng
, assigned_dev-guest_irq, 1); Or could we make kvm_set_irq() atomic? Though the code path is a little long for spinlock. - spin_unlock_irq(assigned_dev-assigned_dev_lock); } static irqreturn_t kvm_assigned_dev_intr(int irq, void *dev_id) -- regards Yang, Sheng -- To unsubscribe from

Re: [UNTESTED] KVM: do not call kvm_set_irq from irq disabled section

2010-04-21 Thread Yang, Sheng
is kvm_notify_acked_irq() with RCU. -- regards Yang, Sheng [a016ce13] ? kvm_ioapic_update_eoi+0x73/0xd0 [kvm] [a0192689] ? apic_reg_write+0x569/0x700 [kvm] [a0192939] ? apic_mmio_write+0x69/0x70 [kvm] [a0178fec] ? emulator_write_emulated_onepage+0xac/0x1b0 [kvm

Re: KVM: VMX: move CR3/PDPTR update to vmx_set_cr3

2009-10-26 Thread Yang, Sheng
. Acked-by: Sheng Yang sh...@linux.intel.com -- regards Yang, Sheng Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: b/arch/x86/kvm/vmx.c === --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -1748,6 +1748,7 @@ static

Re: cpuinfo and HVM features (was: Host latency peaks due to kvm-intel)

2009-07-27 Thread Yang, Sheng
On Monday 27 July 2009 17:08:42 Jan Kiszka wrote: [ carrying this to LKML ] Yang, Sheng wrote: On Monday 27 July 2009 03:16:27 H. Peter Anvin wrote: Jan Kiszka wrote: Avi Kivity wrote: On 07/24/2009 12:41 PM, Jan Kiszka wrote: I vaguely recall that someone promised to add a feature

Re: Host latency peaks due to kvm-intel

2009-07-26 Thread Yang, Sheng
of struct vmcs_config entries(that's pin_based_exec_ctrl, cpu_based_exec_ctrl, and cpu_based_2nd_exec_ctrl) through sys/module/kvm_intel/? Put every feature to cpuinfo seems not that necessary for such a big list. -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe

ioctl number overlapped?

2009-07-21 Thread Yang, Sheng
to v2.6.30... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] Update VMX_EPT_IDENTITY_PAGETABLE_ADDR to synchronize with kernel code.

2009-07-16 Thread Yang, Sheng
because we want older version QEmu can also work with EPT. Yes, we need a new CAP for address. Would do it soon. -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-22 Thread Yang, Sheng
On Tuesday 23 June 2009 00:09:28 Alex Williamson wrote: On Mon, 2009-06-22 at 13:32 +0800, Yang, Sheng wrote: On Friday 19 June 2009 21:44:40 Alex Williamson wrote: On Fri, 2009-06-19 at 15:27 +0800, Yang, Sheng wrote: On Friday 19 June 2009 00:28:41 Alex Williamson wrote: The one

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-21 Thread Yang, Sheng
On Friday 19 June 2009 21:44:40 Alex Williamson wrote: On Fri, 2009-06-19 at 15:27 +0800, Yang, Sheng wrote: On Friday 19 June 2009 00:28:41 Alex Williamson wrote: The one oddity I noticed is that even when the enable bit is clear, the guest can read the ROM. I don't know

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-19 Thread Yang, Sheng
On Friday 19 June 2009 00:28:41 Alex Williamson wrote: On Thu, 2009-06-18 at 13:30 +0800, Yang, Sheng wrote: On Tuesday 16 June 2009 00:29:17 Alex Williamson wrote: The PCI code already knows about option ROMs, so we just need to mmap some space for it, load it with a copy of the contents

Re: KVM: x86: verify MTRR/PAT validity

2009-06-17 Thread Yang, Sheng
, both untested) Maybe we can put cpuid_max_physaddr as a field in vcpu struct? -- regards Yang, Sheng Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -722,11 +722,53 @@ static

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-17 Thread Yang, Sheng
think the guest would be killed for QEmu would receive a SIGSEGV? I am not sure if it's too severe... -- regards Yang, Sheng --- hw/device-assignment.c | 60 hw/device-assignment.h | 5 +--- 2 files changed, 46 insertions(+), 19

Re: [patch 0/5] VMX EPT misconfigurtion handler

2009-06-10 Thread Yang, Sheng
and print useful information for diagnostics. Looks fine to me, thanks! -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: device-assignment deadlock

2009-05-12 Thread Yang, Sheng
? Thanks, This part again... I think simply move kvm_deassign_irq() out of critical region is OK, and I also add the lock which seems missing in deassign_guest_irq(). Would post a patch soon. -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH 1/1] KVM: Fix potentially recursively get kvm lock

2009-05-12 Thread Yang, Sheng
already fixed by you. Continue to check the code... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs

2009-05-12 Thread Yang, Sheng
On Wednesday 13 May 2009 12:10:34 Alex Williamson wrote: On Tue, 2009-05-12 at 21:42 -0600, Alex Williamson wrote: On Wed, 2009-05-13 at 11:30 +0800, Yang, Sheng wrote: + kvm-used_gsi_bitmap = malloc(gsi_bytes); + if (!kvm-used_gsi_bitmap

Re: [PATCH] kvm: Use a bitmap for tracking used GSIs

2009-05-11 Thread Yang, Sheng
(i 3); 3 or 5? I am a little confused by these magic numbers, including 0x1f... I think there are something can indicate the length of unsigned long in QEmu(sorry, can't find it now...), so how about using ffsl() and get other constants based on it? -- regards Yang, Sheng

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-08 Thread Yang, Sheng
(and I have some misunderstandings with ZhaoYu for I thought we are agree on the reason, but after confirm with him, he didn't agree). I am doing more investigations to find the real cause. -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-08 Thread Yang, Sheng
On Monday 09 March 2009 11:42:05 Yang, Sheng wrote: On Sunday 08 March 2009 22:30:16 Avi Kivity wrote: Matthew Wilcox wrote: On Tue, Feb 24, 2009 at 12:47:38PM +0200, Avi Kivity wrote: Do those patches allow using a VF on the host (in other words, does the kernel emulate config space

Re: KVM: protect assigned dev workqueue, int handler and irq acker

2009-03-01 Thread Yang, Sheng
On Saturday 28 February 2009 01:54:31 Marcelo Tosatti wrote: On Fri, Feb 27, 2009 at 12:17:01PM +0800, Yang, Sheng wrote: On Friday 27 February 2009 07:50:54 Marcelo Tosatti wrote: Can someone with HW test this please? Good catch! The patch works fine on my side. Can it be a per

Re: KVM: protect assigned dev workqueue, int handler and irq acker

2009-02-26 Thread Yang, Sheng
for trouble (could not spot any obvious problem, but better not have to, its fragile). Well, my original purpose is a FIFO between interrupt handler and work(for MSI-X), but seems too complex... And I also don't see any problem for now... -- regards Yang, Sheng diff --git a/include/linux/kvm_host.h

Re: assigned dev msi int handling

2009-02-26 Thread Yang, Sheng
are needed for MSI-X(seems we need one ack notifier for one vector in MSI-X). -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: gettimeofday slow in RHEL4 guests

2008-12-29 Thread Yang, Sheng
(-kvm-pit-no-reinject or something). I agree that it should go with a user space option to disable rejection, as it's hard to overcome the problem that we delayed interrupt injection... -- regards Yang, Sheng Comments or better ideas? diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c

Re: LAPIC soft-disable vs. LVT masking

2008-10-20 Thread Yang, Sheng
will give a update if I got more infos. -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] Enable MSI support for KVM VT-d

2008-10-19 Thread Yang, Sheng
Amit's patch is there. (I will conclude the change of userspace in the first mail). -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: VMX: Move private memory slot position

2008-10-13 Thread Yang, Sheng
On Saturday 13 September 2008 16:55:27 Avi Kivity wrote: Avi Kivity wrote: Yang, Sheng wrote: On Thursday 04 September 2008 11:30:20 Yang, Sheng wrote: From ebe4ea311305d2910dcdcff2510662da0dc2c742 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 4 Sep 2008 03:11

Re: [PATCH 4/4] KVM: x86: Enable MSI for assigned device

2008-10-05 Thread Yang, Sheng
. -- regards Yang, Sheng -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip

2008-10-02 Thread Yang, Sheng
Desktop in the company also down, have to post patch with outlook)... Thanks! -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] KVM: Separate interrupt sources

2008-10-02 Thread Yang, Sheng
From e6b784985c14afe9805bfc8706858884b0259ab5 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 2 Oct 2008 14:20:22 +0800 Subject: [PATCH 1/2] KVM: Separate interrupt sources Keep a record of current interrupt state before update, and don't assert/deassert repeatly. So that

[no subject]

2008-10-02 Thread Yang, Sheng
From eab008da232cd9cc09dd8071bd15796c8e46f6bd Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 2 Oct 2008 14:21:06 +0800 Subject: [PATCH 2/2] KVM: Implement OR logic on guest shared IRQ line Now IOAPIC and PIC treat every kvm_set_irq() as from one separate interrupt source,

Re: Remaining passthrough/VT-d tasks list

2008-09-28 Thread Yang, Sheng
On Wednesday 24 September 2008 17:51:24 Avi Kivity wrote: Yang, Sheng wrote: 2. shared guest pci interrupts That's a correctness issue. No matter how many interrupts we have, we may have sharing issues. Of course with only three the issue is very pressing since we will get sharing

Re: Remaining passthrough/VT-d tasks list

2008-09-27 Thread Yang, Sheng
On Wednesday 24 September 2008 16:38:35 Avi Kivity wrote: Yang, Sheng wrote: - Shared Interrupt support I still don't know who would do this. It's very important for VT-d real usable. If nobody interested in it, I would pick it up, but after Oct. 6 (after National Holiday

Re: Remaining passthrough/VT-d tasks list

2008-09-27 Thread Yang, Sheng
if it would affect the pending transaction, also not sure all device support this (though they should support). -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: Remaining passthrough/VT-d tasks list

2008-09-27 Thread Yang, Sheng
... But at least, I think a physical continuous one should be much different from any working ones... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] kvm: bios: switch MTRRs to cover only the PCI range and default to WB

2008-09-26 Thread Yang, Sheng
, step 4 enter no-fill cache mode(set CR0.CD bit and clean NW bit), step 12 re-enabled the caching(clear this two bits). We based on these behaviors to detect MTRR update. (Forgot to raise the bug to Avi, recalled it now...) -- regards Yang, Sheng -- To unsubscribe from this list: send the line

Re: KVM Migration fails

2008-09-25 Thread Yang, Sheng
. :) -- regards Yang, Sheng /Jd --- On Wed, 9/24/08, Yang, Sheng [EMAIL PROTECTED] wrote: From: Yang, Sheng [EMAIL PROTECTED] Subject: Re: KVM Migration fails To: kvm@vger.kernel.org, [EMAIL PROTECTED] [EMAIL PROTECTED] Date: Wednesday, September 24, 2008, 11:23 PM On Thursday 25 September

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-25 Thread Yang, Sheng
and device got this problem, like irq. -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Yang, Sheng
pick it up, but after Oct. 6 (after National Holiday in China). -- regards Yang, Sheng - Add dummy driver to hide/unbind passthrough device from host kernel If I omit some good features or you have some good proposals, please feel free to add them to this list. If you are interest

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Yang, Sheng
, that is pre-assigned device shared IRQ with other devices. Why share guest interrupts is a prerequisite... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Yang, Sheng
On Wednesday 24 September 2008 16:38:35 Avi Kivity wrote: Yang, Sheng wrote: - MSI support (WIP) - MTRR/PAT support of EPT (WIP) - MTRR/PAT support of shadow (WIP) - Basic FLR support (WIP) Above four are my works. All of them work now. But more job

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Yang, Sheng
On Wednesday 24 September 2008 16:53:15 Avi Kivity wrote: Yang, Sheng wrote: Shared guest interrupts is a prerequisite for merging into mainline. Without this, device assignment is useless in anything but a benchmark scenario. I won't push device assignment for 2.6.28 without

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Yang, Sheng
On Wednesday 24 September 2008 17:22:53 Avi Kivity wrote: Yang, Sheng wrote: We only have three pci interrupts at this point (though this could be easily extended); if you start the guest with a non-trivial number of devices, you will have shared guest interrupts. (of course, when I

Re: [PATCH 5/9] kvm-x86: Enable NMI Watchdog via in-kernel PIT source

2008-09-24 Thread Yang, Sheng
On Tuesday 23 September 2008 23:04:48 Jan Kiszka wrote: Yang, Sheng wrote: On Friday 19 September 2008 20:03:02 Jan Kiszka wrote: LINT0 of the LAPIC can be used to route PIT events as NMI watchdog ticks into the guest. This patch aligns the in-kernel irqchip emulation with the user space

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-24 Thread Yang, Sheng
I am afraid I got this when try to enable VT-d. create_userspace_phys_mem: Invalid argument assigned_dev_iomem_map: Error: create new mapping failed Can you have a look at it? (and the patch you sent to Weidong don't got this problem.) Thanks. -- regards Yang, Sheng Signed-off-by: Amit Shah

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-24 Thread Yang, Sheng
On Thursday 25 September 2008 12:54:46 Yang, Sheng wrote: On Tuesday 23 September 2008 22:54:53 Amit Shah wrote: From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED] From: Weidong Han [EMAIL PROTECTED

Re: [PATCH 5/9] kvm-x86: Enable NMI Watchdog via in-kernel PIT source

2008-09-23 Thread Yang, Sheng
version of Windows(IRQ_NOT_EQUAL_OR_LESS). I don't remember the exactly situation there, but you may have a try. -- regards Yang, Sheng Signed-off-by: Jan Kiszka [EMAIL PROTECTED] --- arch/x86/kvm/i8254.c | 15 +++ arch/x86/kvm/irq.h |1 + arch/x86/kvm/lapic.c | 32

Re: [PATCH 9/11] VMX: Provide support for user space injected NMIs

2008-09-23 Thread Yang, Sheng
] -- regards Yang, Sheng + if (kvm_run-request_nmi_window !vcpu-arch.nmi_pending) { + kvm_run-exit_reason = KVM_EXIT_NMI_WINDOW_OPEN; + return 0; + } + return 1; } -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH 10/11] VMX: work around lacking VNMI support

2008-09-23 Thread Yang, Sheng
may not be a issue import by this patchset? Seems need more debug... The patchset is OK for me, except I don't know when we would need that timeout one (buggy guest?...), and we may also root cause this issue or ensure that it's not a regression. -- regards Yang, Sheng -- To unsubscribe from

Re: [PATCH 10/11] VMX: work around lacking VNMI support

2008-09-23 Thread Yang, Sheng
On Tuesday 23 September 2008 17:15:09 Gleb Natapov wrote: On Tue, Sep 23, 2008 at 05:08:09PM +0800, Yang, Sheng wrote: We still get here with vmx-soft_vnmi_blocked = 1. Trying to find out how. We should only come along here with vnmi blocked on reinjection (after a fault

Re: [PATCH 10/11] VMX: work around lacking VNMI support

2008-09-23 Thread Yang, Sheng
On Tuesday 23 September 2008 17:45:44 Gleb Natapov wrote: On Tue, Sep 23, 2008 at 05:42:02PM +0800, Yang, Sheng wrote: That is exactly what I am using. Run it with SMP hal and do hibernate. Oh... Finally found how to enable that hibernate option And this hibernate works

Re: [PATCH 10/11] VMX: work around lacking VNMI support

2008-09-23 Thread Yang, Sheng
On Tuesday 23 September 2008 17:37:00 Yang, Sheng wrote: On Tuesday 23 September 2008 17:26:55 Gleb Natapov wrote: On Tue, Sep 23, 2008 at 05:24:50PM +0800, Yang, Sheng wrote: On Tuesday 23 September 2008 17:15:09 Gleb Natapov wrote: On Tue, Sep 23, 2008 at 05:08:09PM +0800, Yang, Sheng

Re: [PATCH 10/11] VMX: work around lacking VNMI support

2008-09-23 Thread Yang, Sheng
On Tuesday 23 September 2008 17:26:55 Gleb Natapov wrote: On Tue, Sep 23, 2008 at 05:24:50PM +0800, Yang, Sheng wrote: On Tuesday 23 September 2008 17:15:09 Gleb Natapov wrote: On Tue, Sep 23, 2008 at 05:08:09PM +0800, Yang, Sheng wrote: We still get here with vmx-soft_vnmi_blocked

Re: VMX: Host NMI triggering on NMI vmexit

2008-09-22 Thread Yang, Sheng
investigating on the issues you met... -- regards Yang, Sheng And is it safe to assume VMX == LAPIC available and usable? Yes. However, this is how it would look like. I'd define a send_nmi_self() instead, to allow the implementation to change (x2apic/etc). Yet untested, /me has

Re: VMX: NMI injection without virtual NMI support

2008-09-12 Thread Yang, Sheng
think it's quite tricky. If you still have interest, you may try it, but I can't guarantee the result... Thanks. -- regards Yang, Sheng TiA, Jan -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] KVM: Fix QEmu interrupted HLT emulation

2008-09-11 Thread Yang, Sheng
On Thursday 11 September 2008 16:50:37 Avi Kivity wrote: Yang, Sheng wrote: From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 13:43:58 +0800 Subject: [PATCH] KVM: Fix QEmu interrupted HLT emulation QEmu can interrupt VCPU from HLT emulation without setting mp_state

Re: [PATCH] KVM: VMX: Move private memory slot position

2008-09-11 Thread Yang, Sheng
On Thursday 04 September 2008 11:30:20 Yang, Sheng wrote: From ebe4ea311305d2910dcdcff2510662da0dc2c742 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 4 Sep 2008 03:11:48 +0800 Subject: [PATCH] KVM: VMX: Move private memory slot position PCI device assignment would

Re: [PATCH] KVM: VMX: Add PAT support for EPT

2008-09-10 Thread Yang, Sheng
things on Nehalem. I would work on clearing up the code according to the latest spec soon (yeah, we also only got it for days...) -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Test with VT-d patches

2008-09-04 Thread Yang, Sheng
get both files rejected. So I take the headers from the KVM 1/2 Patchfile and use these a iova.h and intel-iommu.h. Kernel compiles without errors. 2) What known bug is in the latest userspace patchfile? (Told by Yang, Sheng) I think it's mentioned by Ben that userspace patch refer

[PATCH][REPOST] KVM: VMX: Always return 0 for clear_flush_young() when using EPT

2008-09-03 Thread Yang, Sheng
Hi Avi It seems something wrong with my git-send-email, and I can't got my post from kvm@vger.kernel.org, so resend it. Sorry for inconvenient. Thanks! -- From: Sheng Yang [EMAIL PROTECTED] Date: Mon, 1 Sep 2008 13:22:09 +0800 Subject: [PATCH] KVM: VMX: Always return 0 for clear_flush_young()

Re: Test with VT-d patches

2008-09-02 Thread Yang, Sheng
.) Can this interrupt be shared with an other IRQ? Oh, no, not currently... The device's IRQ should not be shared with other, we haven't implement shared IRQ logic, but soon. -- regards Yang, Sheng Gregor -- To unsubscribe from this list: send the line unsubscribe kvm in the body

[PATCH] KVM: MMU: Fix overflow of SHADOW_PT_INDEX with EPT in 32pae

2008-09-01 Thread Yang, Sheng
From: Sheng Yang [EMAIL PROTECTED] Date: Mon, 1 Sep 2008 17:28:59 +0800 Subject: [PATCH] KVM: MMU: Fix overflow of SHADOW_PT_INDEX with EPT in 32pae EPT is 4 level by default in 32pae (48bits), but virtual address only got 32 bits. This result in SHADOW_PT_INDEX() overflow when try to fetch level

Re: [PATCH] KVM: MMU: Add shadow_accessed_shift

2008-08-31 Thread Yang, Sheng
On Sunday 31 August 2008 23:13:54 Avi Kivity wrote: [EMAIL PROTECTED] wrote: From: Sheng Yang [EMAIL PROTECTED] We use a fake A/D bit for EPT, to keep epte behaviour consistent with shadow spte. But it's not that good for MMU notifier. Now we can only expect return young=0 for

Re: [ANNOUNCE] kvm-73 release

2008-08-21 Thread Yang, Sheng
On Thursday 21 August 2008 09:45:29 Yang, Sheng wrote: On Thursday 21 August 2008 00:43:22 Muli Ben-Yehuda wrote: On Wed, Aug 20, 2008 at 06:04:26PM +0300, Avi Kivity wrote: Other noteworthy changes: speedups of both virtio-net and qcow2 with cache=off. Two important works-in-progress

Re: [ANNOUNCE] kvm-73 release

2008-08-20 Thread Yang, Sheng
to remind Ben about that, but forgot it... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target

2008-08-17 Thread Yang, Sheng
On Wednesday 13 August 2008 11:48:02 Yang, Sheng wrote: From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 13 Aug 2008 11:35:17 +0800 Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Seems this flags

[PATCH] kvm: Fix kvm startup script

2008-08-13 Thread Yang, Sheng
From 4993375c0d67fd5eb47891dee48300880aceff1e Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 13 Aug 2008 15:39:29 +0800 Subject: [PATCH] kvm: Fix kvm startup script Signed-off-by: Sheng Yang [EMAIL PROTECTED] --- kvm | 16 +--- 1 files changed, 13

[PATCH 1/2] KVM: trace: Add event mask support

2008-08-13 Thread Yang, Sheng
From bb7cc3fd1e549d38d6bda10a06feda9339de9d3e Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 13 Aug 2008 14:29:43 +0800 Subject: [PATCH] KVM: trace: Add event mask support Allow user space application to specify one or morefilter masks to limit the events being captured

Re: [PATCH 1/2] KVM: trace: Add event mask support

2008-08-13 Thread Yang, Sheng
On Wednesday 13 August 2008 16:04:59 Avi Kivity wrote: Yang, Sheng wrote: From bb7cc3fd1e549d38d6bda10a06feda9339de9d3e Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 13 Aug 2008 14:29:43 +0800 Subject: [PATCH] KVM: trace: Add event mask support Allow user

Re: [PATCH 1/2] VT-d: changes to support KVM

2008-08-13 Thread Yang, Sheng
On Thursday 07 August 2008 22:14:46 Ben-Ami Yassour wrote: From: Kay, Allen M [EMAIL PROTECTED] This patch extends the VT-d driver to support KVM Seems OK to me. Avi, is this patch good enough to send to PCI guys to have a review? -- regards Yang, Sheng [Ben: fixed memory pinning

Re: [PATCH 2/2] KVM: Device assignemnt with VT-d

2008-08-13 Thread Yang, Sheng
+++ b/include/asm-x86/kvm_host.h @@ -354,6 +354,7 @@ struct kvm_arch{ */ struct list_head active_mmu_pages; struct list_head assigned_dev_head; + struct dmar_domain *intel_iommu_domain; Need wrapped by CONFIG_DMAR? -- regards Yang, Sheng -- To unsubscribe from

Re: [PATCH 2/2] KVM: Device assignemnt with VT-d

2008-08-13 Thread Yang, Sheng
On Wednesday 13 August 2008 17:46:03 Avi Kivity wrote: Yang, Sheng wrote: On Thursday 07 August 2008 22:14:47 Ben-Ami Yassour wrote: Based on a patch by: Kay, Allen M [EMAIL PROTECTED] This patch enables pci device assignment based on VT-d support. When a device is assigned to the guest

[PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target

2008-08-12 Thread Yang, Sheng
From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 13 Aug 2008 11:35:17 +0800 Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Seems this flags is missing during merging long ago... And this result in updating of

Re: [PATCH] kvm: bios: Put AP boot up code to 0x1000

2008-08-05 Thread Yang, Sheng
On Sunday 03 August 2008 03:30:41 Sebastian Herbszt wrote: Yang, Sheng wrote: Please refer to my another patch comment. Basicly, AP is running HLT in 0x10038, but it can exit due to some reason, here QEmu want to raise it up . But after AP exit from HLT, it can't return to it because

Re: [PATCH 5/5] This patch extends the VT-d driver to support KVM

2008-08-04 Thread Yang, Sheng
assigned device list here to avoid this kind of thing happen. Also, we may need a lock here to prevent racy with assign_device(). -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] kvm: bios: Put AP boot up code to 0x1000

2008-07-31 Thread Yang, Sheng
On Thursday 31 July 2008 14:41:04 Avi Kivity wrote: Yang, Sheng wrote: On Thursday 31 July 2008 10:43:20 Yang, Sheng wrote: From ba05b3c821400127074f65ee4d172fabbe3524cd Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 10:39:24 +0800 Subject: [PATCH

Re: [PATCH] kvm: bios: Put AP boot up code to 0x1000

2008-07-31 Thread Yang, Sheng
On Friday 01 August 2008 05:15:11 Sebastian Herbszt wrote: Yang, Sheng wrote: Rather than 0x1, which can be overrided by userspace program like grub. Could you please explain this problem? If i don't misunderstand this smp_ap_boot_code_start from rombios32start.S gets copied

[PATCH] KVM: Fix exiting from HLT emulation with MP_STATE_HALTED

2008-07-30 Thread Yang, Sheng
From 8019bdd0c7e2933a4d6f7e046d1cc2ded221784e Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 30 Jul 2008 21:45:58 +0800 Subject: [PATCH] KVM: Fix exiting from HLT emulation with MP_STATE_HALTED VCPU can be forced exit from HLT emulation without setting mp_state to

[PATCH] kvm: bios: Put AP boot up code to 0x1000

2008-07-30 Thread Yang, Sheng
From ba05b3c821400127074f65ee4d172fabbe3524cd Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 10:39:24 +0800 Subject: [PATCH] kvm: bios: Put AP boot up code to 0x1000 Rather than 0x1, which can be overrided by userspace program like grub. Signed-off-by:

Re: [PATCH 01/04]Create x86 directory to hold x86-specific files.

2008-07-30 Thread Yang, Sheng
need a update of it... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: Fix exiting from HLT emulation with MP_STATE_HALTED

2008-07-30 Thread Yang, Sheng
On Wednesday 30 July 2008 21:55:19 Yang, Sheng wrote: From 8019bdd0c7e2933a4d6f7e046d1cc2ded221784e Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Wed, 30 Jul 2008 21:45:58 +0800 Subject: [PATCH] KVM: Fix exiting from HLT emulation with MP_STATE_HALTED Recall this patch

[PATCH] KVM: Fix QEmu interrupted HLT emulation

2008-07-30 Thread Yang, Sheng
From: Sheng Yang [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 13:43:58 +0800 Subject: [PATCH] KVM: Fix QEmu interrupted HLT emulation QEmu can interrupt VCPU from HLT emulation without setting mp_state to MP_STATE_RUNNABLE, when it kick vcpus which are doing HLT emulation to do something like stop

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Yang, Sheng
in struct kvm_pic, and modify all irq_request() calling(three of them in all) with (void *)kvm. It's not a must, I just think it's clearer... -- regards Yang, Sheng -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http

  1   2   >