Re: [PATCH KVM v2 2/4] KVM: additional i8254 output fixes

2013-01-07 Thread mmogilvi
On Mon, 7 Jan 2013 14:04:03 +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:54PM -0700, Matthew Ogilvie wrote: >> Make git_get_out() consistent with spec. Currently pit_get_out() >> doesn't affect IRQ0, but it can be read by the guest in other ways. >> This makes it consistent with pro

Re: [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread mmogilvi
On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: >> Reading the spec, it is clear that most modes normally leave the IRQ >> output line high, and only pulse it low to generate a leading edge. >> Especially the most commonly u