Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-14 Thread Michael Goldish
- "Uri Lublin" wrote: > On 09/14/2009 08:26 AM, Yolkfull Chow wrote: > > On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: > >> This module is meant to reduce code size by performing common test > procedures. > >> Generally, code here should look like test code. > > >> +def w

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-14 Thread Yolkfull Chow
On Mon, Sep 14, 2009 at 10:58:01AM +0300, Uri Lublin wrote: > On 09/14/2009 08:26 AM, Yolkfull Chow wrote: >> On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: >>> This module is meant to reduce code size by performing common test >>> procedures. >>> Generally, code here should look

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-14 Thread Uri Lublin
On 09/14/2009 08:26 AM, Yolkfull Chow wrote: On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: This module is meant to reduce code size by performing common test procedures. Generally, code here should look like test code. +def wait_for_login(vm, nic_index=0, timeout=240): +

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-13 Thread Yolkfull Chow
On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: > This module is meant to reduce code size by performing common test procedures. > Generally, code here should look like test code. > More specifically: > - Functions in this module should raise exceptions if things go wrong >