Re: [KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching

2009-05-28 Thread Lucas Meneghel Rodrigues
On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote: > 1. Make the 'login:' regular expression stricter so it doesn't match > 'Last login: ...' messages. > 2. Make the 'password:' regular expression stricter. > 3. Handle 'Connection refused' messages. Looks good to me > Signed-off-by: Michae

Re: [KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching

2009-05-26 Thread sudhir kumar
On Mon, May 25, 2009 at 2:15 PM, Michael Goldish wrote: > > - "sudhir kumar" wrote: > >> The patch looks sane to me. A very good thing that can be done for >> remote_login() is to tune the tmeouts. I have seen especialy with >> windows guests or sometimes when the machine is heavily loaded th

Re: [KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching

2009-05-25 Thread Michael Goldish
- "sudhir kumar" wrote: > The patch looks sane to me. A very good thing that can be done for > remote_login() is to tune the tmeouts. I have seen especialy with > windows guests or sometimes when the machine is heavily loaded the > timeouts elapse and the test fails. When I increased the tim

Re: [KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching

2009-05-24 Thread sudhir kumar
The patch looks sane to me. A very good thing that can be done for remote_login() is to tune the tmeouts. I have seen especialy with windows guests or sometimes when the machine is heavily loaded the timeouts elapse and the test fails. When I increased the timeouts the test did not fail. internal_t

[KVM-AUTOTEST PATCH] kvm_utils.py: remote_login(): improve regular expression matching

2009-05-24 Thread Michael Goldish
1. Make the 'login:' regular expression stricter so it doesn't match 'Last login: ...' messages. 2. Make the 'password:' regular expression stricter. 3. Handle 'Connection refused' messages. Signed-off-by: Michael Goldish --- client/tests/kvm_runtest_2/kvm_utils.py | 13 + 1 files