Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-06-01 Thread Uri Lublin
On 05/12/2009 06:34 PM, Mike Burns wrote: From: Michael Burnsmbu...@redhat.com Signed-off-by: Michael Burnsmbu...@redhat.com --- client/tests/kvm_runtest_2/control| 18 +- client/tests/kvm_runtest_2/kvm_install.py | 15 +++ 2 files changed, 32

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-06-01 Thread Mike Burns
Uri Lublin wrote: On 05/12/2009 06:34 PM, Mike Burns wrote: From: Michael Burnsmbu...@redhat.com Signed-off-by: Michael Burnsmbu...@redhat.com --- client/tests/kvm_runtest_2/control| 18 +- client/tests/kvm_runtest_2/kvm_install.py | 15 +++ 2

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-13 Thread Avi Kivity
Michael Goldish wrote: That is, assuming you want to - install KVM from F10 branch - run all tests - install KVM from F11 branch - run all tests - install KVM from devel branch - run all tests If you meant something different please correct me. Note kvm is moving to split userspace/kernel

[PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-12 Thread Mike Burns
From: Michael Burns mbu...@redhat.com Signed-off-by: Michael Burns mbu...@redhat.com --- client/tests/kvm_runtest_2/control| 18 +- client/tests/kvm_runtest_2/kvm_install.py | 15 +++ 2 files changed, 32 insertions(+), 1 deletions(-) diff --git

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Eduardo Habkost
Hi, Excerpts from Michael Burns's message of Fri May 08 15:55:30 -0300 2009: --- a/client/tests/kvm_runtest_2/kvm_install.py +++ b/client/tests/kvm_runtest_2/kvm_install.py @@ -77,6 +77,17 @@ def run_kvm_install(test, params, env): elif install_mode == localsrc:

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Mike Burns
Eduardo Habkost wrote: Hi, Excerpts from Michael Burns's message of Fri May 08 15:55:30 -0300 2009: --- a/client/tests/kvm_runtest_2/kvm_install.py +++ b/client/tests/kvm_runtest_2/kvm_install.py @@ -77,6 +77,17 @@ def run_kvm_install(test, params, env): elif install_mode == localsrc:

[PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Mike Burns
From: Michael Burns mbu...@redhat.com Signed-off-by: Michael Burns mbu...@redhat.com --- client/tests/kvm_runtest_2/control| 17 - client/tests/kvm_runtest_2/kvm_install.py | 13 + 2 files changed, 29 insertions(+), 1 deletions(-) diff --git

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Mike Burns
Michael Goldish wrote: - Mike Burns mbu...@redhat.com wrote: Eduardo Habkost wrote: Hi, Excerpts from Michael Burns's message of Fri May 08 15:55:30 -0300 2009: --- a/client/tests/kvm_runtest_2/kvm_install.py +++ b/client/tests/kvm_runtest_2/kvm_install.py

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Michael Goldish
- Mike Burns mbu...@redhat.com wrote: Eduardo Habkost wrote: Hi, Excerpts from Michael Burns's message of Fri May 08 15:55:30 -0300 2009: --- a/client/tests/kvm_runtest_2/kvm_install.py +++ b/client/tests/kvm_runtest_2/kvm_install.py @@ -77,6 +77,17 @@ def

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Eduardo Habkost
On Mon, May 11, 2009 at 01:36:26PM -0400, Michael Goldish wrote: - Mike Burns mbu...@redhat.com wrote: Eduardo Habkost wrote: snip Maybe something like (untested): for k in params.keys(): os.putenv(KVM_INSTALL_%s % (k), params[k]) Are all values on 'params'

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Eduardo Habkost
On Mon, May 11, 2009 at 01:52:19PM -0400, Mike Burns wrote: Michael Goldish wrote: snip 2. Why not just pass the parameters via the command line, e.g. install_command = my_script.sh param1 param2 That would work as well. It could be done either way, but if someone wanted to use

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Mike Burns
Eduardo Habkost wrote: On Mon, May 11, 2009 at 01:52:19PM -0400, Mike Burns wrote: Michael Goldish wrote: snip 2. Why not just pass the parameters via the command line, e.g. install_command = my_script.sh param1 param2 That would work as well. It could be done either

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Lucas Meneghel Rodrigues
Hi Mike On Mon, 2009-05-11 at 11:51 -0400, Mike Burns wrote: From: Michael Burns mbu...@redhat.com The comments I had to make were pretty much covered by Eduardo and Mike Goldish... 1 - We should support passing parameters by both environment variables and command line arguments 2 -

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Michael Goldish
- Eduardo Habkost ehabk...@redhat.com wrote: On Mon, May 11, 2009 at 01:36:26PM -0400, Michael Goldish wrote: - Mike Burns mbu...@redhat.com wrote: Eduardo Habkost wrote: snip Maybe something like (untested): for k in params.keys():

Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-11 Thread Eduardo Pereira Habkost
Excerpts from Michael Goldish's message of Mon May 11 16:00:29 -0300 2009: - Eduardo Habkost ehabk...@redhat.com wrote: snip Also, can't the install rule be used on the cartesian configuration file? In this case, the install parameters may be specified on a different config rule.

[PATCH][KVM-AUTOTEST] Add custom install option for kvm_install

2009-05-08 Thread Mike Burns
From: Michael Burns mbu...@redhat.com Signed-off-by: Michael Burns mbu...@redhat.com --- client/tests/kvm_runtest_2/control| 14 +- client/tests/kvm_runtest_2/kvm_install.py | 11 +++ 2 files changed, 24 insertions(+), 1 deletions(-) diff --git