Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread Michael S. Tsirkin
On Mon, May 24, 2010 at 10:50:44AM -0700, David Stevens wrote: > Michael S. Tsirkin wrote on 05/24/2010 09:42:05 AM: > > > > I see. The logging is still bugg though I think. > > Possibly; migration isn't working for me under load even > without mergeable buffers (investigating), so I haven't > y

Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread David Stevens
Michael S. Tsirkin wrote on 05/24/2010 09:42:05 AM: > > I see. The logging is still bugg though I think. Possibly; migration isn't working for me under load even without mergeable buffers (investigating), so I haven't yet been able to test wrap w/ logging, but did you see something specific that

Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread Michael S. Tsirkin
On Mon, May 24, 2010 at 09:27:15AM -0700, David Stevens wrote: > netdev-ow...@vger.kernel.org wrote on 05/24/2010 09:13:51 AM: > > > On Mon, May 24, 2010 at 08:52:40AM -0700, David Stevens wrote: > > > "Michael S. Tsirkin" wrote on 05/24/2010 03:17:10 AM: > > > > > > > On Thu, May 20, 2010 at 09

Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread David Stevens
netdev-ow...@vger.kernel.org wrote on 05/24/2010 09:13:51 AM: > On Mon, May 24, 2010 at 08:52:40AM -0700, David Stevens wrote: > > "Michael S. Tsirkin" wrote on 05/24/2010 03:17:10 AM: > > > > > On Thu, May 20, 2010 at 09:58:06AM -0700, David L Stevens wrote: > > > > [for Michael Tsirkin's vhost

Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread Michael S. Tsirkin
On Mon, May 24, 2010 at 08:52:40AM -0700, David Stevens wrote: > "Michael S. Tsirkin" wrote on 05/24/2010 03:17:10 AM: > > > On Thu, May 20, 2010 at 09:58:06AM -0700, David L Stevens wrote: > > > [for Michael Tsirkin's vhost development git tree] > > > > > > This patch fixes a race between guest

Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread David Stevens
"Michael S. Tsirkin" wrote on 05/24/2010 03:17:10 AM: > On Thu, May 20, 2010 at 09:58:06AM -0700, David L Stevens wrote: > > [for Michael Tsirkin's vhost development git tree] > > > > This patch fixes a race between guest and host when > > adding used buffers wraps the ring. Without it, guests >

Re: [PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-24 Thread Michael S. Tsirkin
On Thu, May 20, 2010 at 09:58:06AM -0700, David L Stevens wrote: > [for Michael Tsirkin's vhost development git tree] > > This patch fixes a race between guest and host when > adding used buffers wraps the ring. Without it, guests > can see partial packets before num_buffers is set in > the vnet h

[PATCH][VHOST] fix race with guest on multi-buffer used buffer updates

2010-05-20 Thread David L Stevens
[for Michael Tsirkin's vhost development git tree] This patch fixes a race between guest and host when adding used buffers wraps the ring. Without it, guests can see partial packets before num_buffers is set in the vnet header. Signed-off-by: David L Stevens diff --git a/drivers/vhost/vhost.c b