Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-11-03 Thread Yolkfull Chow
On Wed, Oct 28, 2009 at 02:04:59PM -0400, Michael Goldish wrote: - Lucas Meneghel Rodrigues l...@redhat.com wrote: On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish mgold...@redhat.com wrote: Sounds great, except it won't allow you to debug your configuration using kvm_config.py.

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-11-02 Thread Ryan Harper
* Michael Goldish mgold...@redhat.com [2009-10-31 16:02]: If I'm understanding things, we are talking about moving the large body of kvm_tests.cfg test definitions, guest definitions into a library, and then moving the requested test config (bottom on kvm_tests.cfg) into the

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-31 Thread Michael Goldish
- Ryan Harper ry...@us.ibm.com wrote: * Lucas Meneghel Rodrigues l...@redhat.com [2009-10-28 14:48]: Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli is also

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-30 Thread Ryan Harper
* Lucas Meneghel Rodrigues l...@redhat.com [2009-10-28 14:48]: Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli is also important. A longer term goal is to have our test farm

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-30 Thread Lucas Meneghel Rodrigues
On Fri, 2009-10-30 at 08:54 -0500, Ryan Harper wrote: * Lucas Meneghel Rodrigues l...@redhat.com [2009-10-28 14:48]: Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli is

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
I think this patch is a good idea. Comments: - If we've decided to put all the configuration in config files (rather than the control file) let's split up the main one into kvm_test_library.cfg and kvm_tests.cfg.sample. The latter should look like this: include kvm_test_library.cfg include

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
One thing that just occurred to me is, if we have a test config library as you said, it's perfectly possible to put the actual test set definitions and other config files inside the control file as strings. This way one can control configuration inside the control file, making it more convenient

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: One thing that just occurred to me is, if we have a test config library as you said, it's perfectly possible to put the actual test set definitions and other config files inside the control file as strings. This way one can control

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
, autot...@test.kernel.org Sent: Wednesday, October 28, 2009 1:14:43 PM (GMT+0200) Auto-Detected Subject: Re: [PATCH] [RFC] KVM test: Major control file cleanup One thing that just occurred to me is, if we have a test config library as you said, it's perfectly possible to put the actual test set

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish mgold...@redhat.com wrote: Sounds great, except it won't allow you to debug your configuration using kvm_config.py.  So the question now is what's more important -- the ability to debug or ease of use when running from the server. Here we have 2

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
On Wed, Oct 28, 2009 at 1:57 PM, Michael Goldish mgold...@redhat.com wrote: One more comment on this patch: If you plan to make 'noinstall' the default build mode, then let's not run the build test at all by default.  If we run it with 'noinstall', it will just run the preprocessor and

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
- Lucas Meneghel Rodrigues l...@redhat.com wrote: On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish mgold...@redhat.com wrote: Sounds great, except it won't allow you to debug your configuration using kvm_config.py.  So the question now is what's more important -- the ability to

Re: [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Ryan Harper
* Michael Goldish mgold...@redhat.com [2009-10-28 10:43]: - Lucas Meneghel Rodrigues l...@redhat.com wrote: One thing that just occurred to me is, if we have a test config library as you said, it's perfectly possible to put the actual test set definitions and other config files

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Lucas Meneghel Rodrigues
Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web interface or cli is also important. A longer term goal is to have our test farm and make any developer able to schedule a job on the test farm easily

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-10-28 Thread Michael Goldish
...@redhat.com, kvm@vger.kernel.org Sent: Wed, 28 Oct 2009 15:47:54 -0400 (EDT) Subject: Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup Ryan, Michael: I absolutely agree that the ability to debug stuff is important, but the ability to make things straightforward to use from the web

[PATCH] [RFC] KVM test: Major control file cleanup

2009-10-27 Thread Lucas Meneghel Rodrigues
As pointed out before, the KVM reference control files could use a little clean up. This patch implements severe cleanup of the main control file by: * Refactoring the code present there, moving it to the kvm_utils.py library * Treat the build test exactly the same way as other tests, moving the