Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-11 Thread Marcelo Tosatti
Kivity; kvm@vger.kernel.org; Zhang, Xiantao; Liu, Jinsong Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Tue, Oct 09, 2012 at 04:10:30PM +, Auld, Will wrote: I am just testing the second version of this patch. It addresses all the comments so far except Marcelo's issue

RE: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-10 Thread Auld, Will
, Will -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Wednesday, October 10, 2012 5:53 AM To: Auld, Will Cc: Avi Kivity; kvm@vger.kernel.org; Zhang, Xiantao; Liu, Jinsong Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Tue, Oct 09, 2012 at 04:10

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-10 Thread Marcelo Tosatti
, Will; kvm@vger.kernel.org; Zhang, Xiantao Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual: • If an execution of WRMSR to the IA32_TIME_STAMP_COUNTER MSR adds (or subtracts) value X from the TSC, the logical

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Avi Kivity
On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual: • If an execution of WRMSR to the IA32_TIME_STAMP_COUNTER MSR adds (or subtracts) value X from the TSC, the logical processor also adds (or subtracts) value X from the IA32_TSC_ADJUST MSR. This is not handled in the

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Marcelo Tosatti
On Tue, Oct 09, 2012 at 02:12:18PM +0200, Avi Kivity wrote: On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual: • If an execution of WRMSR to the IA32_TIME_STAMP_COUNTER MSR adds (or subtracts) value X from the TSC, the logical processor also adds (or subtracts)

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Avi Kivity
On 10/09/2012 04:24 PM, Marcelo Tosatti wrote: On Tue, Oct 09, 2012 at 02:12:18PM +0200, Avi Kivity wrote: On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual: • If an execution of WRMSR to the IA32_TIME_STAMP_COUNTER MSR adds (or subtracts) value X from the TSC, the

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Marcelo Tosatti
On Tue, Oct 09, 2012 at 04:26:32PM +0200, Avi Kivity wrote: On 10/09/2012 04:24 PM, Marcelo Tosatti wrote: On Tue, Oct 09, 2012 at 02:12:18PM +0200, Avi Kivity wrote: On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual: • If an execution of WRMSR to the

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Avi Kivity
On 10/09/2012 04:27 PM, Marcelo Tosatti wrote: On Tue, Oct 09, 2012 at 04:26:32PM +0200, Avi Kivity wrote: On 10/09/2012 04:24 PM, Marcelo Tosatti wrote: On Tue, Oct 09, 2012 at 02:12:18PM +0200, Avi Kivity wrote: On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual:

RE: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Auld, Will
, October 09, 2012 5:12 AM To: Marcelo Tosatti Cc: Auld, Will; kvm@vger.kernel.org; Zhang, Xiantao Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On 10/08/2012 07:30 PM, Marcelo Tosatti wrote: From Intel's manual: • If an execution of WRMSR to the IA32_TIME_STAMP_COUNTER MSR adds

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-09 Thread Marcelo Tosatti
On Tue, Oct 09, 2012 at 04:30:28PM +0200, Avi Kivity wrote: On 10/09/2012 04:27 PM, Marcelo Tosatti wrote: On Tue, Oct 09, 2012 at 04:26:32PM +0200, Avi Kivity wrote: On 10/09/2012 04:24 PM, Marcelo Tosatti wrote: On Tue, Oct 09, 2012 at 02:12:18PM +0200, Avi Kivity wrote: On 10/08/2012

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-10-08 Thread Marcelo Tosatti
On Wed, Sep 19, 2012 at 05:44:46PM +, Auld, Will wrote: From 9982bb73460b05c1328068aae047b14b2294e2da Mon Sep 17 00:00:00 2001 From: Will Auld will.a...@intel.com Date: Wed, 12 Sep 2012 18:10:56 -0700 Subject: [PATCH] Enabling IA32_TSC_ADJUST for guest VM CPUID.7.0.EBX[1]=1 indicates

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-28 Thread Marcelo Tosatti
, Will Cc: kvm@vger.kernel.org; Avi Kivity; Zhang, Xiantao; Liu, Jinsong Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Thu, Sep 27, 2012 at 08:31:22AM -0300, Marcelo Tosatti wrote: On Thu, Sep 27, 2012 at 12:50:16AM +, Auld, Will wrote: Marcelo, I think I am missing

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-27 Thread Marcelo Tosatti
, Jinsong Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Wed, Sep 26, 2012 at 10:58:46PM +, Auld, Will wrote: Avi, Still working on your suggestions. Marcelo, The purpose is to be able to run guests that implement this change and not require they revert to the older

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-27 Thread Marcelo Tosatti
; Zhang, Xiantao; Liu, Jinsong Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Wed, Sep 26, 2012 at 10:58:46PM +, Auld, Will wrote: Avi, Still working on your suggestions. Marcelo, The purpose is to be able to run guests that implement this change

RE: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-27 Thread Auld, Will
Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Thu, Sep 27, 2012 at 08:31:22AM -0300, Marcelo Tosatti wrote: On Thu, Sep 27, 2012 at 12:50:16AM +, Auld, Will wrote: Marcelo, I think I am missing something. There should be no needed changes to current algorithms

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-26 Thread Marcelo Tosatti
On Wed, Sep 19, 2012 at 05:44:46PM +, Auld, Will wrote: From 9982bb73460b05c1328068aae047b14b2294e2da Mon Sep 17 00:00:00 2001 From: Will Auld will.a...@intel.com Date: Wed, 12 Sep 2012 18:10:56 -0700 Subject: [PATCH] Enabling IA32_TSC_ADJUST for guest VM CPUID.7.0.EBX[1]=1 indicates

RE: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-26 Thread Auld, Will
, Will Cc: kvm@vger.kernel.org; Avi Kivity; Zhang, Xiantao Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Wed, Sep 19, 2012 at 05:44:46PM +, Auld, Will wrote: From 9982bb73460b05c1328068aae047b14b2294e2da Mon Sep 17 00:00:00 2001 From: Will Auld will.a...@intel.com Date: Wed, 12

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-26 Thread Marcelo Tosatti
...@redhat.com] Sent: Wednesday, September 26, 2012 2:35 PM To: Auld, Will Cc: kvm@vger.kernel.org; Avi Kivity; Zhang, Xiantao Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Wed, Sep 19, 2012 at 05:44:46PM +, Auld, Will wrote: From 9982bb73460b05c1328068aae047b14b2294e2da

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-26 Thread Marcelo Tosatti
, Will Cc: kvm@vger.kernel.org; Avi Kivity; Zhang, Xiantao Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Wed, Sep 19, 2012 at 05:44:46PM +, Auld, Will wrote: From 9982bb73460b05c1328068aae047b14b2294e2da Mon Sep 17 00:00:00 2001 From: Will Auld will.a

RE: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-26 Thread Auld, Will
, September 26, 2012 5:29 PM To: Auld, Will Cc: kvm@vger.kernel.org; Avi Kivity; Zhang, Xiantao; Liu, Jinsong Subject: Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM On Wed, Sep 26, 2012 at 10:58:46PM +, Auld, Will wrote: Avi, Still working on your suggestions. Marcelo, The purpose

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-20 Thread Avi Kivity
On 09/19/2012 08:44 PM, Auld, Will wrote: From 9982bb73460b05c1328068aae047b14b2294e2da Mon Sep 17 00:00:00 2001 From: Will Auld will.a...@intel.com Date: Wed, 12 Sep 2012 18:10:56 -0700 Subject: [PATCH] Enabling IA32_TSC_ADJUST for guest VM CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR

Re: [PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-20 Thread Avi Kivity
On 09/19/2012 08:44 PM, Auld, Will wrote: @@ -2241,6 +2244,13 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 data) } ret = kvm_set_msr_common(vcpu, msr_index, data); break; + case MSR_TSC_ADJUST: +#define DUMMY 1 +

[PATCH] Enabling IA32_TSC_ADJUST for guest VM

2012-09-19 Thread Auld, Will
From 9982bb73460b05c1328068aae047b14b2294e2da Mon Sep 17 00:00:00 2001 From: Will Auld will.a...@intel.com Date: Wed, 12 Sep 2012 18:10:56 -0700 Subject: [PATCH] Enabling IA32_TSC_ADJUST for guest VM CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate