Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-19 Thread Sheng Yang
On Tuesday 19 January 2010 15:57:57 Gleb Natapov wrote: > On Tue, Jan 19, 2010 at 09:54:44AM +0200, Avi Kivity wrote: > > On 01/19/2010 05:06 AM, Sheng Yang wrote: > > >>There are two problems with the kernel failure report. First, it > > >>doesn't report enough data - registers, surrounding instr

Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-18 Thread Gleb Natapov
On Tue, Jan 19, 2010 at 09:54:44AM +0200, Avi Kivity wrote: > On 01/19/2010 05:06 AM, Sheng Yang wrote: > > > >>There are two problems with the kernel failure report. First, it > >>doesn't report enough data - registers, surrounding instructions, etc. > >>that are needed to explain what is going o

Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-18 Thread Avi Kivity
On 01/19/2010 05:06 AM, Sheng Yang wrote: There are two problems with the kernel failure report. First, it doesn't report enough data - registers, surrounding instructions, etc. that are needed to explain what is going on. Second, it can flood dmesg, which is a pretty bad thing to do.

Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-18 Thread Sheng Yang
On Monday 18 January 2010 19:32:14 Avi Kivity wrote: > On 01/18/2010 11:32 AM, Sheng Yang wrote: > > On Sunday 17 January 2010 20:34:23 Avi Kivity wrote: > >> On 01/15/2010 10:44 AM, Sheng Yang wrote: > >>> Currently we only have handle_invalid_guest_state() reported emulation > >>> failure... > >>

Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-18 Thread Avi Kivity
On 01/18/2010 11:32 AM, Sheng Yang wrote: On Sunday 17 January 2010 20:34:23 Avi Kivity wrote: On 01/15/2010 10:44 AM, Sheng Yang wrote: Currently we only have handle_invalid_guest_state() reported emulation failure... This is intentional - instead of spamming dmesg, we exit

Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-18 Thread Sheng Yang
On Sunday 17 January 2010 20:34:23 Avi Kivity wrote: > On 01/15/2010 10:44 AM, Sheng Yang wrote: > > Currently we only have handle_invalid_guest_state() reported emulation > > failure... > > > > Signed-off-by: Sheng Yang > > --- > > arch/x86/kvm/mmu.c |1 + > > 1 files changed, 1 insertions(

Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-17 Thread Avi Kivity
On 01/15/2010 10:44 AM, Sheng Yang wrote: Currently we only have handle_invalid_guest_state() reported emulation failure... Signed-off-by: Sheng Yang --- arch/x86/kvm/mmu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index

[PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()

2010-01-15 Thread Sheng Yang
Currently we only have handle_invalid_guest_state() reported emulation failure... Signed-off-by: Sheng Yang --- arch/x86/kvm/mmu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 4f5508c..037e52a 100644 --- a/arch/x86/kvm/mm