Re: [Android-virt] [PATCH] KVM: Cleanup the kvm_print functions and introduce pr_XX wrappers

2012-03-12 Thread Christoffer Dall
On Mon, Mar 12, 2012 at 3:32 PM, Alexander Graf wrote: > > On 08.03.2012, at 23:45, Christoffer Dall wrote: > >> Any comments on this one? > > While at it, how about you also add the PID? Otherwise it's pretty pointless > to write information into the kernel log, as you still won't know which VM

Re: [Android-virt] [PATCH] KVM: Cleanup the kvm_print functions and introduce pr_XX wrappers

2012-03-12 Thread Alexander Graf
On 08.03.2012, at 23:45, Christoffer Dall wrote: > Any comments on this one? While at it, how about you also add the PID? Otherwise it's pretty pointless to write information into the kernel log, as you still won't know which VM it origins from. Also, I don't like the long function name. How

Re: [PATCH] KVM: Cleanup the kvm_print functions and introduce pr_XX wrappers

2012-03-08 Thread Christoffer Dall
Any comments on this one? On Thu, Feb 9, 2012 at 3:57 PM, Christoffer Dall wrote: > From: Christoffer Dall > > Introduces a couple of print functions, which are essentially wrappers > around standard printk functions, with a KVM: prefix. > > Functions introduced or modified are: >  - kvm_err(fmt

[PATCH] KVM: Cleanup the kvm_print functions and introduce pr_XX wrappers

2012-02-09 Thread Christoffer Dall
From: Christoffer Dall Introduces a couple of print functions, which are essentially wrappers around standard printk functions, with a KVM: prefix. Functions introduced or modified are: - kvm_err(fmt, ...) - kvm_info(fmt, ...) - kvm_debug(fmt, ...) - kvm_pr_unimpl(fmt, ...) - pr_unimpl(vcpu