Marcelo Tosatti wrote:
On Wed, Jan 07, 2009 at 01:32:41PM +0200, Avi Kivity wrote:
Marcelo Tosatti wrote:
Let me shoot at one direction: a shadow page with PGE bit in either
state is created. Later that shadow page is nuked (via mmu notifiers,
for example).
I doubt that mmu noti
On Wed, Jan 07, 2009 at 01:32:41PM +0200, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>> Let me shoot at one direction: a shadow page with PGE bit in either
>> state is created. Later that shadow page is nuked (via mmu notifiers,
>> for example).
>
> I doubt that mmu notifiers were invoked in this
On 09.01.2009, at 01:36, Marcelo Tosatti wrote:
On Thu, Jan 08, 2009 at 08:53:21PM +0100, Alexander Graf wrote:
Sorry for the late reply - I wanted to know who kvm hangs in the host
kernel context :)
On 07.01.2009, at 14:46, Marcelo Tosatti wrote:
On Wed, Jan 07, 2009 at 01:32:41PM +02
On Thu, Jan 08, 2009 at 08:53:21PM +0100, Alexander Graf wrote:
> Sorry for the late reply - I wanted to know who kvm hangs in the host
> kernel context :)
>
> On 07.01.2009, at 14:46, Marcelo Tosatti wrote:
>
>> On Wed, Jan 07, 2009 at 01:32:41PM +0200, Avi Kivity wrote:
>>> Marcelo Tosatti wro
Sorry for the late reply - I wanted to know who kvm hangs in the host
kernel context :)
On 07.01.2009, at 14:46, Marcelo Tosatti wrote:
On Wed, Jan 07, 2009 at 01:32:41PM +0200, Avi Kivity wrote:
Marcelo Tosatti wrote:
Let me shoot at one direction: a shadow page with PGE bit in either
sta
On Wed, Jan 07, 2009 at 01:32:41PM +0200, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>> Let me shoot at one direction: a shadow page with PGE bit in either
>> state is created. Later that shadow page is nuked (via mmu notifiers,
>> for example).
>
> I doubt that mmu notifiers were invoked in this
Marcelo Tosatti wrote:
Let me shoot at one direction: a shadow page with PGE bit in either
state is created. Later that shadow page is nuked (via mmu notifiers,
for example).
I doubt that mmu notifiers were invoked in this case (the bug would be
very rare); in any case we flush the tlb.
--
On Wed, Jan 07, 2009 at 12:19:26PM +0200, Avi Kivity wrote:
> Alexander Graf wrote:
>> Using this patch it works. But if I read it correctly, that doesn't
>> actually fix anything but only treats NPT/EPT special, which it
>> shouldn't, should it?
>
> The patch doesn't fix the bug but is neverthele
Alexander Graf wrote:
Using this patch it works. But if I read it correctly, that doesn't
actually fix anything but only treats NPT/EPT special, which it
shouldn't, should it?
The patch doesn't fix the bug but is nevertheless correct. cr4.pge only
matters to the mmu if using the shadow mmu;
Marcelo Tosatti wrote:
> On Tue, Jan 06, 2009 at 04:29:59PM +0200, Avi Kivity wrote:
>
>> Yes...
>>
>> Looks like kvm_unsync_page can be folded into mmu_need_write_protect
>> (after which we can drop lookup_page(), which is not a good API). But
>> that's after we solve the current problem.
On Tue, Jan 06, 2009 at 04:29:59PM +0200, Avi Kivity wrote:
> Yes...
>
> Looks like kvm_unsync_page can be folded into mmu_need_write_protect
> (after which we can drop lookup_page(), which is not a good API). But
> that's after we solve the current problem.
>
> Looks like the addition of a se
On Tue, Jan 06, 2009 at 04:29:59PM +0200, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>> On Tue, Jan 06, 2009 at 12:41:40PM +0200, Avi Kivity wrote:
>>
>>> Alexander Graf wrote:
>>>
Avi Kivity wrote:
> From: Avi Kivity
>
> Don't allow a vcpu with cr4.pge clear
Marcelo Tosatti wrote:
On Tue, Jan 06, 2009 at 12:41:40PM +0200, Avi Kivity wrote:
Alexander Graf wrote:
Avi Kivity wrote:
From: Avi Kivity
Don't allow a vcpu with cr4.pge cleared to use a shadow page created with
cr4.pge set; this might cause a cr3 switch not to sync ptes
On Tue, Jan 06, 2009 at 12:41:40PM +0200, Avi Kivity wrote:
> Alexander Graf wrote:
>> Avi Kivity wrote:
>>
>>> From: Avi Kivity
>>>
>>> Don't allow a vcpu with cr4.pge cleared to use a shadow page created with
>>> cr4.pge set; this might cause a cr3 switch not to sync ptes that have the
>>> gl
Alexander Graf wrote:
Avi Kivity wrote:
From: Avi Kivity
Don't allow a vcpu with cr4.pge cleared to use a shadow page created with
cr4.pge set; this might cause a cr3 switch not to sync ptes that have the
global bit set (the global bit has no effect if !cr4.pge).
This can only occur on smp
Avi Kivity wrote:
> From: Avi Kivity
>
> Don't allow a vcpu with cr4.pge cleared to use a shadow page created with
> cr4.pge set; this might cause a cr3 switch not to sync ptes that have the
> global bit set (the global bit has no effect if !cr4.pge).
>
> This can only occur on smp with different
16 matches
Mail list logo
