Re: [PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-05-31 Thread Avi Kivity
Sheng Yang wrote: Disable interrupt at interrupt handler and enable it when guest ack is for the level triggered interrupt, to prevent reinjected interrupt. MSI/MSI-X don't need it. One possible problem is multiply same vector interrupt injected between irq handler and scheduled work handler wou

Re: [PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-05-04 Thread Sheng Yang
On Monday 04 May 2009 16:34:00 Avi Kivity wrote: > Sheng Yang wrote: > > On Monday 04 May 2009 16:25:55 Avi Kivity wrote: > >> Sheng Yang wrote: > >>> Disable interrupt at interrupt handler and enable it when guest ack is > >>> for the level triggered interrupt, to prevent reinjected interrupt. > >

Re: [PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-05-04 Thread Avi Kivity
Sheng Yang wrote: On Monday 04 May 2009 16:25:55 Avi Kivity wrote: Sheng Yang wrote: Disable interrupt at interrupt handler and enable it when guest ack is for the level triggered interrupt, to prevent reinjected interrupt. MSI/MSI-X don't need it. One possible problem is multiply same

Re: [PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-05-04 Thread Sheng Yang
On Monday 04 May 2009 16:25:55 Avi Kivity wrote: > Sheng Yang wrote: > > Disable interrupt at interrupt handler and enable it when guest ack is > > for the level triggered interrupt, to prevent reinjected interrupt. > > MSI/MSI-X don't need it. > > > > One possible problem is multiply same vector i

Re: [PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-05-04 Thread Avi Kivity
Sheng Yang wrote: Disable interrupt at interrupt handler and enable it when guest ack is for the level triggered interrupt, to prevent reinjected interrupt. MSI/MSI-X don't need it. One possible problem is multiply same vector interrupt injected between irq handler and scheduled work handler wou

[PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment

2009-04-29 Thread Sheng Yang
Disable interrupt at interrupt handler and enable it when guest ack is for the level triggered interrupt, to prevent reinjected interrupt. MSI/MSI-X don't need it. One possible problem is multiply same vector interrupt injected between irq handler and scheduled work handler would be merged as one