Re: [PATCH] KVM: PIC: call ack notifiers for irqs that are dropped form irr

2012-07-24 Thread Gleb Natapov
Ping. Is some additional work expected from me before this is applied? On Tue, Jul 17, 2012 at 02:59:11PM +0300, Gleb Natapov wrote: After commit 242ec97c358256 PIT interrupts are no longer delivered after PIC reset. It happens because PIT injects interrupt only if previous one was acked, but

Re: [PATCH] KVM: PIC: call ack notifiers for irqs that are dropped form irr

2012-07-24 Thread Marcelo Tosatti
On Tue, Jul 24, 2012 at 03:35:14PM +0300, Gleb Natapov wrote: Ping. Is some additional work expected from me before this is applied? Still not clear to me why its safe to skip kvm_apic_accept_pic_intr check before calling ack notifier. On Tue, Jul 17, 2012 at 02:59:11PM +0300, Gleb Natapov

Re: [PATCH] KVM: PIC: call ack notifiers for irqs that are dropped form irr

2012-07-24 Thread Gleb Natapov
On Tue, Jul 24, 2012 at 09:40:26AM -0300, Marcelo Tosatti wrote: On Tue, Jul 24, 2012 at 03:35:14PM +0300, Gleb Natapov wrote: Ping. Is some additional work expected from me before this is applied? Still not clear to me why its safe to skip kvm_apic_accept_pic_intr check before calling

Re: [PATCH] KVM: PIC: call ack notifiers for irqs that are dropped form irr

2012-07-20 Thread Marcelo Tosatti
On Tue, Jul 17, 2012 at 02:59:11PM +0300, Gleb Natapov wrote: After commit 242ec97c358256 PIT interrupts are no longer delivered after PIC reset. It happens because PIT injects interrupt only if previous one was acked, but since on PIC reset it is dropped from irr it will never be delivered

Re: [PATCH] KVM: PIC: call ack notifiers for irqs that are dropped form irr

2012-07-20 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 08:58:56AM -0300, Marcelo Tosatti wrote: On Tue, Jul 17, 2012 at 02:59:11PM +0300, Gleb Natapov wrote: After commit 242ec97c358256 PIT interrupts are no longer delivered after PIC reset. It happens because PIT injects interrupt only if previous one was acked, but

[PATCH] KVM: PIC: call ack notifiers for irqs that are dropped form irr

2012-07-17 Thread Gleb Natapov
After commit 242ec97c358256 PIT interrupts are no longer delivered after PIC reset. It happens because PIT injects interrupt only if previous one was acked, but since on PIC reset it is dropped from irr it will never be delivered and hence acknowledged. Fix that by calling ack notifier on PIC