Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-17 Thread Kevin Hilman
Frederic Weisbecker writes: > On Fri, May 17, 2013 at 07:09:42AM -0700, Kevin Hilman wrote: >> Frederic Weisbecker writes: >> >> > On Thu, May 16, 2013 at 12:52:03AM +0200, Frederic Weisbecker wrote: >> >> On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: >> >> > Gleb Natapov write

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-17 Thread Frederic Weisbecker
On Fri, May 17, 2013 at 07:09:42AM -0700, Kevin Hilman wrote: > Frederic Weisbecker writes: > > > On Thu, May 16, 2013 at 12:52:03AM +0200, Frederic Weisbecker wrote: > >> On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > >> > Gleb Natapov writes: > >> > > >> > > On Sun, Mar 24, 2

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-17 Thread Kevin Hilman
Frederic Weisbecker writes: > On Thu, May 16, 2013 at 12:52:03AM +0200, Frederic Weisbecker wrote: >> On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: >> > Gleb Natapov writes: >> > >> > > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: >> > >> 2013/3/21 Gleb N

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-16 Thread Frederic Weisbecker
On Thu, May 16, 2013 at 12:52:03AM +0200, Frederic Weisbecker wrote: > On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > > Gleb Natapov writes: > > > > > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: > > >> 2013/3/21 Gleb Natapov : > > >> > Isn't is simpler fo

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-15 Thread Frederic Weisbecker
On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > Gleb Natapov writes: > > > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: > >> 2013/3/21 Gleb Natapov : > >> > Isn't is simpler for kernel/context_tracking.c to define empty > >> > __guest_enter()/__guest_exit()

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-05-02 Thread Alexander Graf
On 02.04.2013, at 13:56, Gleb Natapov wrote: > On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: >> Gleb Natapov writes: >> >>> On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: 2013/3/21 Gleb Natapov : > Isn't is simpler for kernel/context_tracking.c to

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-04-02 Thread Gleb Natapov
On Mon, Mar 25, 2013 at 02:14:20PM -0700, Kevin Hilman wrote: > Gleb Natapov writes: > > > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: > >> 2013/3/21 Gleb Natapov : > >> > Isn't is simpler for kernel/context_tracking.c to define empty > >> > __guest_enter()/__guest_exit()

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-25 Thread Kevin Hilman
Gleb Natapov writes: > On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: >> 2013/3/21 Gleb Natapov : >> > Isn't is simpler for kernel/context_tracking.c to define empty >> > __guest_enter()/__guest_exit() if !CONFIG_KVM. >> >> That doesn't look right. Off-cases are usually han

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-24 Thread Gleb Natapov
On Sun, Mar 24, 2013 at 02:44:26PM +0100, Frederic Weisbecker wrote: > 2013/3/21 Gleb Natapov : > > Isn't is simpler for kernel/context_tracking.c to define empty > > __guest_enter()/__guest_exit() if !CONFIG_KVM. > > That doesn't look right. Off-cases are usually handled from the > headers, right

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-24 Thread Frederic Weisbecker
2013/3/21 Gleb Natapov : > Isn't is simpler for kernel/context_tracking.c to define empty > __guest_enter()/__guest_exit() if !CONFIG_KVM. That doesn't look right. Off-cases are usually handled from the headers, right? So that we avoid iffdeffery ugliness in core code. -- To unsubscribe from this

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-24 Thread Gleb Natapov
On Thu, Mar 21, 2013 at 05:02:15PM -0700, Kevin Hilman wrote: > Gleb Natapov writes: > > > On Thu, Mar 21, 2013 at 02:33:13PM -0500, Scott Wood wrote: > >> On 03/21/2013 02:16:00 PM, Gleb Natapov wrote: > >> >On Thu, Mar 21, 2013 at 01:42:34PM -0500, Scott Wood wrote: > >> >> On 03/21/2013 09:27:

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Kevin Hilman
Gleb Natapov writes: > On Thu, Mar 21, 2013 at 02:33:13PM -0500, Scott Wood wrote: >> On 03/21/2013 02:16:00 PM, Gleb Natapov wrote: >> >On Thu, Mar 21, 2013 at 01:42:34PM -0500, Scott Wood wrote: >> >> On 03/21/2013 09:27:14 AM, Kevin Hilman wrote: >> >> >Gleb Natapov writes: >> >> > >> >> >> O

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Gleb Natapov
On Thu, Mar 21, 2013 at 02:33:13PM -0500, Scott Wood wrote: > On 03/21/2013 02:16:00 PM, Gleb Natapov wrote: > >On Thu, Mar 21, 2013 at 01:42:34PM -0500, Scott Wood wrote: > >> On 03/21/2013 09:27:14 AM, Kevin Hilman wrote: > >> >Gleb Natapov writes: > >> > > >> >> On Wed, Mar 20, 2013 at 06:58:41

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Scott Wood
On 03/21/2013 02:16:00 PM, Gleb Natapov wrote: On Thu, Mar 21, 2013 at 01:42:34PM -0500, Scott Wood wrote: > On 03/21/2013 09:27:14 AM, Kevin Hilman wrote: > >Gleb Natapov writes: > > > >> On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote: > >>> Why can't the entirety kvm_host.h be incl

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Gleb Natapov
On Thu, Mar 21, 2013 at 01:42:34PM -0500, Scott Wood wrote: > On 03/21/2013 09:27:14 AM, Kevin Hilman wrote: > >Gleb Natapov writes: > > > >> On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote: > >>> On 03/14/2013 07:13:46 PM, Kevin Hilman wrote: > >>> >The new context tracking subsystem u

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Scott Wood
On 03/21/2013 09:27:14 AM, Kevin Hilman wrote: Gleb Natapov writes: > On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote: >> On 03/14/2013 07:13:46 PM, Kevin Hilman wrote: >> >The new context tracking subsystem unconditionally includes kvm_host.h >> >headers for the guest enter/exit

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Kevin Hilman
Gleb Natapov writes: > On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote: >> On 03/14/2013 07:13:46 PM, Kevin Hilman wrote: >> >The new context tracking subsystem unconditionally includes kvm_host.h >> >headers for the guest enter/exit macros. This causes a compile >> >failure when KVM

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-21 Thread Gleb Natapov
On Wed, Mar 20, 2013 at 06:58:41PM -0500, Scott Wood wrote: > On 03/14/2013 07:13:46 PM, Kevin Hilman wrote: > >The new context tracking subsystem unconditionally includes kvm_host.h > >headers for the guest enter/exit macros. This causes a compile > >failure when KVM is not enabled. > > > >Fix by

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-20 Thread Scott Wood
On 03/14/2013 07:13:46 PM, Kevin Hilman wrote: The new context tracking subsystem unconditionally includes kvm_host.h headers for the guest enter/exit macros. This causes a compile failure when KVM is not enabled. Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host so it can be included/c

Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-18 Thread Marcelo Tosatti
On Thu, Mar 14, 2013 at 05:13:46PM -0700, Kevin Hilman wrote: > The new context tracking subsystem unconditionally includes kvm_host.h > headers for the guest enter/exit macros. This causes a compile > failure when KVM is not enabled. > > Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host

[PATCH] KVM: allow host header to be included even for !CONFIG_KVM

2013-03-14 Thread Kevin Hilman
The new context tracking subsystem unconditionally includes kvm_host.h headers for the guest enter/exit macros. This causes a compile failure when KVM is not enabled. Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host so it can be included/compiled even when KVM is not enabled. Cc: Freder