Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-13 Thread Avi Kivity
On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote: It's better to limit memory slots to something that can be handled by everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is too large. I agree with that, so we make this patch pending to fix like that? -- or should make a new pa

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-13 Thread Takuya Yoshikawa
BTW, just from my curiosity, are there any cases in which we use such huge number of pages currently? ALIGN(memslot->npages, BITS_PER_LONG) / 8; More than G pages need really big memory! -- We are assuming some special cases like "short" int size? No, int is 32 bits, but memslot->npages is

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-12 Thread Avi Kivity
On 04/13/2010 03:52 AM, Takuya Yoshikawa wrote: (2010/04/13 2:39), Marcelo Tosatti wrote: On Mon, Apr 12, 2010 at 07:35:35PM +0900, Takuya Yoshikawa wrote: This patch fixes a bug found by Avi during the review process of my dirty bitmap related work. To ppc and ia64 people: The fix is reall

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-12 Thread Takuya Yoshikawa
(2010/04/13 2:39), Marcelo Tosatti wrote: On Mon, Apr 12, 2010 at 07:35:35PM +0900, Takuya Yoshikawa wrote: This patch fixes a bug found by Avi during the review process of my dirty bitmap related work. To ppc and ia64 people: The fix is really simple but touches all architectures using d

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-12 Thread Marcelo Tosatti
On Mon, Apr 12, 2010 at 07:35:35PM +0900, Takuya Yoshikawa wrote: > This patch fixes a bug found by Avi during the review process > of my dirty bitmap related work. > > To ppc and ia64 people: > The fix is really simple but touches all architectures using > dirty bitmaps. So please check this

Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-12 Thread Alexander Graf
On 12.04.2010, at 12:35, Takuya Yoshikawa wrote: > This patch fixes a bug found by Avi during the review process > of my dirty bitmap related work. > > To ppc and ia64 people: > The fix is really simple but touches all architectures using > dirty bitmaps. So please check this will not suffer y

[PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows

2010-04-12 Thread Takuya Yoshikawa
This patch fixes a bug found by Avi during the review process of my dirty bitmap related work. To ppc and ia64 people: The fix is really simple but touches all architectures using dirty bitmaps. So please check this will not suffer your part. === Int is not long enough to store the size of a