Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-05-05 Thread Jan Kiszka
On 2013-04-30 14:42, Jan Kiszka wrote: On 2013-04-30 13:46, Gleb Natapov wrote: On Sun, Apr 28, 2013 at 12:20:38PM +0200, Jan Kiszka wrote: On 2013-02-23 22:35, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-04-30 Thread Gleb Natapov
On Sun, Apr 28, 2013 at 12:20:38PM +0200, Jan Kiszka wrote: On 2013-02-23 22:35, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the state transition that may prevent loading L1's cr0. Signed-off-by: Jan

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-04-30 Thread Jan Kiszka
On 2013-04-30 13:46, Gleb Natapov wrote: On Sun, Apr 28, 2013 at 12:20:38PM +0200, Jan Kiszka wrote: On 2013-02-23 22:35, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the state transition that may prevent loading

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-04-28 Thread Jan Kiszka
On 2013-02-23 22:35, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the state transition that may prevent loading L1's cr0. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c |2 +- 1

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Jan Kiszka
On 2013-02-23 23:21, Jan Kiszka wrote: On 2013-02-23 22:57, Jan Kiszka wrote: On 2013-02-23 22:45, Nadav Har'El wrote: On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state: - kvm_set_cr0(vcpu, vmcs12-host_cr0

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Avi Kivity
On Sat, Feb 23, 2013 at 11:57 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-02-23 22:45, Nadav Har'El wrote: On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state: -kvm_set_cr0(vcpu, vmcs12-host_cr0

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Jan Kiszka
On 2013-02-24 09:56, Avi Kivity wrote: On Sat, Feb 23, 2013 at 11:57 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-02-23 22:45, Nadav Har'El wrote: On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Avi Kivity
On Sun, Feb 24, 2013 at 11:01 AM, Jan Kiszka jan.kis...@web.de wrote: On 2013-02-24 09:56, Avi Kivity wrote: On Sat, Feb 23, 2013 at 11:57 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-02-23 22:45, Nadav Har'El wrote: On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Jan Kiszka
wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state: -kvm_set_cr0(vcpu, vmcs12-host_cr0); +vmx_set_cr0(vcpu, vmcs12-host_cr0); I don't remember now why I did this (and I'm not looking at the code), but this you'll need to really test carefully

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Avi Kivity
On Sun, Feb 24, 2013 at 11:40 AM, Jan Kiszka jan.kis...@web.de wrote: We have the same problem in KVM_SET_SREGS. I don't see the problem. kvm_arch_vcpu_ioctl_set_sregs open-codes the state update, not applying any transition checks. That's the problem. We have this open coding in three

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Jan Kiszka
On 2013-02-24 11:11, Avi Kivity wrote: On Sun, Feb 24, 2013 at 11:40 AM, Jan Kiszka jan.kis...@web.de wrote: We have the same problem in KVM_SET_SREGS. I don't see the problem. kvm_arch_vcpu_ioctl_set_sregs open-codes the state update, not applying any transition checks. That's the problem.

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Avi Kivity
On Sun, Feb 24, 2013 at 12:49 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-02-24 11:11, Avi Kivity wrote: On Sun, Feb 24, 2013 at 11:40 AM, Jan Kiszka jan.kis...@web.de wrote: We have the same problem in KVM_SET_SREGS. I don't see the problem. kvm_arch_vcpu_ioctl_set_sregs open-codes the

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Jan Kiszka
On 2013-02-24 19:56, Avi Kivity wrote: On Sun, Feb 24, 2013 at 12:49 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-02-24 11:11, Avi Kivity wrote: On Sun, Feb 24, 2013 at 11:40 AM, Jan Kiszka jan.kis...@web.de wrote: We have the same problem in KVM_SET_SREGS. I don't see the problem.

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-24 Thread Avi Kivity
On Sun, Feb 24, 2013 at 9:15 PM, Jan Kiszka jan.kis...@web.de wrote: They all need consistency checks, otherwise userspace or the guest and inject inconsistent values and perhaps exploit the host. To my understanding, the hardware does this for us: If we try to enter the guest (L1, L2) with

[PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-23 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the state transition that may prevent loading L1's cr0. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- arch/x86/kvm/vmx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-23 Thread Nadav Har'El
On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state: - kvm_set_cr0(vcpu, vmcs12-host_cr0); + vmx_set_cr0(vcpu, vmcs12-host_cr0); I don't remember now why I did this (and I'm not looking at the code

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-23 Thread Jan Kiszka
On 2013-02-23 22:45, Nadav Har'El wrote: On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state: -kvm_set_cr0(vcpu, vmcs12-host_cr0); +vmx_set_cr0(vcpu, vmcs12-host_cr0); I don't remember now why I did

Re: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

2013-02-23 Thread Jan Kiszka
On 2013-02-23 22:57, Jan Kiszka wrote: On 2013-02-23 22:45, Nadav Har'El wrote: On Sat, Feb 23, 2013, Jan Kiszka wrote about [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state: - kvm_set_cr0(vcpu, vmcs12-host_cr0); + vmx_set_cr0(vcpu, vmcs12-host_cr0); I