Re: [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions

2009-01-11 Thread Avi Kivity
Amit Shah wrote: On Sun, Jan 11, 2009 at 12:46:49PM +0200, Avi Kivity wrote: Amit Shah wrote: The CPUID instruction takes the value of ECX as an input parameter in addition to the value of EAX for function 4. Make sure we pass the value to the instruction. This needs to go to

Re: [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions

2009-01-11 Thread Amit Shah
On Sun, Jan 11, 2009 at 12:46:49PM +0200, Avi Kivity wrote: > Amit Shah wrote: >> The CPUID instruction takes the value of ECX as an input parameter >> in addition to the value of EAX for function 4. Make sure we pass >> the value to the instruction. >> >> > > This needs to go to upstream qemu.

Re: [PATCH] KVM: qemu: CPUID takes ecx as input value for some functions

2009-01-11 Thread Avi Kivity
Amit Shah wrote: The CPUID instruction takes the value of ECX as an input parameter in addition to the value of EAX for function 4. Make sure we pass the value to the instruction. This needs to go to upstream qemu. I'd suggest adding a new parameter rather than making ecx an in/out parame

[PATCH] KVM: qemu: CPUID takes ecx as input value for some functions

2009-01-11 Thread Amit Shah
The CPUID instruction takes the value of ECX as an input parameter in addition to the value of EAX for function 4. Make sure we pass the value to the instruction. Signed-off-by: Amit Shah --- qemu/target-i386/helper.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git