[PATCH] KVM: x86: drop unneeded null test

2015-04-27 Thread Julia Lawall
From: Julia Lawall If the null test is needed, the call to cancel_delayed_work_sync would have already crashed. Normally, the destroy function should only be called if the init functoin has succeeded, in which case ioapic is not null. Problem found using Coccinelle. Signed-off-by: Julia Lawall

Re: [PATCH] KVM: x86: drop unneeded null test

2015-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2015 at 10:35:34PM +0200, Julia Lawall wrote: > From: Julia Lawall > > If the null test is needed, the call to cancel_delayed_work_sync would have > already crashed. Normally, the destroy function should only be called > if the init functoin has succeeded, in which case ioapic is

Re: [PATCH] KVM: x86: drop unneeded null test

2015-04-28 Thread Paolo Bonzini
On 27/04/2015 22:35, Julia Lawall wrote: > From: Julia Lawall > > If the null test is needed, the call to cancel_delayed_work_sync would have > already crashed. Normally, the destroy function should only be called > if the init functoin has succeeded, in which case ioapic is not null. > > Pro

Re: [PATCH] KVM: x86: drop unneeded null test

2015-04-28 Thread SF Markus Elfring
> If the null test is needed, the call to cancel_delayed_work_sync would have > already crashed. Normally, the destroy function should only be called > if the init functoin has succeeded, in which case ioapic is not null. Does your commit message need a small fix? Regards, Markus -- To unsubscri