Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-08-13 Thread Paolo Bonzini
Il 12/08/2014 21:29, Eduardo Habkost ha scritto: > On Tue, Aug 12, 2014 at 09:12:00PM +0200, Paolo Bonzini wrote: >> Il 12/08/2014 20:55, Eduardo Habkost ha scritto: >>> This makes the CPUID data change under the guest's feet during >>> live-migration. >>> >>> Adding compat code to ensure older mac

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-08-12 Thread Eduardo Habkost
On Tue, Aug 12, 2014 at 09:12:00PM +0200, Paolo Bonzini wrote: > Il 12/08/2014 20:55, Eduardo Habkost ha scritto: > > This makes the CPUID data change under the guest's feet during > > live-migration. > > > > Adding compat code to ensure older machine-types keep the old behavior > > is necessary,

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-08-12 Thread Paolo Bonzini
Il 12/08/2014 20:55, Eduardo Habkost ha scritto: > This makes the CPUID data change under the guest's feet during > live-migration. > > Adding compat code to ensure older machine-types keep the old behavior > is necessary, but in this specific case it is mostly harmless because > 0x0 is documented

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-08-12 Thread Eduardo Habkost
On Wed, Jun 04, 2014 at 03:17:56AM -0400, Jidong Xiao wrote: > On Wed, Jun 4, 2014 at 3:09 AM, Paolo Bonzini wrote: > > Il 04/06/2014 03:10, Jidong Xiao ha scritto: > > > >> diff --git a/qemu-2.0.0/target-i386/kvm.c.orig > >> b/qemu-2.0.0/target-i386/kvm.c > >> index 4389959..b8b282d 100644 > >> -

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Bandan Das
Jidong Xiao writes: .. >> > Hi, Bandan, > > Thanks for the advice. I think Paolo has incorporated this patch into > his patch sets, and he sent the revised version in a separate email > earlier today with the subject "[PULL 11/11] kvm: Fix eax for cpuid > leaf 0x4000". Oops! Sorry, must have

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Jidong Xiao
On Wed, Jun 4, 2014 at 3:08 PM, Bandan Das wrote: > Jidong Xiao writes: > >> On Wed, Jun 4, 2014 at 3:09 AM, Paolo Bonzini wrote: >>> Il 04/06/2014 03:10, Jidong Xiao ha scritto: >>> diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c index 4389959..b8b28

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Bandan Das
Jidong Xiao writes: > On Wed, Jun 4, 2014 at 3:09 AM, Paolo Bonzini wrote: >> Il 04/06/2014 03:10, Jidong Xiao ha scritto: >> >>> diff --git a/qemu-2.0.0/target-i386/kvm.c.orig >>> b/qemu-2.0.0/target-i386/kvm.c >>> index 4389959..b8b282d 100644 >>> --- a/qemu-2.0.0/target-i386/kvm.c.orig >>> ++

Re: [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Jidong Xiao
On Wed, Jun 4, 2014 at 3:09 AM, Paolo Bonzini wrote: > Il 04/06/2014 03:10, Jidong Xiao ha scritto: > >> diff --git a/qemu-2.0.0/target-i386/kvm.c.orig >> b/qemu-2.0.0/target-i386/kvm.c >> index 4389959..b8b282d 100644 >> --- a/qemu-2.0.0/target-i386/kvm.c.orig >> +++ b/qemu-2.0.0/target-i386/kvm.

Re: [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 03:10, Jidong Xiao ha scritto: diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c index 4389959..b8b282d 100644 --- a/qemu-2.0.0/target-i386/kvm.c.orig +++ b/qemu-2.0.0/target-i386/kvm.c @@ -530,7 +530,7 @@ int kvm_arch_init_vcpu(CPUState *cs) memcpy(

[PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-03 Thread Jidong Xiao
Hi, Since Linux kernel 3.5, KVM has set eax to KVM_CPUID_FEATURES, for leaf 0x4000, see this: https://github.com/torvalds/linux/commit/57c22e5f35aa4b9b2fe11f73f3e62bbf9ef36190 But qemu still tries to set it to 0. It would be better to make qemu and kvm consistent. This patch just fixes this