Re: [PATCH] Remove TARGET_PAGE_SIZE from virtio interface

2008-11-26 Thread Hollis Blanchard
On Wed, 2008-11-26 at 12:22 -0600, Hollis Blanchard wrote: > > diff --git a/hw/virtio.h b/hw/virtio.h > index 1df8f83..c23f38c 100644 > --- a/hw/virtio.h > +++ b/hw/virtio.h > @@ -47,6 +47,11 @@ > /* This means don't interrupt guest when buffer consumed. */ > #define VRING_AVAIL_F_NO_INTERRUPT

[PATCH] Remove TARGET_PAGE_SIZE from virtio interface

2008-11-26 Thread Hollis Blanchard
TARGET_PAGE_SIZE should only be used internal to qemu, not in guest/host interfaces. The virtio frontend code in Linux uses two constants (PFN shift and vring alignment) for the interface, so update qemu to match. I've tested this with PowerPC KVM and confirmed that it fixes virtio problems when u