Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread Gleb Natapov
On Wed, Jun 05, 2013 at 10:16:46AM +0800, 李春奇 Arthur Chunqi Li wrote: Add multibyte NOP test case to kvm-unit-tests. This case can test one of bugs when booting RHEL5.9 64-bit. Adding the test to x86/realmode.c will be much easier. Signed-off-by: Arthur Chunqi Li yzt...@gmail.com ---

Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread 李春奇
Yes, that should be the point. x86/realmode.c is always running in emulation mode. I added the testing here there but no error occurred. I cannot find the reason. The code is as follows added to x86/realmode.c static void test_nopl(void) { MK_INSN(nopl, .byte 0x0f, 0x1f, 0x00\n\r);

Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread Gleb Natapov
On Wed, Jun 05, 2013 at 03:00:33PM +0800, 李春奇 Arthur Chunqi Li wrote: Yes, that should be the point. x86/realmode.c is always running in emulation mode. I added the testing here there but no error occurred. I cannot find the reason. The code is as follows added to x86/realmode.c static void

Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread 李春奇
Yes, I load kvm-intel with unrestricted_guest=0 and the emulator runs well. I will give another test case in x86/realmode.c later. BTW, what is the action when a 64-bit instruction executes in x86/realmode.c? Should I add 64-bit insn tests only in x86/emulator.c? On Wed, Jun 5, 2013 at 4:27 PM,

Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread Gleb Natapov
On Wed, Jun 05, 2013 at 05:23:18PM +0800, 李春奇 Arthur Chunqi Li wrote: Yes, I load kvm-intel with unrestricted_guest=0 and the emulator runs well. I will give another test case in x86/realmode.c later. The test fails for me on CPU without unrestricted guest support. This means you either test

Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread 李春奇
I mean after adding unrestricted_guest=0, the error is reproduced. Sorry for confused expression. I have committed another patch in x86/realmode.c. On Wed, Jun 5, 2013 at 5:28 PM, Gleb Natapov g...@redhat.com wrote: On Wed, Jun 05, 2013 at 05:23:18PM +0800, 李春奇 Arthur Chunqi Li wrote: Yes, I

Re: [PATCH] Test case of multibyte NOP in emulation mode

2013-06-05 Thread Gleb Natapov
On Wed, Jun 05, 2013 at 05:46:31PM +0800, 李春奇 Arthur Chunqi Li wrote: I mean after adding unrestricted_guest=0, the error is reproduced. Ah, OK. unrestricted_guest=0 works then :) Sorry for confused expression. I have committed another patch in x86/realmode.c. On Wed, Jun 5, 2013 at 5:28

[PATCH] Test case of multibyte NOP in emulation mode

2013-06-04 Thread 李春奇
Add multibyte NOP test case to kvm-unit-tests. This case can test one of bugs when booting RHEL5.9 64-bit. Signed-off-by: Arthur Chunqi Li yzt...@gmail.com --- x86/emulator.c | 33 + 1 file changed, 33 insertions(+) diff --git a/x86/emulator.c b/x86/emulator.c