[PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-25 Thread Christoffer Dall
The sgi values calculated in read_set_clear_sgi_pend_reg() and write_set_clear_sgi_pend_reg() were horribly incorrectly multiplied by 4 with catastrophic results in that subfunctions ended up overwriting memory not allocated for the expected purpose. This showed up as bugs in kfree() and the kerne

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-25 Thread Shannon Zhao
On 2014/9/26 1:49, Christoffer Dall wrote: > The sgi values calculated in read_set_clear_sgi_pend_reg() and > write_set_clear_sgi_pend_reg() were horribly incorrectly multiplied by 4 > with catastrophic results in that subfunctions ended up overwriting > memory not allocated for the expected purpo

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-26 Thread Christoffer Dall
Hi Shannon, On Fri, Sep 26, 2014 at 01:57:46PM +0800, Shannon Zhao wrote: > > On 2014/9/26 1:49, Christoffer Dall wrote: > > The sgi values calculated in read_set_clear_sgi_pend_reg() and > > write_set_clear_sgi_pend_reg() were horribly incorrectly multiplied by 4 > > with catastrophic results in

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-26 Thread Shannon Zhao
On 2014/9/26 16:44, Christoffer Dall wrote: > Hi Shannon, > > On Fri, Sep 26, 2014 at 01:57:46PM +0800, Shannon Zhao wrote: >> >> On 2014/9/26 1:49, Christoffer Dall wrote: >>> The sgi values calculated in read_set_clear_sgi_pend_reg() and >>> write_set_clear_sgi_pend_reg() were horribly incorre

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-26 Thread Shannon Zhao
On 2014/9/26 1:49, Christoffer Dall wrote: > The sgi values calculated in read_set_clear_sgi_pend_reg() and > write_set_clear_sgi_pend_reg() were horribly incorrectly multiplied by 4 > with catastrophic results in that subfunctions ended up overwriting > memory not allocated for the expected purp

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-26 Thread Christoffer Dall
On Fri, Sep 26, 2014 at 05:26:00PM +0800, Shannon Zhao wrote: > > > On 2014/9/26 16:44, Christoffer Dall wrote: > > Hi Shannon, > > > > On Fri, Sep 26, 2014 at 01:57:46PM +0800, Shannon Zhao wrote: > >> > >> On 2014/9/26 1:49, Christoffer Dall wrote: > >>> The sgi values calculated in read_set_c

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-26 Thread Christoffer Dall
On Fri, Sep 26, 2014 at 12:16:35PM +0200, Christoffer Dall wrote: > On Fri, Sep 26, 2014 at 05:26:00PM +0800, Shannon Zhao wrote: > > > > > > On 2014/9/26 16:44, Christoffer Dall wrote: > > > Hi Shannon, > > > > > > On Fri, Sep 26, 2014 at 01:57:46PM +0800, Shannon Zhao wrote: > > >> > > >> On 2

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-29 Thread Shannon Zhao
Hi Christoffer, On 2014/9/26 21:44, Christoffer Dall wrote: > On Fri, Sep 26, 2014 at 12:16:35PM +0200, Christoffer Dall wrote: >> On Fri, Sep 26, 2014 at 05:26:00PM +0800, Shannon Zhao wrote: >>> >>> >>> On 2014/9/26 16:44, Christoffer Dall wrote: Hi Shannon, On Fri, Sep 26, 2014 a

Re: [PATCH] arm/arm64: KVM: Fix set_clear_sgi_pend_reg offset

2014-09-30 Thread Christoffer Dall
On Tue, Sep 30, 2014 at 09:48:02AM +0800, Shannon Zhao wrote: > Hi Christoffer, > > On 2014/9/26 21:44, Christoffer Dall wrote: > > On Fri, Sep 26, 2014 at 12:16:35PM +0200, Christoffer Dall wrote: > >> On Fri, Sep 26, 2014 at 05:26:00PM +0800, Shannon Zhao wrote: > >>> > >>> > >>> On 2014/9/26 16