Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-23 Thread Gleb Natapov
On Wed, Jun 23, 2010 at 12:16:46PM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > To prevent reentering vcpu after IO completion it is not enough > > to set env->stopped since it is checked only in main loop but control > > will not get there until next non-IO exit since kvm_run() will reenter

Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-23 Thread Jan Kiszka
Gleb Natapov wrote: > To prevent reentering vcpu after IO completion it is not enough > to set env->stopped since it is checked only in main loop but control > will not get there until next non-IO exit since kvm_run() will reenter > vcpu to complete IO instruction. Solve this by sending self-signal

Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-23 Thread Gleb Natapov
On Wed, Jun 23, 2010 at 11:22:15AM +0300, Avi Kivity wrote: > On 06/21/2010 12:01 PM, Gleb Natapov wrote: > >To prevent reentering vcpu after IO completion it is not enough > >to set env->stopped since it is checked only in main loop but control > >will not get there until next non-IO exit since kv

Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-23 Thread Avi Kivity
On 06/21/2010 12:01 PM, Gleb Natapov wrote: To prevent reentering vcpu after IO completion it is not enough to set env->stopped since it is checked only in main loop but control will not get there until next non-IO exit since kvm_run() will reenter vcpu to complete IO instruction. Solve this by s

Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-22 Thread Marcelo Tosatti
On Tue, Jun 22, 2010 at 08:18:14AM +0300, Gleb Natapov wrote: > On Mon, Jun 21, 2010 at 05:43:04PM -0300, Marcelo Tosatti wrote: > > On Mon, Jun 21, 2010 at 12:01:52PM +0300, Gleb Natapov wrote: > > > To prevent reentering vcpu after IO completion it is not enough > > > to set env->stopped since it

Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-21 Thread Gleb Natapov
On Mon, Jun 21, 2010 at 05:43:04PM -0300, Marcelo Tosatti wrote: > On Mon, Jun 21, 2010 at 12:01:52PM +0300, Gleb Natapov wrote: > > To prevent reentering vcpu after IO completion it is not enough > > to set env->stopped since it is checked only in main loop but control > > will not get there until

Re: [PATCH] do not enter vcpu again if it was stopped during IO

2010-06-21 Thread Marcelo Tosatti
On Mon, Jun 21, 2010 at 12:01:52PM +0300, Gleb Natapov wrote: > To prevent reentering vcpu after IO completion it is not enough > to set env->stopped since it is checked only in main loop but control > will not get there until next non-IO exit since kvm_run() will reenter > vcpu to complete IO inst

[PATCH] do not enter vcpu again if it was stopped during IO

2010-06-21 Thread Gleb Natapov
To prevent reentering vcpu after IO completion it is not enough to set env->stopped since it is checked only in main loop but control will not get there until next non-IO exit since kvm_run() will reenter vcpu to complete IO instruction. Solve this by sending self-signal to request exit after IO in