Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-06 Thread Jan Kiszka
Glauber Costa wrote: >>> diff --git a/qemu-kvm.c b/qemu-kvm.c >>> index 8c0d463..8fd80c1 100644 >>> --- a/qemu-kvm.c >>> +++ b/qemu-kvm.c >>> @@ -435,6 +435,9 @@ static void *ap_main_loop(void *_env) >>> kvm_create_vcpu(kvm_context, env->cpu_index); >>> kvm_qemu_init_env(env); >>> >>> +

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-06 Thread Glauber Costa
> > diff --git a/qemu-kvm.c b/qemu-kvm.c > > index 8c0d463..8fd80c1 100644 > > --- a/qemu-kvm.c > > +++ b/qemu-kvm.c > > @@ -435,6 +435,9 @@ static void *ap_main_loop(void *_env) > > kvm_create_vcpu(kvm_context, env->cpu_index); > > kvm_qemu_init_env(env); > > > > +/* APIC state cre

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-06 Thread Jan Kiszka
Glauber Costa wrote: > When we create a new vcpu, we need to make sure that > all of the state it is going to use (apic state, for example) > already exists. We can do it nicely by making sure kvm_init_vcpu > is executed after everything else in cpu creation. > > After that, the first call to KVM_

[PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-06 Thread Glauber Costa
When we create a new vcpu, we need to make sure that all of the state it is going to use (apic state, for example) already exists. We can do it nicely by making sure kvm_init_vcpu is executed after everything else in cpu creation. After that, the first call to KVM_SET_LAPIC ioctl will not find an

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-06 Thread Glauber Costa
On Wed, May 06, 2009 at 10:53:06AM -0300, Marcelo Tosatti wrote: > On Tue, May 05, 2009 at 11:16:19PM -0400, Glauber Costa wrote: > > When we create a new vcpu, we need to make sure that > > all of the state it is going to use (apic state, for example) > > already exists. We can do it nicely by mak

Re: [PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-06 Thread Marcelo Tosatti
On Tue, May 05, 2009 at 11:16:19PM -0400, Glauber Costa wrote: > When we create a new vcpu, we need to make sure that > all of the state it is going to use (apic state, for example) > already exists. We can do it nicely by making sure kvm_init_vcpu > is executed after everything else in cpu creatio

[PATCH] execute kvm_init_vcpu in the end of pc_new_cpu

2009-05-05 Thread Glauber Costa
When we create a new vcpu, we need to make sure that all of the state it is going to use (apic state, for example) already exists. We can do it nicely by making sure kvm_init_vcpu is executed after everything else in cpu creation. After that, the first call to KVM_SET_LAPIC ioctl will not find an