Re: [PATCH] kvm: Make kvm_rebooting visible

2013-08-07 Thread Andi Kleen
> > Should this go into 3.11 too? Or it never worked? It's ok to keep it for .12. It was broken since it was merged, but normal builds don't trigger the problem. -andi -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH] kvm: Make kvm_rebooting visible

2013-08-07 Thread Paolo Bonzini
On 08/06/2013 12:12 AM, Andi Kleen wrote: From: Andi Kleen kvm_rebooting is referenced from assembler code, thus needs to be visible. Signed-off-by: Andi Kleen --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_mai

Re: [PATCH] kvm: Make kvm_rebooting visible

2013-08-05 Thread Andi Kleen
> > static void kvm_io_bus_destroy(struct kvm_io_bus *bus); > > > >-bool kvm_rebooting; > >+__visible bool kvm_rebooting; > > EXPORT_SYMBOL_GPL(kvm_rebooting); > > How many of these are there kernel wide? Not very many (at least on x86 allyes) <~10. Also most users are not exported. Probably n

Re: [PATCH] kvm: Make kvm_rebooting visible

2013-08-05 Thread David Daney
On 08/05/2013 03:12 PM, Andi Kleen wrote: From: Andi Kleen kvm_rebooting is referenced from assembler code, thus needs to be visible. Signed-off-by: Andi Kleen --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_mai

[PATCH] kvm: Make kvm_rebooting visible

2013-08-05 Thread Andi Kleen
From: Andi Kleen kvm_rebooting is referenced from assembler code, thus needs to be visible. Signed-off-by: Andi Kleen --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1580dd4..eff6abd 100644 --- a/virt/k