[PATCH] kvm: iommu: Add cond_resched to legacy device assignment code

2014-12-16 Thread Joerg Roedel
From: Joerg Roedel When assigning devices to large memory guests (>=128GB guest memory in the failure case) the functions to create the IOMMU page-tables for the whole guest might run for a very long time. On non-preemptible kernels this might cause Soft-Lockup warnings. Fix these by adding a con

Re: [PATCH] kvm: iommu: Add cond_resched to legacy device assignment code

2014-12-16 Thread Chen, Tiejun
On 2014/12/16 23:47, Joerg Roedel wrote: From: Joerg Roedel When assigning devices to large memory guests (>=128GB guest memory in the failure case) the functions to create the IOMMU page-tables for the whole guest might run for a very long time. On non-preemptible kernels this might cause Soft

Re: [PATCH] kvm: iommu: Add cond_resched to legacy device assignment code

2014-12-17 Thread Joerg Roedel
On Wed, Dec 17, 2014 at 09:38:57AM +0800, Chen, Tiejun wrote: > On 2014/12/16 23:47, Joerg Roedel wrote: > >diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c > >index c1e6ae9..ac427e8 100644 > >--- a/virt/kvm/iommu.c > >+++ b/virt/kvm/iommu.c > > This file is already gone after one latest commit c2

Re: [PATCH] kvm: iommu: Add cond_resched to legacy device assignment code

2014-12-17 Thread Paolo Bonzini
On 17/12/2014 11:35, Joerg Roedel wrote: >> > >> > This file is already gone after one latest commit c274e03af705, >> > "kvm: x86: move assigned-dev.c and iommu.c to arch/x86/" is >> > introduced, so you need to pull your tree firstly :) > Hmm, I based the patch on kvm/master, where the file is

Re: [PATCH] kvm: iommu: Add cond_resched to legacy device assignment code

2014-12-17 Thread Joerg Roedel
On Wed, Dec 17, 2014 at 11:46:24AM +0100, Paolo Bonzini wrote: > > > On 17/12/2014 11:35, Joerg Roedel wrote: > >> > > >> > This file is already gone after one latest commit c274e03af705, > >> > "kvm: x86: move assigned-dev.c and iommu.c to arch/x86/" is > >> > introduced, so you need to pull yo