Re: [PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-22 Thread Paolo Bonzini
On 22/12/2014 10:01, Chen, Tiejun wrote: > I can send out as a patch if we have on any objections. No problem, I will apply it to kvm/queue. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-22 Thread Chen, Tiejun
On 2014/12/19 19:12, Paolo Bonzini wrote: On 19/12/2014 03:32, Chen, Tiejun wrote: Are you saying something below? if (enable_apicv) ... else { kvm_x86_ops->hwapic_irr_update = NULL; Yes. But this means we have to revise hadware_setup() to get 'kvm' inside, This would not eve

Re: [PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 03:32, Chen, Tiejun wrote: > > Are you saying something below? > > if (enable_apicv) > ... > else { > kvm_x86_ops->hwapic_irr_update = NULL; Yes. > But this means we have to revise hadware_setup() to get 'kvm' inside, This would not even be possible, since hardware_setu

Re: [PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-18 Thread Chen, Tiejun
On 2014/12/1 19:43, Paolo Bonzini wrote: On 01/12/2014 10:28, Tiejun Chen wrote: In most cases calling hwapic_isr_update(), actually we always check if kvm_apic_vid_enabled() == 1, and also actually, kvm_apic_vid_enabled() -> kvm_x86_ops->vm_has_apicv() -> vmx_vm_has_apicv() or '

Re: [PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-01 Thread Paolo Bonzini
On 01/12/2014 10:28, Tiejun Chen wrote: > In most cases calling hwapic_isr_update(), actually we always > check if kvm_apic_vid_enabled() == 1, and also actually, > kvm_apic_vid_enabled() > -> kvm_x86_ops->vm_has_apicv() > -> vmx_vm_has_apicv() or '0' in svm case > > So its unnecessa

[PATCH] kvm: x86: remove vmx_vm_has_apicv() outside of hwapic_isr_update()

2014-12-01 Thread Tiejun Chen
In most cases calling hwapic_isr_update(), actually we always check if kvm_apic_vid_enabled() == 1, and also actually, kvm_apic_vid_enabled() -> kvm_x86_ops->vm_has_apicv() -> vmx_vm_has_apicv() or '0' in svm case So its unnecessary to recall this inside hwapic_isr_update(), here just