Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-18 Thread Zang Hongyong
于 2011/12/16,星期五 17:46, Sasha Levin 写道: On Fri, 2011-12-16 at 17:33 +0800, Zang Hongyong wrote: Do you see an issue with increasing kvm-ram_size? Yes, it will cause some problems after simply increase the kvm-ram_size. For examples: In kvm__init_ram() code we use kvm-ram_size to calculate the

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-16 Thread Zang Hongyong
于 2011/12/16,星期五 15:23, Sasha Levin 写道: On Fri, 2011-12-16 at 15:02 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 13:50, Sasha Levin 写道: On Fri, 2011-12-16 at 09:01 +0800, zanghongy...@huawei.com wrote: If a guest's ram_size exceeds KVM_32BIT_GAP_START, the corresponding kvm tool's virtual

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-16 Thread Sasha Levin
On Fri, 2011-12-16 at 16:36 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 15:23, Sasha Levin 写道: On Fri, 2011-12-16 at 15:02 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 13:50, Sasha Levin 写道: On Fri, 2011-12-16 at 09:01 +0800, zanghongy...@huawei.com wrote: If a guest's ram_size exceeds

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-16 Thread Zang Hongyong
于 2011/12/16,星期五 16:45, Sasha Levin 写道: On Fri, 2011-12-16 at 16:36 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 15:23, Sasha Levin 写道: On Fri, 2011-12-16 at 15:02 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 13:50, Sasha Levin 写道: On Fri, 2011-12-16 at 09:01 +0800, zanghongy...@huawei.com

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-16 Thread Sasha Levin
On Fri, 2011-12-16 at 17:33 +0800, Zang Hongyong wrote: Do you see an issue with increasing kvm-ram_size? Yes, it will cause some problems after simply increase the kvm-ram_size. For examples: In kvm__init_ram() code we use kvm-ram_size to calculate the size of the second RAM range from

[PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-15 Thread zanghongyong
From: Hongyong Zang zanghongy...@huawei.com If a guest's ram_size exceeds KVM_32BIT_GAP_START, the corresponding kvm tool's virtual address size should be (ram_size + KVM_32BIT_GAP_SIZE), rather than ram_size. Signed-off-by: Hongyong Zang zanghongy...@huawei.com --- tools/kvm/x86/kvm.c |4

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-15 Thread Sasha Levin
On Fri, 2011-12-16 at 09:01 +0800, zanghongy...@huawei.com wrote: If a guest's ram_size exceeds KVM_32BIT_GAP_START, the corresponding kvm tool's virtual address size should be (ram_size + KVM_32BIT_GAP_SIZE), rather than ram_size. You're right. There are more places than just the

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-15 Thread Zang Hongyong
于 2011/12/16,星期五 13:50, Sasha Levin 写道: On Fri, 2011-12-16 at 09:01 +0800, zanghongy...@huawei.com wrote: If a guest's ram_size exceeds KVM_32BIT_GAP_START, the corresponding kvm tool's virtual address size should be (ram_size + KVM_32BIT_GAP_SIZE), rather than ram_size. You're right. There

Re: [PATCH] kvm tools: Make the whole guest memory mergeable

2011-12-15 Thread Sasha Levin
On Fri, 2011-12-16 at 15:02 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 13:50, Sasha Levin 写道: On Fri, 2011-12-16 at 09:01 +0800, zanghongy...@huawei.com wrote: If a guest's ram_size exceeds KVM_32BIT_GAP_START, the corresponding kvm tool's virtual address size should be (ram_size +