[PATCH] openvswitch: orphan frags on local receive

2014-02-24 Thread Qin Chuanyu
with vhost tx zero_copy, guest nic might get hang when host reserving skb in socket queue delivered by guest, the case has been solved in tun, it also been needed by openvswitch. This could easily happened when a LAST_ACK state tcp occuring between guest and host. Signed-off-by: Chuanyu Qin ---

Re: [PATCH] openvswitch: orphan frags on local receive

2014-02-24 Thread Michael S. Tsirkin
On Mon, Feb 24, 2014 at 09:15:12PM +0800, Qin Chuanyu wrote: > with vhost tx zero_copy, guest nic might get hang when host reserving > skb in socket queue delivered by guest, the case has been solved in > tun, it also been needed by openvswitch. This could easily happened > when a LAST_ACK state tc

Re: [PATCH] openvswitch: orphan frags on local receive

2014-02-24 Thread Zoltan Kiss
Hi, I'm also planning a similar patch, but it will call skb_orphan_frags on the skb in datapath.c::queue_userspace_packet, right before skb_zerocopy, so packets sent up to userspace via Netlink doesn't harm guests. I haven't checked your patch thoroughly, does it handle a different scenario?

Re: [PATCH] openvswitch: orphan frags on local receive

2014-02-24 Thread Qin Chuanyu
On 2014/2/24 22:45, Zoltan Kiss wrote: Hi, I'm also planning a similar patch, but it will call skb_orphan_frags on the skb in datapath.c::queue_userspace_packet, right before skb_zerocopy, so packets sent up to userspace via Netlink doesn't harm guests. I haven't checked your patch thoroughly, d