Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-27 Thread Avi Kivity
On 09/26/2011 09:09 PM, Anthony Liguori wrote: On 09/26/2011 12:24 PM, Avi Kivity wrote: On 09/26/2011 08:23 PM, Jan Kiszka wrote: > > Perhaps qemu_eventfd() can be used in the future instead of an explicit > pipe. Then Linux will do eventfd while other OSes will fall back to > pipes. Basica

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-26 Thread Anthony Liguori
On 09/26/2011 12:24 PM, Avi Kivity wrote: On 09/26/2011 08:23 PM, Jan Kiszka wrote: > > Perhaps qemu_eventfd() can be used in the future instead of an explicit > pipe. Then Linux will do eventfd while other OSes will fall back to > pipes. Basically simpler code, or does this also have runtime b

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-26 Thread Avi Kivity
On 09/26/2011 08:23 PM, Jan Kiszka wrote: > > Perhaps qemu_eventfd() can be used in the future instead of an explicit > pipe. Then Linux will do eventfd while other OSes will fall back to > pipes. Basically simpler code, or does this also have runtime benefits? In corner cases, the comple

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-26 Thread Jan Kiszka
On 2011-09-21 10:06, Stefan Hajnoczi wrote: > On Tue, Sep 20, 2011 at 06:49:49PM +0200, Jan Kiszka wrote: >> Upstream's version is about to be signal-free and will stop handling >> SIGUSR2 specially. So it's time to adopt its implementation, ie. switch >> from signalfd to a pipe. >> >> Signed-off-b

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-26 Thread Avi Kivity
On 09/20/2011 07:49 PM, Jan Kiszka wrote: Upstream's version is about to be signal-free and will stop handling SIGUSR2 specially. So it's time to adopt its implementation, ie. switch from signalfd to a pipe. Applied, thanks. -- error compiling committee.c: too many arguments to function -- T

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-21 Thread Kevin Wolf
Am 20.09.2011 18:49, schrieb Jan Kiszka: > Upstream's version is about to be signal-free and will stop handling > SIGUSR2 specially. So it's time to adopt its implementation, ie. switch > from signalfd to a pipe. > > Signed-off-by: Jan Kiszka > --- > > This should help pulling upstream into qemu

Re: [PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-21 Thread Stefan Hajnoczi
On Tue, Sep 20, 2011 at 06:49:49PM +0200, Jan Kiszka wrote: > Upstream's version is about to be signal-free and will stop handling > SIGUSR2 specially. So it's time to adopt its implementation, ie. switch > from signalfd to a pipe. > > Signed-off-by: Jan Kiszka > --- > > This should help pulling

[PATCH] qemu-kvm: Switch POSIX compat AIO implementation to upstream

2011-09-20 Thread Jan Kiszka
Upstream's version is about to be signal-free and will stop handling SIGUSR2 specially. So it's time to adopt its implementation, ie. switch from signalfd to a pipe. Signed-off-by: Jan Kiszka --- This should help pulling upstream into qemu-kvm when "block: avoid SIGUSR2" is merged. And will help