Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-07 Thread Asias He
On Thu, Mar 07, 2013 at 02:45:48PM -0800, Nicholas A. Bellinger wrote: > On Thu, 2013-03-07 at 08:55 +0800, Asias He wrote: > > On Wed, Mar 06, 2013 at 03:28:00PM +0100, Paolo Bonzini wrote: > > > Il 05/03/2013 23:51, Nicholas A. Bellinger ha scritto: > > > > For making progress with Paolo's vhost-

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-07 Thread Nicholas A. Bellinger
On Thu, 2013-03-07 at 08:55 +0800, Asias He wrote: > On Wed, Mar 06, 2013 at 03:28:00PM +0100, Paolo Bonzini wrote: > > Il 05/03/2013 23:51, Nicholas A. Bellinger ha scritto: > > > For making progress with Paolo's vhost-scsi branch on my side, this was > > > still being blocked by bios boot hangs:

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-06 Thread Asias He
On Wed, Mar 06, 2013 at 03:28:00PM +0100, Paolo Bonzini wrote: > Il 05/03/2013 23:51, Nicholas A. Bellinger ha scritto: > > For making progress with Paolo's vhost-scsi branch on my side, this was > > still being blocked by bios boot hangs: > > > > http://www.spinics.net/lists/target-devel/msg0383

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-06 Thread Asias He
On Wed, Mar 06, 2013 at 06:41:47PM +0100, Paolo Bonzini wrote: > Il 06/03/2013 02:28, Asias He ha scritto: > >> > This can queue up quite a bit of memory if the handler thread > >> > is delayed, no? Can we limit the # of outstanding events? > >> > Will guest recover from a missed event? > > Hmm, go

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-06 Thread Paolo Bonzini
Il 06/03/2013 02:28, Asias He ha scritto: >> > This can queue up quite a bit of memory if the handler thread >> > is delayed, no? Can we limit the # of outstanding events? >> > Will guest recover from a missed event? > Hmm, good point. Will limit the number. The size of 'struct > tcm_vhost_evt' is

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-06 Thread Paolo Bonzini
Il 05/03/2013 23:51, Nicholas A. Bellinger ha scritto: > For making progress with Paolo's vhost-scsi branch on my side, this was > still being blocked by bios boot hangs: > > http://www.spinics.net/lists/target-devel/msg03830.html > > Paolo & Co, any ideas on the latter..? Nope. Asias, do you h

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Asias He
On Tue, Mar 05, 2013 at 04:34:17PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 05, 2013 at 02:21:20PM +0100, Paolo Bonzini wrote: > > Il 05/03/2013 13:11, Michael S. Tsirkin ha scritto: > > >> > + > > >> > + struct vhost_work vs_event_work; /* evt injection work item */ > > >> > + stru

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Asias He
On Tue, Mar 05, 2013 at 05:31:00PM +0800, Wanlong Gao wrote: > On 03/05/2013 05:17 PM, Asias He wrote: > > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > > virtio-scsi), hotplug support is added to virtio-scsi. > > > > This patch adds hotplug and hotunplug support to tcm_vhost. >

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Asias He
On Tue, Mar 05, 2013 at 02:11:25PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 05, 2013 at 05:17:07PM +0800, Asias He wrote: > > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > > virtio-scsi), hotplug support is added to virtio-scsi. > > > > This patch adds hotplug and hotunplu

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Nicholas A. Bellinger
On Tue, 2013-03-05 at 16:34 +0200, Michael S. Tsirkin wrote: > On Tue, Mar 05, 2013 at 02:21:20PM +0100, Paolo Bonzini wrote: > > Il 05/03/2013 13:11, Michael S. Tsirkin ha scritto: > > >> > + > > >> > + struct vhost_work vs_event_work; /* evt injection work item */ > > >> > + struct llis

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2013 at 02:21:20PM +0100, Paolo Bonzini wrote: > Il 05/03/2013 13:11, Michael S. Tsirkin ha scritto: > >> > + > >> > +struct vhost_work vs_event_work; /* evt injection work item */ > >> > +struct llist_head vs_event_list; /* evt injection queue */ > >> > + > >> > +

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 13:11, Michael S. Tsirkin ha scritto: >> > + >> > + struct vhost_work vs_event_work; /* evt injection work item */ >> > + struct llist_head vs_event_list; /* evt injection queue */ >> > + >> > + bool vs_events_dropped; > Documentation pls. > Also - how is this handled during migrat

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Michael S. Tsirkin
On Tue, Mar 05, 2013 at 05:17:07PM +0800, Asias He wrote: > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > virtio-scsi), hotplug support is added to virtio-scsi. > > This patch adds hotplug and hotunplug support to tcm_vhost. > > You can create or delate a LUN in targetcli to ho

Re: [PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Wanlong Gao
On 03/05/2013 05:17 PM, Asias He wrote: > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > virtio-scsi), hotplug support is added to virtio-scsi. > > This patch adds hotplug and hotunplug support to tcm_vhost. > > You can create or delate a LUN in targetcli to hotplug or hotplug a

[PATCH] tcm_vhost: Add hotplug/hotunplug support

2013-03-05 Thread Asias He
In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for virtio-scsi), hotplug support is added to virtio-scsi. This patch adds hotplug and hotunplug support to tcm_vhost. You can create or delate a LUN in targetcli to hotplug or hotplug a LUN in guest. Signed-off-by: Asias He --- driver