Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2015 12:50:26 -0300 Arnaldo Carvalho de Melo wrote: > Cool, Steven, can I take that as an Acked-by for this patch? > Acked-by: Steven Rostedt -- Steve -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 05:49:22PM +0200, Paolo Bonzini escreveu: > > > On 20/10/2015 17:48, Steven Rostedt wrote: > > On Tue, 20 Oct 2015 17:37:43 +0200 > > Paolo Bonzini wrote: > > > >> However, it frankly seems a bit academic. The parsing _will_ work, > >> apart from printing a nonsensical

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Paolo Bonzini
On 20/10/2015 17:48, Steven Rostedt wrote: > On Tue, 20 Oct 2015 17:37:43 +0200 > Paolo Bonzini wrote: > >> However, it frankly seems a bit academic. The parsing _will_ work, >> apart from printing a nonsensical role just like it has always done for >> the past four years. > > I'm not going t

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2015 17:37:43 +0200 Paolo Bonzini wrote: > However, it frankly seems a bit academic. The parsing _will_ work, > apart from printing a nonsensical role just like it has always done for > the past four years. I'm not going to be too picky about it. But things like this may seem aca

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Paolo Bonzini
On 20/10/2015 17:26, Steven Rostedt wrote: > > > > What happens if you run new perf on an older kernel. Is this new plugin > > > > going to be screwed up? Plugins should be backward compatible. > > > > If you run new perf on older kernel, the new plugin will print the > > "role" field (see kvm_

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2015 17:19:12 +0200 Paolo Bonzini wrote: > > > On 20/10/2015 16:44, Steven Rostedt wrote: > > What happens if you run new perf on an older kernel. Is this new plugin > > going to be screwed up? Plugins should be backward compatible. > > If you run new perf on older kernel, the n

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Paolo Bonzini
On 20/10/2015 16:44, Steven Rostedt wrote: > What happens if you run new perf on an older kernel. Is this new plugin > going to be screwed up? Plugins should be backward compatible. If you run new perf on older kernel, the new plugin will print the "role" field (see kvm_mmu_print_role) slightly

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2015 12:32:44 -0200 Arnaldo Carvalho de Melo wrote: > > Ping? Arnaldo, ok to include this patch in my tree? > > Applying, I saw it before, but lost track, perhaps was waiting for > Steven Rostedt to chime in, but now I noticed he wasn't CCed, he is now. What happens if you run

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2015 at 10:10:13PM +0200, Paolo Bonzini escreveu: > On 01/10/2015 12:28, Paolo Bonzini wrote: > > The format of the role word has changed through the years and the > > plugin was never updated; some VMX exit reasons were missing too. > > > > Signed-off-by: Paolo Bonzini > > --- >

Re: [PATCH] tools lib traceevent: update KVM plugin

2015-10-09 Thread Paolo Bonzini
On 01/10/2015 12:28, Paolo Bonzini wrote: > The format of the role word has changed through the years and the > plugin was never updated; some VMX exit reasons were missing too. > > Signed-off-by: Paolo Bonzini > --- > tools/lib/traceevent/plugin_kvm.c | 25 + > 1 file

[PATCH] tools lib traceevent: update KVM plugin

2015-10-01 Thread Paolo Bonzini
The format of the role word has changed through the years and the plugin was never updated; some VMX exit reasons were missing too. Signed-off-by: Paolo Bonzini --- tools/lib/traceevent/plugin_kvm.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/to