[PATCH] vhost: don't forget to schedule()

2012-02-27 Thread Nadav Har'El
This is a tiny, but important, patch to vhost. Vhost's worker thread only called schedule() when it had no work to do, and it wanted to go to sleep. But if there's always work to do, e.g., the guest is running a network-intensive program like netperf with small message sizes, schedule() was *never

Re: [PATCH] vhost: don't forget to schedule()

2012-02-28 Thread Avi Kivity
On 02/27/2012 03:07 PM, Nadav Har'El wrote: > This is a tiny, but important, patch to vhost. > > Vhost's worker thread only called schedule() when it had no work to do, and > it wanted to go to sleep. But if there's always work to do, e.g., the guest > is running a network-intensive program like ne

Re: [PATCH] vhost: don't forget to schedule()

2012-02-28 Thread Nadav Har'El
On Tue, Feb 28, 2012, Avi Kivity wrote about "Re: [PATCH] vhost: don't forget to schedule()": > > + if (need_resched()) > > + schedule(); > > This is cond_resched(), no? It indeed looks similar, but it appears there a

Re: [PATCH] vhost: don't forget to schedule()

2012-02-28 Thread Avi Kivity
On 02/28/2012 04:00 PM, Nadav Har'El wrote: > On Tue, Feb 28, 2012, Avi Kivity wrote about "Re: [PATCH] vhost: don't forget > to schedule()": > > > + if (need_resched()) > > > + schedule(); > > > >

Re: [PATCH] vhost: don't forget to schedule()

2012-03-04 Thread Nadav Har'El
On Tue, Feb 28, 2012, Avi Kivity wrote about "Re: [PATCH] vhost: don't forget to schedule()": > > > > + if (need_resched()) > > > > + schedule(); > > > This is cond_resched(), no? > > >

Re: [PATCH] vhost: don't forget to schedule()

2012-03-04 Thread Michael S. Tsirkin
On Sun, Mar 04, 2012 at 11:10:01AM +0200, Nadav Har'El wrote: > On Tue, Feb 28, 2012, Avi Kivity wrote about "Re: [PATCH] vhost: don't forget > to schedule()": > > > > > + if (need_resched()) > > > > > +

Re: [PATCH] vhost: don't forget to schedule()

2012-03-18 Thread Nadav Har'El
On Sun, Mar 04, 2012, Michael S. Tsirkin wrote about "Re: [PATCH] vhost: don't forget to schedule()": > On Sun, Mar 04, 2012 at 11:10:01AM +0200, Nadav Har'El wrote: > > On Tue, Feb 28, 2012, Avi Kivity wrote about "Re: [PATCH] vh