Re: [PATCH] virtio_blk: ioctl return value fix

2009-07-09 Thread Rusty Russell
On Thu, 9 Jul 2009 03:42:20 am Christoph Hellwig wrote: > On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: > > On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: > > > Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if > > > they expect the block layer to hand

Re: [PATCH] virtio_blk: ioctl return value fix

2009-07-08 Thread Avi Kivity
On 07/08/2009 09:12 PM, Christoph Hellwig wrote: On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if they expect the block layer to handle generic

Re: [PATCH] virtio_blk: ioctl return value fix

2009-07-08 Thread Christoph Hellwig
On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: > On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: > > Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if > > they expect the block layer to handle generic ioctls. > > > > This triggered a BLKROSET failure in

Re: [PATCH] virtio_blk: ioctl return value fix

2009-06-23 Thread Rusty Russell
On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: > Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if > they expect the block layer to handle generic ioctls. > > This triggered a BLKROSET failure in xfsqa #200. Applied. Thanks, Rusty. -- To unsubscribe from this list: s

[PATCH] virtio_blk: ioctl return value fix

2009-06-20 Thread Christoph Hellwig
Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if they expect the block layer to handle generic ioctls. This triggered a BLKROSET failure in xfsqa #200. Signed-off-by: Christoph Hellwig Index: linux-2.6/drivers/block/virtio_blk.c