Re: [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)

2008-09-12 Thread Guillaume Thouvenin
On Tue, 09 Sep 2008 17:51:03 +0300 Avi Kivity [EMAIL PROTECTED] wrote: Guillaume Thouvenin wrote: - case 0x38 ... 0x3d: + case 0x38 ... 0x3b: cmp: /* cmp */ emulate_2op_SrcV(cmp, c-src, c-dst, ctxt-eflags); break; + case 0x3c ...

Re: [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)

2008-09-12 Thread Mohammed Gamal
On Fri, Sep 12, 2008 at 10:40 AM, Guillaume Thouvenin [EMAIL PROTECTED] wrote: On Tue, 09 Sep 2008 17:51:03 +0300 Avi Kivity [EMAIL PROTECTED] wrote: Guillaume Thouvenin wrote: - case 0x38 ... 0x3d: + case 0x38 ... 0x3b: cmp: /* cmp */

Re: [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)

2008-09-10 Thread Avi Kivity
Mohammed Gamal wrote: SrcAcc would remove the need for this change. Stupid question: What does Acc stand for? :) Accumulator (al/ax/eax/rax). In the good old days cpus would have only one register that was able to fully participate in arithmetic operations, typically called A

Re: [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)

2008-09-10 Thread Avi Kivity
Mohammed Gamal wrote: Add call near absolute instruction Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)

2008-09-09 Thread Mohammed Gamal
On Tue, Sep 9, 2008 at 10:16 AM, Guillaume Thouvenin [EMAIL PROTECTED] wrote: On Mon, 8 Sep 2008 21:47:19 +0300 Mohammed Gamal [EMAIL PROTECTED] wrote: + SrcMem | ModRM | Stack, 0, Are you sure about this? In Xen they use DstMem | SrcNone | ModRM Anyway I tested the patch and the next

[PATCH] x86 emulator: Add call near absolute instruction (group5: opcode 0xff mod r/m 2)

2008-09-08 Thread Mohammed Gamal
Add call near absolute instruction Signed-off-by: Mohammed Gamal [EMAIL PROTECTED] --- arch/x86/kvm/x86_emulate.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 3ac2f14..0630d21 100644 ---