Re: [PATCH 0/1] trace all instructions whose emulation failed

2010-04-19 Thread Manish Regmi
On Mon, Apr 19, 2010 at 4:20 AM, Avi Kivity wrote: >>        } >> >> > > It's better not to trace #UD triggered emulations, since we except these to > fail, for example if the guest executes the UD2 instruction. > ya. that sounds more logical. Thanks for explaining. --

Re: [PATCH 0/1] trace all instructions whose emulation failed

2010-04-19 Thread Avi Kivity
On 04/18/2010 09:33 AM, Manish Regmi wrote: Hi, The following patch makes sure all code path of failed emulation runs trace_kvm_emulate_insn_failed(). Please let me know if there is anything missing or wrong. Thank you. Signed-off-by: Manish Regmi diff --git a/arch/x86/kvm/x86.c b/ar

[PATCH 0/1] trace all instructions whose emulation failed

2010-04-17 Thread Manish Regmi
Hi, The following patch makes sure all code path of failed emulation runs trace_kvm_emulate_insn_failed(). Please let me know if there is anything missing or wrong. Thank you. Signed-off-by: Manish Regmi diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index b6e7535..fd1e875 100644