Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-13 Thread Avi Kivity
On 06/13/2011 07:46 AM, Xiao Guangrong wrote: >> >> and it has little heavy sine we need to walk guest page table, >> and build spte under mmu-lock. > > For shadow, yes, this is a good optimization. But with nested paging it slow things down. We already have the gpa, so all we need to do is

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-12 Thread Xiao Guangrong
On 06/12/2011 04:47 PM, Avi Kivity wrote: > On 06/10/2011 07:05 AM, Xiao Guangrong wrote: >> On 06/09/2011 03:39 PM, Avi Kivity wrote: >> >> > First, I think we should consider dropping bypass_guest_pf completely, >> > just so we have less things to think about. >> > >> >> I agree. > > Great, pl

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-12 Thread Avi Kivity
On 06/10/2011 07:05 AM, Xiao Guangrong wrote: On 06/09/2011 03:39 PM, Avi Kivity wrote: > First, I think we should consider dropping bypass_guest_pf completely, just so we have less things to think about. > I agree. Great, please post a patch. > I'm also not sure RCU is enough protection

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-09 Thread Xiao Guangrong
On 06/09/2011 03:39 PM, Avi Kivity wrote: > First, I think we should consider dropping bypass_guest_pf completely, just > so we have less things to think about. > I agree. > I'm also not sure RCU is enough protection - we can unlink a page in the > middle of a hierarchy, I think it is ok, it

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-09 Thread Avi Kivity
On 06/07/2011 03:58 PM, Xiao Guangrong wrote: The idea of this patchset is from Avi: | We could cache the result of a miss in an spte by using a reserved bit, and | checking the page fault error code (or seeing if we get an ept violation or | ept misconfiguration), so if we get repeated mmio on a

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-08 Thread Takuya Yoshikawa
On Wed, 08 Jun 2011 14:22:36 +0800 Xiao Guangrong wrote: > On 06/08/2011 11:47 AM, Takuya Yoshikawa wrote: > > >>> Sure, KVM guest is the client, and it uses e1000 NIC, and uses NAT > >>> network connect to the netperf server, the bandwidth of our network > >>> is 100M. > >>> > > > > I see the

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Xiao Guangrong
On 06/08/2011 11:47 AM, Takuya Yoshikawa wrote: >>> Sure, KVM guest is the client, and it uses e1000 NIC, and uses NAT >>> network connect to the netperf server, the bandwidth of our network >>> is 100M. >>> > > I see the reason, thank you! > > I used virtio-net and you used e1000. > You are usi

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Xiao Guangrong
On 06/08/2011 11:47 AM, Takuya Yoshikawa wrote: >>> Sure, KVM guest is the client, and it uses e1000 NIC, and uses NAT >>> network connect to the netperf server, the bandwidth of our network >>> is 100M. >>> > > I see the reason, thank you! > > I used virtio-net and you used e1000. > You are usi

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Takuya Yoshikawa
On Wed, 08 Jun 2011 11:32:12 +0800 Xiao Guangrong wrote: > On 06/08/2011 11:25 AM, Xiao Guangrong wrote: > > On 06/08/2011 11:11 AM, Takuya Yoshikawa wrote: > >> On Tue, 07 Jun 2011 20:58:06 +0800 > >> Xiao Guangrong wrote: > >> > >>> The performance test result: > >>> > >>> Netperf (TCP_RR): >

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Xiao Guangrong
On 06/08/2011 11:25 AM, Xiao Guangrong wrote: > On 06/08/2011 11:11 AM, Takuya Yoshikawa wrote: >> On Tue, 07 Jun 2011 20:58:06 +0800 >> Xiao Guangrong wrote: >> >>> The performance test result: >>> >>> Netperf (TCP_RR): >>> === >>> ept is enabled: >>> >>> Before

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Xiao Guangrong
On 06/08/2011 11:11 AM, Takuya Yoshikawa wrote: > On Tue, 07 Jun 2011 20:58:06 +0800 > Xiao Guangrong wrote: > >> The performance test result: >> >> Netperf (TCP_RR): >> === >> ept is enabled: >> >> Before After >> 1st 709.58 734.60 >> 2nd 715.40

Re: [PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Takuya Yoshikawa
On Tue, 07 Jun 2011 20:58:06 +0800 Xiao Guangrong wrote: > The performance test result: > > Netperf (TCP_RR): > === > ept is enabled: > > Before After > 1st 709.58 734.60 > 2nd 715.40 723.75 > 3rd 713.45 724.22 > > ept=0 bypas

[PATCH 0/15] KVM: optimize for MMIO handled

2011-06-07 Thread Xiao Guangrong
The idea of this patchset is from Avi: | We could cache the result of a miss in an spte by using a reserved bit, and | checking the page fault error code (or seeing if we get an ept violation or | ept misconfiguration), so if we get repeated mmio on a page, we don't need to | search the slot list/t