Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

2009-05-26 Thread john cooper
Christoph Hellwig wrote: On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote: Christoph Hellwig wrote: So why can't we re-use the existing interfaces instead of inventing a new one? I'm unclear to what specifically you're referring -- the ioctl() used to retrieve the serial number in

Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

2009-05-20 Thread Christoph Hellwig
On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote: Christoph Hellwig wrote: On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote: [Resend of earlier patch: 1/2 rebased to qemu-kvm, 2/2 minor tweak] patch 1/2 seems to be missing. It is in the kvm and qemu-devel list

Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

2009-05-20 Thread Gleb Natapov
On Wed, May 20, 2009 at 03:31:29AM -0400, Christoph Hellwig wrote: On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote: Christoph Hellwig wrote: On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote: [Resend of earlier patch: 1/2 rebased to qemu-kvm, 2/2 minor tweak]

Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

2009-05-18 Thread Christoph Hellwig
On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote: [Resend of earlier patch: 1/2 rebased to qemu-kvm, 2/2 minor tweak] patch 1/2 seems to be missing. Equivalent functionality currently exists for IDE and SCSI, however it is not yet implemented for virtio. So why can't we re-use

Re: [PATCH 0/2] Add serial number support for virtio_blk, V2

2009-05-18 Thread john cooper
Christoph Hellwig wrote: On Wed, May 13, 2009 at 01:06:57PM -0400, john cooper wrote: [Resend of earlier patch: 1/2 rebased to qemu-kvm, 2/2 minor tweak] patch 1/2 seems to be missing. It is in the kvm and qemu-devel list archives: http://www.spinics.net/lists/kvm/maillist.html

[PATCH 0/2] Add serial number support for virtio_blk, V2

2009-05-13 Thread john cooper
[Resend of earlier patch: 1/2 rebased to qemu-kvm, 2/2 minor tweak] This patch allows passing of a virtio_blk drive serial number from qemu into a guest's virtio_blk driver, and provides a means to access the serial number from a guest's userspace. Equivalent functionality currently exists for