Re: [Qemu-devel] Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-12 Thread Jamie Lokier
Alex Williamson wrote: TUNSETTXFITLER has only existed since 2.6.26, so the ioctl will fail on anything older and it will be disabled anyway. The patch will fix .29 and should get rolled into .28 stable, so we're looking at an exposure of 2 kernel releases. Unfortunately a few community

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Mark McLoughlin
Hi Alex, Just had a quick looked over these and they seem pretty good, but some broad comments: - The logic around is this a NIC+TAP pair? would be good to have a better API around. We need this to merge virtio GSO support too. Anthony had some ideas here. - I think you could keep

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Anthony Liguori
Mark McLoughlin wrote: Hi Alex, Just had a quick looked over these and they seem pretty good, but some broad comments: - The logic around is this a NIC+TAP pair? would be good to have a better API around. We need this to merge virtio GSO support too. Anthony had some ideas here.

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Alex Williamson
Hi Mark, Thanks for the comments. On Wed, 2009-02-11 at 19:31 +, Mark McLoughlin wrote: - The logic around is this a NIC+TAP pair? would be good to have a better API around. We need this to merge virtio GSO support too. Anthony had some ideas here. Ok, I'll see if I can dig

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Mark McLoughlin
On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote: - What do we need rxfilter=on|off on the command line for? Primarily because the current tun driver in Linux has a bug that it can drop unicast packets requested to be included in the filter if it overflows the exact match table.

Re: [PATCH 0/4] qemu: TAP filtering support

2009-02-11 Thread Alex Williamson
On Wed, 2009-02-11 at 20:19 +, Mark McLoughlin wrote: On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote: - What do we need rxfilter=on|off on the command line for? Primarily because the current tun driver in Linux has a bug that it can drop unicast packets requested to be

[PATCH 0/4] qemu: TAP filtering support

2009-02-10 Thread Alex Williamson
This series adds infrastructure and support for using the filtering support built into recent Linux kernels. The tap device currently provides a small array for exact MAC address matches, plus a hash for inexact multicast addresses. By programing this filter, we can reduce the number of