Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-02-04 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 07:12:31PM +0900, Takuya Yoshikawa wrote: This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking of additional work already, this alone can reduce the lock hold time to some extent. Takuya Yoshikawa (8): KVM: MMU:

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-02-04 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 06:44:52PM +0800, Xiao Guangrong wrote: On 01/23/2013 06:12 PM, Takuya Yoshikawa wrote: This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking of additional work already, this alone can reduce the lock hold time to

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-02-04 Thread Xiao Guangrong
On 02/04/2013 09:42 PM, Marcelo Tosatti wrote: On Wed, Jan 23, 2013 at 06:44:52PM +0800, Xiao Guangrong wrote: On 01/23/2013 06:12 PM, Takuya Yoshikawa wrote: This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking of additional work already,

[PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-01-23 Thread Takuya Yoshikawa
This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking of additional work already, this alone can reduce the lock hold time to some extent. Takuya Yoshikawa (8): KVM: MMU: Fix and clean up for_each_gfn_* macros KVM: MMU: Use

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-01-23 Thread Xiao Guangrong
On 01/23/2013 06:12 PM, Takuya Yoshikawa wrote: This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking of additional work already, this alone can reduce the lock hold time to some extent. It is not worth doing this kind of complex thing,

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-01-23 Thread Takuya Yoshikawa
On Wed, 23 Jan 2013 18:44:52 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: On 01/23/2013 06:12 PM, Takuya Yoshikawa wrote: This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking of additional work already, this alone can

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-01-23 Thread Xiao Guangrong
On 01/23/2013 09:28 PM, Takuya Yoshikawa wrote: On Wed, 23 Jan 2013 18:44:52 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: On 01/23/2013 06:12 PM, Takuya Yoshikawa wrote: This patch set mitigates another mmu_lock hold time issue. Although this is not enough and I'm thinking

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-01-23 Thread Takuya Yoshikawa
On Wed, 23 Jan 2013 21:45:23 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: The current code which deletes the two link nodes in different functions looks unnatural to me: traversing the sp-link nodes forces us to break the loop and sp-hash_link nodes alone is allowed to

Re: [PATCH 0/8] KVM: Reduce mmu_lock hold time when zapping mmu pages

2013-01-23 Thread Xiao Guangrong
On 01/23/2013 10:49 PM, Takuya Yoshikawa wrote: On Wed, 23 Jan 2013 21:45:23 +0800 Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com wrote: The current code which deletes the two link nodes in different functions looks unnatural to me: traversing the sp-link nodes forces us to break the loop