Re: [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER.

2009-12-02 Thread Avi Kivity
On 12/02/2009 04:16 PM, Avi Kivity wrote: Unfortunately, this does sort of put a damper on what's going on later in the series. If the i8254 doesn't belong to the BSP (which it really shouldn't), then I don't know which vcpu to raise the bit on. Maybe I can do it in the kvm_irq_delivery_to_ap

Re: [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER.

2009-12-02 Thread Avi Kivity
On 12/02/2009 02:59 PM, Chris Lalancette wrote: On 12/01/2009 08:04 PM, Jan Kiszka wrote: Chris Lalancette wrote: KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, but it never seems to be actually checked. Remove it. I would suggest to study the introducing c

Re: [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER.

2009-12-02 Thread Chris Lalancette
On 12/01/2009 08:04 PM, Jan Kiszka wrote: > Chris Lalancette wrote: >> KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, >> but it never seems to be actually checked. Remove it. >> > > I would suggest to study the introducing commit > 06e05645661211b9eaadaf6344c335d2e80f0ba2. My str

Re: [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER.

2009-12-01 Thread Marcelo Tosatti
On Tue, Dec 01, 2009 at 08:04:15PM +0100, Jan Kiszka wrote: > Chris Lalancette wrote: > > KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, > > but it never seems to be actually checked. Remove it. > > > > I would suggest to study the introducing commit > 06e05645661211b9eaadaf6344

Re: [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER.

2009-12-01 Thread Jan Kiszka
Chris Lalancette wrote: > KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, > but it never seems to be actually checked. Remove it. > I would suggest to study the introducing commit 06e05645661211b9eaadaf6344c335d2e80f0ba2. My strong feeling is that this removal is wrong. Jan --

[PATCH 03/12] Remove KVM_REQ_PENDING_TIMER.

2009-12-01 Thread Chris Lalancette
KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, but it never seems to be actually checked. Remove it. Signed-off-by: Chris Lalancette --- arch/x86/kvm/timer.c |5 + arch/x86/kvm/x86.c |1 - include/linux/kvm_host.h |1 - 3 files changed, 1 insertions(+)